From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A851DC10F03 for ; Tue, 23 Apr 2019 20:38:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75CD5218B0 for ; Tue, 23 Apr 2019 20:38:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I4hOLYFS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75CD5218B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1asZYcP5XlNvoH1FShr1lit9gNzaEOL7f3iTcTOD0X0=; b=I4hOLYFSGLy8Yg S1RrocKgezYcEaHHz1fSxri/ilBsxCqGzTH1j+9WnNJOsPdwo4cZekekC4gIhI3JzL/Uog9BPraha r5Ybc9k1PCBTihClRSr4HaTuOanYCiZawYJ0C3iTdsnL5p3X5ccmylQtFoCbx+tUEqZzLjMESAwJY 3SS7j2jJVj41Tdj1P+IqIO3V6iZPe6cdosXwiJKwlFidsGp43XVLOIusQ+5qij+eg3BdIV2CLNopm 268UN6KgCEu2il+7cnZFkbN/cZHbn80kUXaKKSaTYYsyxRUj5tjIWvcC9jOde17gWjiALFJOCsUSz NgvEBBL5ek6InJ+DJ3zQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJ2B5-0000VV-Fe; Tue, 23 Apr 2019 20:38:07 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJ2B2-0000VA-HX for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2019 20:38:05 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 342CAC0703A7; Tue, 23 Apr 2019 20:38:04 +0000 (UTC) Received: from treble (ovpn-123-99.rdu2.redhat.com [10.10.123.99]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6739D5C1B5; Tue, 23 Apr 2019 20:38:02 +0000 (UTC) Date: Tue, 23 Apr 2019 15:37:54 -0500 From: Josh Poimboeuf To: Raphael Gault Subject: Re: [RFC 5/6] arm64: sleep: Add stack frame setup for __cpu_supsend_enter Message-ID: <20190423203754.mdtjssru2h2rzqou@treble> References: <20190409135243.12424-1-raphael.gault@arm.com> <20190409135243.12424-6-raphael.gault@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190409135243.12424-6-raphael.gault@arm.com> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Apr 2019 20:38:04 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190423_133804_599733_C7858868 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: julien.thierry@arm.com, peterz@infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org In $SUBJECT, s/supsend/suspend/. On Tue, Apr 09, 2019 at 02:52:42PM +0100, Raphael Gault wrote: > Annotate cpu_resume and _cpu_resume to silence objtool warning > about non-standard stack frame. > > Signed-off-by: Raphael Gault > --- > arch/arm64/kernel/sleep.S | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/kernel/sleep.S b/arch/arm64/kernel/sleep.S > index 3e53ffa07994..eb434525fe82 100644 > --- a/arch/arm64/kernel/sleep.S > +++ b/arch/arm64/kernel/sleep.S > @@ -90,6 +90,7 @@ ENTRY(__cpu_suspend_enter) > str x0, [x1] > add x0, x0, #SLEEP_STACK_DATA_SYSTEM_REGS > stp x29, lr, [sp, #-16]! > + mov x29, sp Why is it changing the actual code? The patch description indicates that it's only adding annotations. > bl cpu_do_suspend > ldp x29, lr, [sp], #16 > mov x0, #1 > @@ -146,3 +147,6 @@ ENTRY(_cpu_resume) > mov x0, #0 > ret > ENDPROC(_cpu_resume) > + > + asm_stack_frame_non_standard cpu_resume > + asm_stack_frame_non_standard _cpu_resume > -- > 2.17.1 > -- Josh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel