From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 799EFC10F11 for ; Wed, 24 Apr 2019 11:28:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 466E021773 for ; Wed, 24 Apr 2019 11:28:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="t+nbdGHI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fvFgMT0H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 466E021773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xlWbcko8NI8tyVoatopW/5rmnsMuvw/PtAkS07+xWIM=; b=t+nbdGHIAlGXe6 mAU+6QftLBpyNiQgpQj+x9k2R+DtvhsQZoz6on/EAjVIrZoZQQ9PiXUL9vAqsYwARFR/KiqriRLcH DBSWpH+TcLHj1PLUoovq+35Mm+jo6NY2nMrcmoFaR/8e+Y9SBY3B7XuJVE0V2uYXz7sFfjVt84M+4 ZFM43Lmu5jPT9QgvgK38RYXZUY2/8GxfJCOMZeI0ZzFOm9kI8IVbxsLINOVCNR2cumgGnSROHJjHE AyeVrtZ4l7UforoeLxmdET18Kyn3vne2wdggS+RnhBnxNQyr+QRvtcLbdeLfSwhY39Lu6tW1cf69y L1vefNBWc9AmNFs3VOKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJG4i-0000TH-A4; Wed, 24 Apr 2019 11:28:28 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJG4f-0000Sm-I8 for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 11:28:26 +0000 Received: by mail-lf1-x144.google.com with SMTP id j20so14371692lfh.2 for ; Wed, 24 Apr 2019 04:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zzvC/I/Gu9rK4bmZmQZJou+6+hsvOOS4ENInmjNp8gE=; b=fvFgMT0HFBUbT6XcwleukJ1uTKZ7GnMk+kJBkPIB2CxyQgYqxvL2ic0eIzKnM0xnX6 creck7YFBKo8cucKEQQWWfIiBnzxNc9bLad9CXJWHfnoePjqAcmOJpdIEDgM91h7LuoS 1g6UYE11IERvENpFobkhwvmRD4ANGDR7bNwvhZqriHoIEAkBpamIlpaIYG/9bMdD1iMP zO9+nAXRKmSE8i2yEVJ2+Fz51F0Es+G8Y9/fPrhja4rWo54MAiSJXxum1+JT2UGtgjKq UfCgzawENXAuV0fiyWcj1sCrUHQ7a7vj4uiUce2rvZMoA8SP1YNIoOu2j0tvIHN87Jl4 BKwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zzvC/I/Gu9rK4bmZmQZJou+6+hsvOOS4ENInmjNp8gE=; b=CsQXDwJdrljb/Dtkf3FzYnFYVvGbk6oU9Lz9L7PkX3ABdyWzZv6BSQ7oCAdNNj69hC cJAE5E0mBDv7jbafQG5PYM+UzF9f8s/mIjiih19QeuXhIN6HE7eFSYpVf6nIHhPaSaCR tOuZ5IR2wr3YRID5QuNRznvMlpWc1iBffzJryIVRJ6N68aFKxgGsMjJoactPnChsXYcg xOuun/UsPuWTRqhnXbYn7zvuDTMZ8GZgYVt0KME5oI2sD+s9lhuNfk+21rIb6HhKh7Gp 0efOV0Vbb6bN/WXdrAZX4vWivaf1hDRxzZJ3EmEdQrlXgTIU3MdBLEKAbOmjw2nyX4mf GjiA== X-Gm-Message-State: APjAAAVvPjdvCeFCrmnZp3Oeg2TI81hIHqgjB/9j9B3cIII7iJNevWOp JDJETBz0THJALkHWVDFbc/+zEw== X-Google-Smtp-Source: APXvYqxS0A1Xt4Hd7k29/jDCI2DLTZzsQWJDtTo5H0Z1BdSV9/s7/JLM1h++Ap00K5VSYRlVUvUBbg== X-Received: by 2002:ac2:518b:: with SMTP id u11mr17974012lfi.46.1556105301834; Wed, 24 Apr 2019 04:28:21 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id k73sm467649ljb.6.2019.04.24.04.28.20 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Apr 2019 04:28:21 -0700 (PDT) Date: Wed, 24 Apr 2019 13:28:18 +0200 From: Niklas Cassel To: Ulf Hansson Subject: Re: [PATCH 1/3] PM / Domains: Don't kfree() the virtual device in the error path Message-ID: <20190424112818.GA30710@centauri.ideon.se> References: <20190418102757.1246-1-ulf.hansson@linaro.org> <20190418102757.1246-2-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190418102757.1246-2-ulf.hansson@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_042825_610377_36CBBBCC X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajendra Nayak , linux-pm@vger.kernel.org, Greg Kroah-Hartman , Kevin Hilman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Jon Hunter , Viresh Kumar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2019 at 12:27:55PM +0200, Ulf Hansson wrote: > It's not correct to call kfree(dev) when device_register(dev) has failed. > Fix this by calling put_device(dev) instead. > > Fixes: 3c095f32a92b ("PM / Domains: Add support for multi PM domains per device to genpd") > Signed-off-by: Ulf Hansson > --- > drivers/base/power/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index ecac03dcc9b2..7fec69aebf46 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2528,7 +2528,7 @@ struct device *genpd_dev_pm_attach_by_id(struct device *dev, > > ret = device_register(virt_dev); > if (ret) { > - kfree(virt_dev); > + put_device(virt_dev); > return ERR_PTR(ret); > } > > -- > 2.17.1 > Acked-by: Niklas Cassel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel