From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52EFBC10F11 for ; Wed, 24 Apr 2019 11:29:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C81521773 for ; Wed, 24 Apr 2019 11:29:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rp4kC6ug"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bTIpmdra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C81521773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0d6rS44YFK7j8HG/h8cpdMoy3iahay7zCZGW/DrYzSs=; b=rp4kC6ugkSbD7a VCzKMbScXI7TfJ1KzE/CfL6jrF5wiVs8E4MVSioJ9D7bKXcjVvpCdUT1PuhmoYxrHul0hkMLGsQVF 0L8dyd67ZSrmfdzRhVYHg7v8/CNAzdJxuqmWiwCWEFaw8XYQJg9E6/NCZasltcYq1Y4RoeD+EFAJr jvTjf17arvP/toWoQr4L8mb7MaoMkLv6bnLelZcN57BOc+Me5oJiApqrZRGkbET7oZKFruLAX5A3M z+A+ci11ub6EETeJ5FldAj0jJ86qJ9s4p6Dj2VdNPLoODWDAiWXJPZfqTDKbuCCSoVT8vlyo7wV5h oEgWar4y0rcVEBt3kzWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJG5H-0000ws-GU; Wed, 24 Apr 2019 11:29:03 +0000 Received: from mail-lj1-x241.google.com ([2a00:1450:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJG5D-0000vG-Mt for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2019 11:29:01 +0000 Received: by mail-lj1-x241.google.com with SMTP id l6so1688998ljb.3 for ; Wed, 24 Apr 2019 04:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zpPSRLRBcyEqIGmktIrdBgDpqqRpEiCH6Crl7bTU3UA=; b=bTIpmdradLnpLzBM7YP1RVNVFZ0QsZ4jEYaJE/LUn5pXz1hnC27Mvon1cq/dOfNgdf yIchW05XeRH+NONN4sZvVKRVloxINARkgO+ukbvCYMPprysL3jaRvTSDYOUgh56fYRiY tquEPkKu82elaEldCzsnnoKHKOKEAFgV4/twy/bRQFArlp3x1htX2el5MxJBXIr0Lyk/ 58VrnT/lznZ8FWJ+RSyfRWf1AgM7LU6/wfrJuZRWKy0zhgDeIl5aJ9nLvbtUfCntjEez NlKEIRF/cQaE0xjl8RWnvVOMd9xCI1XWRlzr2Svv+1pcENq3I+rlFuRp+RIqHeoV6Lce ZjTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zpPSRLRBcyEqIGmktIrdBgDpqqRpEiCH6Crl7bTU3UA=; b=RRZLPxmy+3dAP/fep4sC4BQHVtvIQC0Dipn9OmAb9SLcmaSWpiZBEkEAvWdqbNCXrv YMBNSqqXHgFs5gRoJb2xz7uR5IO+FE/jPqCv1TiFo0qSNieJ35a2XB2YAsQ3w1Nb26TV vERzBPfYp6NDRigP3c0hgoXYAUNAnjpcnmBWt6LHnTBY+SpRDTpkYc5p1tAizbGEYfZh Vfk0gSIMyNx7TLT3KR8I8pBQKUHeDOs5F4UgaXdHl93t1v0KEkdmQmvpNkQZxSbuGW3U nNU4MhS/0PId3sCOYEVQxSj7sYGOlTzzdbBjGcgqWptB/evEmN3GSKTMgZPUuz/Hc5v3 Y5Bg== X-Gm-Message-State: APjAAAWj8b29/TQBrlqyBeDWzhDYAqlQdmRZzSHcUiz+BWhyRYX0+dCW DBHdMfLo6p5GaM7QhO5fukT36Q== X-Google-Smtp-Source: APXvYqyFU5bR3HJZqu6EXiTK117Zn0neKbs/DPxre9uviJoFF/dAKpHCF74YAx3MTuDH8nmDD5zatw== X-Received: by 2002:a2e:90c9:: with SMTP id o9mr17696263ljg.102.1556105336951; Wed, 24 Apr 2019 04:28:56 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id f1sm3831573ljc.73.2019.04.24.04.28.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 24 Apr 2019 04:28:56 -0700 (PDT) Date: Wed, 24 Apr 2019 13:28:53 +0200 From: Niklas Cassel To: Ulf Hansson Subject: Re: [PATCH 3/3] PM / Domains: Enable genpd_dev_pm_attach_by_id|name() for single PM domain Message-ID: <20190424112853.GC30710@centauri.ideon.se> References: <20190418102757.1246-1-ulf.hansson@linaro.org> <20190418102757.1246-4-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190418102757.1246-4-ulf.hansson@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_042900_625076_96CA7E30 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajendra Nayak , linux-pm@vger.kernel.org, Greg Kroah-Hartman , Kevin Hilman , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Jon Hunter , Viresh Kumar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 18, 2019 at 12:27:57PM +0200, Ulf Hansson wrote: > If a call to dev_pm_domain_attach() succeeds to attach a device to its > single PM domain, the important point is to prevent following calls to nit: s/prevent/ensure/ > dev_pm_domain_attach_by_name|id() to fail. This is managed by checking the > dev->pm_domain pointer and then return -EEXIST, rather than continue > calling genpd_dev_pm_attach_by_id|name(). > > For this reason, let's enable genpd_dev_pm_attach_by_id|name() to be used > for also single PM domains. This simplifies for future users to solely make > use of dev_pm_domain_attach_by_id|name() rather than having to combine it > with dev_pm_domain_attach(). > > Signed-off-by: Ulf Hansson > --- > drivers/base/power/domain.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 801f31c87d16..1b026704a8fc 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -2512,10 +2512,10 @@ struct device *genpd_dev_pm_attach_by_id(struct device *dev, > if (!dev->of_node) > return NULL; > > - /* Deal only with devices using multiple PM domains. */ > + /* Verify that the index is within a valid range. */ > num_domains = of_count_phandle_with_args(dev->of_node, "power-domains", > "#power-domain-cells"); > - if (num_domains < 2 || index >= num_domains) > + if (index >= num_domains) > return NULL; > > /* Allocate and register device on the genpd bus. */ > -- > 2.17.1 > Acked-by: Niklas Cassel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel