From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 817D7C10F11 for ; Wed, 24 Apr 2019 19:56:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 477742077C for ; Wed, 24 Apr 2019 19:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gI7deVi2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 477742077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oAjXoNRUJjKxhlNX0OKhrIvu/+0FFHYjx9a35AcqihI=; b=gI7deVi2HrM5ge oTIIGKOuZue3ukG0VzQrtf9LGCEeza0LqEQkqv40n0EAs4kohqVmh1VfeJjdMaVrM2gZPxdMB/Vb9 7FJxC0xUC/2S59VRLT4R+a1SYE7x74MEIWj+fL+uFTL0tVNFJ2amjv8CQ7DSyafrhM7EtK27B35YM ilJZqr0+DCV4dhNZEbDitnQgXBNcEoejIAP5ZtWsnElXxA7KHHt/xoDev8F5rtltbCgAyhSo1irpS F0arwAhBSglwDBMIaQy6xT5TNN4/GWaByTAbedTbMzj7ni1vA2b/sQpnO0axP8TAdnprsn3nVyDY1 y0TFHGWLF9v3zbRAwC7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJO0K-00011I-J1; Wed, 24 Apr 2019 19:56:28 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hJO0H-00010V-2o; Wed, 24 Apr 2019 19:56:26 +0000 Received: by mail-oi1-f196.google.com with SMTP id v7so15328616oie.8; Wed, 24 Apr 2019 12:56:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=20tjOs5lkt8HOpIZuEAhDCtz3Zk/SR29ZFUGIW31En0=; b=TS6Gf3jU/MICoCTbAXrbNbBD10VWu/vIXaK7QAFhKTax0rbwbcZz/C2t6J6jZiIxV5 28uMtZ6UYroGKI2gE8LMkj9AEH7T1e3VFBzSFj/ufAHVj7HfIM/iqgPF3JVm70in+oNy XeXVQ49g707GmRHQWdKzbfiunB8tfTB/V2pv8V/a8p1E3LYsHrhR6Ip5Z0oTuu8xivPK ftxBhQSfpRvHh1tz9nzBZj2CNlodnAPvV4SXXM20l4Ys35+6Z9DLWB0LcQ/AnZexLFMW goJHdRBrNh1ZGuc7ZvQg+MMpOH9ua+eUdynTAEOE7j4mU1g97CYmoLLPPTAy29A7Cmv7 7MDQ== X-Gm-Message-State: APjAAAWKV+fLIKagkqU0Ty3VfaVePDYC1CiCN4bO8JH1UYYJbTKT+ZzJ X08GbL7T4YszIKhck+Pmr+JpEC8= X-Google-Smtp-Source: APXvYqy1AsQ1m3VXKqDbGaZdcv9Hptsq+4jNZUzqEez8a6MrXiEimrnQ0KIW3sxENoU7rPMFMv8Whg== X-Received: by 2002:aca:bdc6:: with SMTP id n189mr562593oif.77.1556135783603; Wed, 24 Apr 2019 12:56:23 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g12sm8216830otr.18.2019.04.24.12.56.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 12:56:22 -0700 (PDT) Date: Wed, 24 Apr 2019 14:56:21 -0500 From: Rob Herring To: Bibby Hsieh Subject: Re: [PATCH v4 03/12] dt-binding: gce: add binding for gce event property Message-ID: <20190424195621.GC7270@bogus> References: <20190415125833.38704-1-bibby.hsieh@mediatek.com> <20190415125833.38704-4-bibby.hsieh@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190415125833.38704-4-bibby.hsieh@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190424_125625_119339_FC2B95E7 X-CRM114-Status: GOOD ( 18.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , YT Shen , CK HU , Dennis-YC Hsieh , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 08:58:24PM +0800, Bibby Hsieh wrote: > Client hardware would send event to GCE hardware, > so #event-cells, mediatek,gce-event-names, mediatek,gce-events. > present the event. > > Signed-off-by: Bibby Hsieh > --- > .../devicetree/bindings/mailbox/mtk-gce.txt | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > index 1f7f8f2a3f49..2f175d6b296d 100644 > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > @@ -21,12 +21,21 @@ Required properties: > priority: Priority of GCE thread. > atomic_exec: GCE processing continuous packets of commands in atomic > way. > +- #event-cells: Should be 1. > + <&phandle event_number> > + phandle: Label name of a gce node. > + event_number: the event number defined in 'dt-bindings/gce/mt8173-gce.h' > + or 'dt-binding/gce/mt8183-gce.h'. I thought you were going to remove this. > > Required properties for a client device: > - mboxes: Client use mailbox to communicate with GCE, it should have this > property and list of phandle, mailbox specifiers. > - mediatek,gce-subsys: u32, specify the sub-system id which is corresponding > to the register address. > +Optional propertier for a client device: > +- mediatek,gce-event-names: the event name can be defined by user. > +- mediatek,gce-events: u32, the event number defined in > + 'dt-bindings/gce/mt8173-gce.h' or 'dt-binding/gce/mt8183-gce.h'. >From the example, looks like a phandle plus 1 cell. > > Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h' > or 'dt-binding/gce/mt8183-gce.h'. Such as sub-system ids, thread priority, event ids. > @@ -40,6 +49,7 @@ Example: > clocks = <&infracfg CLK_INFRA_GCE>; > clock-names = "gce"; > #mbox-cells = <3>; > + #event-cells = <1>; > }; > > Example for a client device: > @@ -49,8 +59,9 @@ Example for a client device: > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > mediatek,gce-subsys = ; > - mutex-event-eof = - CMDQ_EVENT_MUTEX1_STREAM_EOF>; > - > + mediatek,gce-event-names = "rdma0_sof", > + "rsz0_sof"; > + mediatek,gce-events = <&gce CMDQ_EVENT_MDP_RDMA0_SOF>, > + <&gce CMDQ_EVENT_MDP_RSZ0_SOF>; > ... > }; > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel