From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71FEC43218 for ; Fri, 26 Apr 2019 14:25:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A84A4206C1 for ; Fri, 26 Apr 2019 14:25:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i3mgZNEx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A84A4206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TKBP/KQTxjRE4MntufD0lR98lVUS4S4U4HNKm3aQroo=; b=i3mgZNExQIUzQx kUiT39UnpF5MhEqmfIXjC8p78TYsJ81rhy8cQmKlQx1O2QO7hgFBW4RoM8FcDC8AvNneygLF4gdQs FZB1pNPHJPL+z53spkC+wMipCevsZYLA+zGURBq63M8QldTx4jCRi4BmJym9yE44FKx2F/RuVm/ZZ SFooCMILCJyGXPCyy3Ll1rY1yzntg4Vm5YbHEIFYqiUCknnIz+gFsCInQGie0YW2ULKC3j6BI+m24 krFP6wYG2O8/D5csxTslrfdyzd41AKlcD38rAxVcllS0JR5le1VcFnzwLWyQNRqwRkufVvQLXwzux FXiNJXKC8m8FSsLmthnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK1ms-0000SQ-1e; Fri, 26 Apr 2019 14:25:14 +0000 Received: from mail-oi1-f193.google.com ([209.85.167.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK1mp-0000Rn-HB for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2019 14:25:13 +0000 Received: by mail-oi1-f193.google.com with SMTP id t189so35372oih.12 for ; Fri, 26 Apr 2019 07:25:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aWqo1UFpmIRDnB30jQmwpXG9gfEZ8sd9ampIb2LCeW0=; b=QmahAGxhQziL/Su4YHulHFn81+VocjatfWaYI1es+mB8QpM1g68X/ZRTlzdOJ8mabT b8UAd+YFlgF9aZVzpA0leC1BeIV969655agbd37XbO5CuLLpFUGyNtoM7tE/Qch3KLwd bDGAVi7CFjOAkG680wletjuArzWU911HFJ54gSOI4C0/xh//dp59SbBoZZYBpOU98HCr AcNeFq0zpsMwpXYXHMGb3Y1IbggOm3s5opvftodVrsISfxeZRXif+jgt/Go+fOCB45F2 nwMPV95r5yaCnCpF7OeEa1veMMUwjaAaSpoC5KBLjNUYyG4FB71YATQx1RJL1sQs2ICp cgYQ== X-Gm-Message-State: APjAAAV91JB6U8ywE1dosOgy5teUA2ZhgZCG39Tu7NDIcJaOk5vqu3yU itUcF4xCU1/XqEwYi9lMvQ== X-Google-Smtp-Source: APXvYqzifDIBM00sH2axs4WjBsHqjbsl0SmPUGcKtuYwcX8xiXqAJprl61Bjq2AERdHwoJj1H18wNQ== X-Received: by 2002:aca:544b:: with SMTP id i72mr6708318oib.51.1556288708767; Fri, 26 Apr 2019 07:25:08 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id b17sm10440879otq.26.2019.04.26.07.25.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 07:25:08 -0700 (PDT) Date: Fri, 26 Apr 2019 09:25:07 -0500 From: Rob Herring To: Mathieu Poirier Subject: Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator Message-ID: <20190426142507.GA8721@bogus> References: <20190412102738.12679-1-leo.yan@linaro.org> <20190412102738.12679-2-leo.yan@linaro.org> <20190417000959.GB6202@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_072511_572848_E54043A0 X-CRM114-Status: GOOD ( 30.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Suzuki K Poulose , Alexander Shishkin , Linux Kernel Mailing List , Leo Yan , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 17, 2019 at 07:57:50AM -0600, Mathieu Poirier wrote: > On Tue, 16 Apr 2019 at 18:10, Leo Yan wrote: > > > > On Tue, Apr 16, 2019 at 02:18:40PM -0600, Mathieu Poirier wrote: > > > Hi Leo, > > > > > > On Fri, 12 Apr 2019 at 04:28, Leo Yan wrote: > > > > > > > > CoreSight uses below bindings for replicator: > > > > > > > > Dynamic replicator, aka. configurable replicator: > > > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > > > > > Static replicator, aka. non-configurable replicator: > > > > "arm,coresight-replicator"; > > > > > > > > The compatible string "arm,coresight-replicator" is not an explicit > > > > naming to express the replicator is 'static'. To unify the naming > > > > convention, this patch introduces a new compatible string > > > > "arm,coresight-static-replicator" for the static replicator; the > > > > compatible string "arm,coresight-replicator" is kept for backward > > > > compatibility, but tag it as obsolete and suggest to use the new > > > > compatible string. > > > > > > > > As result CoreSight replicator have below bindings: > > > > > > > > Dynamic replicator: > > > > "arm,coresight-dynamic-replicator", "arm,primecell"; > > > > > > > > Static replicator: > > > > "arm,coresight-static-replicator"; > > > > "arm,coresight-replicator"; (obsolete) > > > > > > > > Signed-off-by: Leo Yan > > > > --- > > > > Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++-- > > > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt > > > > index f8aff65ab921..d02d160fa8ac 100644 > > > > --- a/Documentation/devicetree/bindings/arm/coresight.txt > > > > +++ b/Documentation/devicetree/bindings/arm/coresight.txt > > > > @@ -69,7 +69,10 @@ its hardware characteristcs. > > > > > > > > * compatible: Currently supported value is (note the absence of the > > > > AMBA markee): > > > > - - "arm,coresight-replicator" > > > > + - Coresight Non-configurable Replicator: > > > > + "arm,coresight-static-replicator"; > > > > + "arm,coresight-replicator"; (OBSOLETE. For backward > > > > + compatibility and will be removed) > > > > > > > > * port or ports: see "Graph bindings for Coresight" below. > > > > > > > > @@ -169,7 +172,7 @@ Example: > > > > /* non-configurable replicators don't show up on the > > > > * AMBA bus. As such no need to add "arm,primecell". > > > > */ > > > > - compatible = "arm,coresight-replicator"; > > > > + compatible = "arm,coresight-static-replicator"; > > > > > > > > out-ports { > > > > #address-cells = <1>; > > > > -- > > > > 2.17.1 > > > > > > Since this is a binding patch it needs to be sent on its own. > > > > Thanks for reminding, Mathieu. > > > > Since this is the second time you remind me to send DT binding related > > patches separately, so I may misunderstand your meaning and want to get > > clarification to avoid making the same mistake for many times. > > > > Before I remembered in one patch set we need to organise patches with > > sending document patch (or document changing patch) ahead and then > > followed by the corresponding code change patch. So this can give the > > reviewers more clear context; and this also can present the merging > > dependency between document change patches and the code change patches. > > > > This is the rule I followed in this patch set and I sent to CoreSight > > and DT maintainers (and mailing lists) together. > > > > Please let me know what you think about this? And also welcome > > Rob/Mark's suggestions. > > https://www.kernel.org/doc/Documentation/devicetree/bindings/submitting-patches.txt I'm not clear on what you are asking for. Binding patches should be separate patch, but can and should still be in a series if there's relevant code changes. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel