From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC39C43219 for ; Fri, 26 Apr 2019 14:30:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC900206C1 for ; Fri, 26 Apr 2019 14:30:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MoMkhjHt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC900206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n31RrhdigtIN3ZiwX/u5NcxvlU+nQLRB6hfnoxue1lQ=; b=MoMkhjHtdW+MzS YTqIwqmyWxFgX7H4g/cDLHeQpddigZczlRmiOgOPZIBKEi2uRZDv84kR7VHsyXfUe/IzV3b1QC22p QnpFHUuPpEtRfwfon8Kv+BpUluDjTFtGfPC1VFLr1/Srv7XCBYHxt3RqDlQvfSUNp6RFklbcT+haW cJ6UPeveTbEOEMmruXiypM9BEzuuJjX1eEsk/3SOWy5D9mvT5rg7C8an5CSRfhEN2w4XlHJodUUuU e6MXnvBEKL+rcftMIWirWQtktdeQvq8GMm50lmoR7fpSrCpMPzi1SeE0+bGaHr+CImJZ3wedTZfEs mTJIfTIILYcirZJ80MRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK1s0-00038I-G3; Fri, 26 Apr 2019 14:30:32 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK1ry-00037x-07 for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2019 14:30:31 +0000 Received: by mail-oi1-f196.google.com with SMTP id l1so1237037oib.0 for ; Fri, 26 Apr 2019 07:30:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VNG/0QpUCaT9lx2u5hHDw2Uwd0JzNWO4DjhMbkVIeuw=; b=Gbu+KP3dt3tCfB0XLxcSmRpPk8YNE4uBjm2mme/KaI0FTwZU1wfsH4Iq2BZ3Aq0mx3 cRdi60bTInkl1vNwPCXQxFIbFrc3Y2k248HKolIMf3cNjdjMU6pSNf+bZ1XdosVLiIw8 fWOaMTqGZmZAej1ayxaSorlD5stQx8j4KHgCJo0dJejubR0WDizxBKRL4YwPQIN5puSp kTchzX0/yl5vk9iossM+VrJvfoo5ZIZp/Rv/KLqDpseLObaBZAXRFynsQ2+gM2jDxnoK of+cnumzlLm+uCyVbG+iQrxFujxnh/KHOOV2LFN35Ecmmj0EU1Me5VrqmtAhyQwKqSgf kmkQ== X-Gm-Message-State: APjAAAWFdywsIpOUdFFrG9q80/TazXbJK5opOBf98nhM3t3/wS1BSq4G DoYWk4VSvyBmMi9L2XBfJg== X-Google-Smtp-Source: APXvYqy6niOVpevFXbrBpfSYrmPPwaca4AgezLS9/JVhRiw+sgF2t41sPPeQDVj7hkQenEW/O8z3Iw== X-Received: by 2002:aca:da07:: with SMTP id r7mr7638281oig.5.1556289028625; Fri, 26 Apr 2019 07:30:28 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id j18sm9969662otq.68.2019.04.26.07.30.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 07:30:27 -0700 (PDT) Date: Fri, 26 Apr 2019 09:30:27 -0500 From: Rob Herring To: Gregory CLEMENT Subject: Re: [PATCH v5 1/6] dt-bindings: ap806: add the cluster clock node in the syscon file Message-ID: <20190426143027.GA17777@bogus> References: <20190423095107.21091-1-gregory.clement@bootlin.com> <20190423095107.21091-2-gregory.clement@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190423095107.21091-2-gregory.clement@bootlin.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_073030_035616_F09B32FA X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Andrew Lunn , Stephen Boyd , Mike Turquette , linux-kernel@vger.kernel.org, Maxime Chevallier , Antoine Tenart , Thomas Petazzoni , =?iso-8859-1?Q?Miqu=E8l?= Raynal , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 23, 2019 at 11:51:02AM +0200, Gregory CLEMENT wrote: > Document the device tree binding for the cluster clock controllers found > in the Armada 7K/8K SoCs. > > Signed-off-by: Gregory CLEMENT > --- > .../arm/marvell/ap806-system-controller.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > index 7b8b8eb0191f..a65d3e9ff915 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > +++ b/Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt > @@ -143,3 +143,29 @@ ap_syscon1: system-controller@6f8000 { > #thermal-sensor-cells = <1>; > }; > }; > + > +Cluster clocks: > +--------------- > + > +Device Tree Clock bindings for cluster clock of AP806 Marvell. Each > +cluster contain up to 2 CPUs running at the same frequency. > + > +Required properties: > +- compatible: must be "marvell,ap806-cpu-clock"; > +- #clock-cells : should be set to 1. > +- clocks : shall be the input parents clock phandle for the clock. > +- reg: register range associated the cluster clocks, offset must be 0 > + and the size have to be the whole size of the system-controller > + > + > +ap_syscon1: system-controller@6f8000 { > + compatible = "syscon", "simple-mfd"; This should have a specific compatible. > + reg = <0x6f8000 0x1000>; > + > + cpu_clk: clock-cpu@0 { > + compatible = "marvell,ap806-cpu-clock"; > + clocks = <&ap_clk 0>, <&ap_clk 1>; > + #clock-cells = <1>; > + reg = <0x0 0x1000>; This takes the entire address range of the parent, then why the child node? You can't add any other child nodes without creating an overlap. Your example also won't compile. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel