From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9601FC43219 for ; Fri, 26 Apr 2019 18:46:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A3DC20B7C for ; Fri, 26 Apr 2019 18:46:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BJvVAs3F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A3DC20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fZ2h0MuNvr3O62F5ABAxfmAF7l4Z1I4m2i6A2soU+jw=; b=BJvVAs3FS51gOZ ToXB66Jsphci9knmYq97xVM704zC0zm9oD0xqZKbPfHGiFJcgu2vMUOY35uktK9qhh+c8N+LIeGXU ueyFbOI/s9oOFg3CJ071fvxLd6707r4FOFI0O7G+VIHMSRgTiSthsURTt9ibD26z9dM2Qh9lE6mPM Azs90SRqFjmxm3rYc7wJtQi67cfnQECK+e9z2qxySMjzqf+ruh7NAKi+39oZ1W5uzPDJz96LBXun5 Y/hU3ZPpXOBXNrSUPJ5NdyPcd76pOpnPbcWaXRbcShC1x7Ieir7NyWZmCmzyBnum8TpstqccFDYJJ m/X/Yy1bsdq7eYrie4hQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK5rJ-00076v-9L; Fri, 26 Apr 2019 18:46:05 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK5rG-00076W-8U; Fri, 26 Apr 2019 18:46:03 +0000 Received: by mail-ot1-f65.google.com with SMTP id r20so2377571otg.4; Fri, 26 Apr 2019 11:46:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pEPusRheoqG6L8hFDZ+UpNai2za15r7H5JF7WhwGE5Y=; b=gLemkuR2bD4pwAfHMqCyK5ZDI1Y3w66btbJytVXOHl7U9+iz/it34LXAa1hwPCKnxb laXbBBVsY+T8/03Zt5VZcrlHeva6sqS8Dtg0pHKaKujd8myaOLuUYnYBGp0JRnT7Q3az Uy2IldPpykoINtw/uqb583vkkN1XYEaZ4LwMFmAXrz5h/b+HhQ9X/anIpz29/x49hsZP qQ0tH72lydGa9noc+3HG+p3/yxdwDHl2Sv7Z+z/+PmEckMCF3+6KsgVrPs9Ir4OKyVv5 0VHS0yyjxwHAZhaFe0VF7LyEhHOP7m96zJeCCS5w0Chh5UnkBAPa9lipw5vQ7UszCSFL 973Q== X-Gm-Message-State: APjAAAX+/zUkjr/KGpKvB0+QSF8eznXSJhOuTfG8TDg1BLr4YpXMNoLb QpRhiulQA/ddvGF17KaNIuAvCtM= X-Google-Smtp-Source: APXvYqzzyZ6deOywfEMtSX0sji3SN3TApLJhNC2zk1n2ENmAnHUeVNtTigzhvxrFey+mOYmGQ+PuEw== X-Received: by 2002:a05:6830:2090:: with SMTP id y16mr13359330otq.97.1556304360935; Fri, 26 Apr 2019 11:46:00 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o66sm11050999oig.11.2019.04.26.11.45.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 11:45:59 -0700 (PDT) Date: Fri, 26 Apr 2019 13:45:59 -0500 From: Rob Herring To: =?iso-8859-1?Q?Ga=EBl?= PORTAY Subject: Re: [PATCH v4 5/5] arm64: dts: rockchip: Enable dmc and dfi nodes on gru. Message-ID: <20190426184559.GA29242@bogus> References: <20190415212948.7736-1-gael.portay@collabora.com> <20190415212948.7736-6-gael.portay@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190415212948.7736-6-gael.portay@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_114602_297714_D51A6039 X-CRM114-Status: GOOD ( 21.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Derek Basehore , Heiko Stuebner , linux-pm@vger.kernel.org, Brian Norris , Douglas Anderson , linux-kernel@vger.kernel.org, Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Klaus Goger , Enric Balletbo i Serra , linux-rockchip@lists.infradead.org, Randy Li , linux-arm-kernel@lists.infradead.org, Lin Huang Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:29:48PM -0400, Ga=EBl PORTAY wrote: > From: Lin Huang > = > Enable the DMC (Dynamic Memory Controller) and the DFI (DDR PHY > Interface) nodes on gru boards so we can support DDR DVFS. > = > The patch also introduces a new file with default DRAM settings. > = > Signed-off-by: Lin Huang > Signed-off-by: Enric Balletbo i Serra > Signed-off-by: Ga=EBl PORTAY > --- > = > Changes in v4: > - [PATCH v3 5/5] Add board related DDR settings (moved from 4/5). > = > Changes in v3: > - [PATCH v2 5/5] Remove display_subsystem nodes. > = > Changes in v2: > - [PATCH 8/8] Move center-supply attribute of dmc node in file > rk3399-gru-chromebook.dtsi (where ppvar_centerlogic is > defined). > = > Changes in v1: None > = > .../dts/rockchip/rk3399-gru-chromebook.dtsi | 4 + > arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 46 ++++++++++++ > .../boot/dts/rockchip/rk3399-op1-opp.dtsi | 29 ++++++++ > include/dt-bindings/power/rk3399-dram.h | 73 +++++++++++++++++++ > 4 files changed, 152 insertions(+) > create mode 100644 include/dt-bindings/power/rk3399-dram.h > = > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi b/ar= ch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi > index 931640e9aed4..cfb81356c61e 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi > @@ -400,3 +400,7 @@ ap_i2c_tp: &i2c5 { > rockchip,pins =3D <0 8 RK_FUNC_GPIO &pcfg_pull_none>; > }; > }; > + > +&dmc { > + center-supply =3D <&ppvar_centerlogic>; > +}; > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi b/arch/arm64/bo= ot/dts/rockchip/rk3399-gru.dtsi > index da03fa9c5662..40e78186560b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi > @@ -6,6 +6,7 @@ > */ > = > #include > +#include > #include "rk3399.dtsi" > #include "rk3399-op1-opp.dtsi" > = > @@ -289,6 +290,12 @@ > status =3D "okay"; > }; > = > +&dmc_opp_table { > + opp04 { > + opp-suspend; > + }; > +}; > + > /* > * Set some suspend operating points to avoid OVP in suspend > * > @@ -489,6 +496,45 @@ ap_i2c_audio: &i2c8 { > status =3D "okay"; > }; > = > +&dfi { > + status =3D "okay"; > +}; > + > +&dmc { > + status =3D "okay"; > + upthreshold =3D <25>; > + downdifferential =3D <15>; > + rockchip,ddr3_speed_bin =3D <21>; > + rockchip,pd_idle =3D <0x40>; > + rockchip,sr_idle =3D <0x2>; > + rockchip,sr_mc_gate_idle =3D <0x3>; > + rockchip,srpd_lite_idle =3D <0x4>; > + rockchip,standby_idle =3D <0x2000>; > + rockchip,dram_dll_dis_freq =3D <300000000>; > + rockchip,phy_dll_dis_freq =3D <125000000>; > + rockchip,auto_pd_dis_freq =3D <666000000>; > + rockchip,ddr3_odt_dis_freq =3D <333000000>; > + rockchip,ddr3_drv =3D ; > + rockchip,ddr3_odt =3D ; > + rockchip,phy_ddr3_ca_drv =3D ; > + rockchip,phy_ddr3_dq_drv =3D ; > + rockchip,phy_ddr3_odt =3D ; > + rockchip,lpddr3_odt_dis_freq =3D <333000000>; > + rockchip,lpddr3_drv =3D ; > + rockchip,lpddr3_odt =3D ; > + rockchip,phy_lpddr3_ca_drv =3D ; > + rockchip,phy_lpddr3_dq_drv =3D ; > + rockchip,phy_lpddr3_odt =3D ; > + rockchip,lpddr4_odt_dis_freq =3D <333000000>; > + rockchip,lpddr4_drv =3D ; > + rockchip,lpddr4_dq_odt =3D ; > + rockchip,lpddr4_ca_odt =3D ; > + rockchip,phy_lpddr4_ca_drv =3D ; > + rockchip,phy_lpddr4_ck_cs_drv =3D ; > + rockchip,phy_lpddr4_dq_drv =3D ; > + rockchip,phy_lpddr4_odt =3D ; > +}; > + > &sdhci { > /* > * Signal integrity isn't great at 200 MHz and 150 MHz (DDR) gives the > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi b/arch/arm6= 4/boot/dts/rockchip/rk3399-op1-opp.dtsi > index 69cc9b05baa5..c9e7032b01a8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-op1-opp.dtsi > @@ -110,6 +110,31 @@ > opp-microvolt =3D <1075000>; > }; > }; > + > + dmc_opp_table: dmc_opp_table { > + compatible =3D "operating-points-v2"; > + > + opp00 { > + opp-hz =3D /bits/ 64 <200000000>; > + opp-microvolt =3D <900000>; > + }; > + opp01 { > + opp-hz =3D /bits/ 64 <400000000>; > + opp-microvolt =3D <900000>; > + }; > + opp02 { > + opp-hz =3D /bits/ 64 <666000000>; > + opp-microvolt =3D <900000>; > + }; > + opp03 { > + opp-hz =3D /bits/ 64 <800000000>; > + opp-microvolt =3D <900000>; > + }; > + opp04 { > + opp-hz =3D /bits/ 64 <928000000>; > + opp-microvolt =3D <900000>; > + }; > + }; > }; > = > &cpu_l0 { > @@ -139,3 +164,7 @@ > &gpu { > operating-points-v2 =3D <&gpu_opp_table>; > }; > + > +&dmc { > + operating-points-v2 =3D <&dmc_opp_table>; > +}; > diff --git a/include/dt-bindings/power/rk3399-dram.h b/include/dt-binding= s/power/rk3399-dram.h > new file mode 100644 > index 000000000000..4b3d4a79923b > --- /dev/null > +++ b/include/dt-bindings/power/rk3399-dram.h > @@ -0,0 +1,73 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ OR X11) */ > +/* > + * Copyright (c) 2016-2018, Fuzhou Rockchip Electronics Co., Ltd > + * > + * Author: Lin Huang > + */ > + > +#ifndef _DTS_DRAM_ROCKCHIP_RK3399_H > +#define _DTS_DRAM_ROCKCHIP_RK3399_H > + > +#define DDR3_DS_34ohm 34 > +#define DDR3_DS_40ohm 40 > + > +#define DDR3_ODT_DIS 0 > +#define DDR3_ODT_40ohm 40 > +#define DDR3_ODT_60ohm 60 > +#define DDR3_ODT_120ohm 120 I don't think these defines add much value given the value is in the = define itself. Do these get used by the driver? If not, then the header can go with the = dts file. But I'd just get rid of the header. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel