From: Rob Herring <robh@kernel.org>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Mason Yang <masonccyang@mxic.com.tw>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Richard Weinberger <richard@nod.at>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
nsekhar@ti.com, linux-kernel@vger.kernel.org,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Subject: Re: [PATCH v4 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller
Date: Fri, 26 Apr 2019 15:20:25 -0500 [thread overview]
Message-ID: <20190426202025.GA24486@bogus> (raw)
In-Reply-To: <20190423104814.5762-5-vigneshr@ti.com>
On Tue, Apr 23, 2019 at 04:18:13PM +0530, Vignesh Raghavendra wrote:
> Add binding documentation for TI's HyperBus memory controller present on
> AM654 SoC.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> .../devicetree/bindings/mtd/ti,am654-hbmc.txt | 32 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
> new file mode 100644
> index 000000000000..fc87c7918389
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
> @@ -0,0 +1,32 @@
> +Bindings for HyperBus Memory Controller (HBMC) on TI's K3 family of SoCs
> +
> +Required properties:
> +- compatible : "ti,am654-hbmc" for AM654 SoC
> +- reg : Two entries:
> + First entry pointed to the register space of HBMC controller
> + Second entry pointing to the memory map region dedicated for
> + MMIO access to attached flash devices
> +- ranges : Address range allocated for each chipselect in the MMIO space
> +
> +Optional properties:
> +- mux-controls : phandle to the multiplexer that controls selection of
> + HBMC vs OSPI. Mux state of 1 indicates HBMC is selected.
So 1 is also the default because your example doesn't have the property?
> +
> +Example:
> +
> + hbmc: hbmc@47034000 {
> + compatible = "ti,am654-hbmc";
> + reg = <0x0 0x47034000 0x0 0x100>,
> + <0x5 0x00000000 0x1 0x0000000>;
> + power-domains = <&k3_pds 55>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x5 0x00000000 0x4000000>, /* CS0 - 64MB */
> + <0x1 0x5 0x04000000 0x4000000>; /* CS1 - 64MB
This is wrong. You need 2 cells for the child address. The first cell is
the CS and the 2nd cell is the offset (typically 0). Otherwise you have
overlapping addresses with child addresses 0 and 1.
> +
> + /* Slave flash node */
> + flash@0 {
And then the unit-address here would be '0,0'.
> + compatible = "cypress,hyperflash";
Doesn't match what you defined for this binding.
> + reg = <0x0 0x4000000>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a5f22f85c848..1ade81f9a32a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7258,6 +7258,7 @@ S: Supported
> F: drivers/mtd/hyperbus/
> F: include/linux/mtd/hyperbus.h
> F: Documentation/devicetree/bindings/mtd/cypress,hyperflash.txt
> +F: Documentation/devicetree/bindings/mtd/ti,am654-hbmc.txt
>
> HYPERVISOR VIRTUAL CONSOLE DRIVER
> L: linuxppc-dev@lists.ozlabs.org
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-26 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 10:48 [PATCH v4 0/5] MTD: Add Initial Hyperbus support Vignesh Raghavendra
2019-04-23 10:48 ` [PATCH v4 1/5] mtd: cfi_cmdset_0002: Add support for polling status register Vignesh Raghavendra
2019-04-27 19:02 ` Sergei Shtylyov
2019-04-23 10:48 ` [PATCH v4 2/5] dt-bindings: mtd: Add binding documentation for HyperFlash Vignesh Raghavendra
2019-04-26 20:10 ` Rob Herring
2019-04-23 10:48 ` [PATCH v4 3/5] mtd: Add support for HyperBus memory devices Vignesh Raghavendra
2019-04-23 10:48 ` [PATCH v4 4/5] dt-bindings: mtd: Add bindings for TI's AM654 HyperBus memory controller Vignesh Raghavendra
2019-04-26 20:20 ` Rob Herring [this message]
2019-04-27 3:01 ` Vignesh Raghavendra
2019-04-23 10:48 ` [PATCH v4 5/5] mtd: hyperbus: Add driver for TI's " Vignesh Raghavendra
2019-04-27 20:31 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190426202025.GA24486@bogus \
--to=robh@kernel.org \
--cc=Joakim.Tjernlund@infinera.com \
--cc=Tudor.Ambarus@microchip.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=nsekhar@ti.com \
--cc=richard@nod.at \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).