From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBB9C43218 for ; Fri, 26 Apr 2019 20:21:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8424E2054F for ; Fri, 26 Apr 2019 20:21:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G0mQjUFp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ii2p9txP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8424E2054F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d7ELY9jVdsXbUmTpE+y2AbPAc89vcu4Bt53FN9U5u2w=; b=G0mQjUFpfx9Oa/ SQ8ZCNDqchlx1hXB+QRxvZbj8AjSlYuwMPvff1lVJL4Y9iGxhTla08GNQvQmyW1YTj9s+84MUoRun ubOcYODJqPOJIXsKYqGkniAvFcUDfs+O0ACjwZ6kWZ3hi9gB1CiUqbKHX6OG3iMKjpmHqC7D6QgeO GWzXVIE4aRSBLrYmAKTU0wLkShQcWSNTpO0VaC7yjte/S7fc9X44gQj7NvKw5yjGLFkWFGunvmtHB qp2KRfKwusNe++HZq1l4nb1Am1j9gPrYnksRUq+kp4dth+B9QIdv/B8bQ/EEiQ4Vlosj3AMGriqUi COOYWEILz9YQwSR1kwIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7LX-0006GE-SJ; Fri, 26 Apr 2019 20:21:23 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7LS-0006Fo-Nl for linux-arm-kernel@lists.infradead.org; Fri, 26 Apr 2019 20:21:21 +0000 Received: by mail-pg1-x541.google.com with SMTP id c13so1143806pgt.1 for ; Fri, 26 Apr 2019 13:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xOvO4DcMT8uPegtVLmOyrU3VxEBRiA2n9CIhn6aAJ68=; b=ii2p9txP3BYuOY93nFf/w0HYe9ra/B7vAHZ+9juH+lGZ55/EQwGyUCd59Os9PKdumV G72WdZNpUTNojDLkcnd5MX2svV0PL0ZQXHvst6MlcGqqh4P1sbUy+WY3tUp/1aj4E8+B LJCQmWof2vuAtlNEgPqAWUKo95+cZA7VE+G3dHu4RK/R3XfQU68lrU5RivFbLdeYpkZl IhLAHKrOCRnJZsDdaFu2hiwqrGYzkGd/T4ZdRHKO2zzIWNsmudUKtqaH+Po5paMF2Jvt 4b4+o1xVKdrmajpzJFylyufsUh9kViP+kE33XfjkkDevnHFKFtrcXxXRP1ow618Wh79e O9GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xOvO4DcMT8uPegtVLmOyrU3VxEBRiA2n9CIhn6aAJ68=; b=HZuuqi9/50v9jqzWEoCgsxl3WLVXi2caXptp6zS6VJDYx64d92Gbrum36lJnMepy0m Y1yb59fHRmrH1g1Qy+kdi/Cwxkkk00EIJ43T/neo9ylaajxCwGH6689RVqfUOTd764fR fP8ikh3uVlFtoRMS47J+AZvgR5+nMXM3T+JvFj/o8hD2UjdhbN3lGzrWW77yXw+tdhsM xcAMcT0az0CbMBuH7RmcN9FT4F2gO/wfJ1I56hpd3tFo4exuZQRb1r4P23eW84mSZEya DdevE95rls8Vet0NjmjLPL0MvtHpAwWB+EXCCIaAuxl2SNHiYH5FbaaLKOZztdiDHtSa m/fg== X-Gm-Message-State: APjAAAXFBWK3F9vslF+0ap7Huv3RP2T8uBRalglfOXDrksuHOupLAjtn bFqAKi7jQo+n4QNXlgx6UvobhYVtO10= X-Google-Smtp-Source: APXvYqxww6o5Q4xL9x+BE+D1ofzetryWJAOJJcASB73A0QVw1aCU+osPcAXysawPPrwtEWFeFvaTKA== X-Received: by 2002:aa7:8008:: with SMTP id j8mr20736592pfi.120.1556310077730; Fri, 26 Apr 2019 13:21:17 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id 4sm35290987pfn.159.2019.04.26.13.21.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 13:21:17 -0700 (PDT) Date: Fri, 26 Apr 2019 13:21:12 -0700 From: Nicolin Chen To: Christoph Hellwig Subject: Re: [PATCH v2 RFC/RFT 1/5] ARM: dma-mapping: Add fallback normal page allocations Message-ID: <20190426202110.GA11129@Asurada-Nvidia.nvidia.com> References: <20190326230131.16275-1-nicoleotsuka@gmail.com> <20190326230131.16275-2-nicoleotsuka@gmail.com> <20190424150638.GA22191@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190424150638.GA22191@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_132118_799683_EC872A30 X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tony@atomide.com, catalin.marinas@arm.com, joro@8bytes.org, will.deacon@arm.com, linux@armlinux.org.uk, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 24, 2019 at 05:06:38PM +0200, Christoph Hellwig wrote: > > + if (!dma_release_from_contiguous(dev, page, count)) > > + __free_pages(page, get_order(size)); > > Same for dma_release_from_contiguous - drop the _from, pass the > actual size, and handle the free_pages fallback. What do you think of dma_free_contiguous() instead? I feel "free" is a bit more commonly used (in dma-mapping.h) and it's shorter. Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel