Re: [PATCH v4 2/6] dt-bindings: usb: add binding for Type-B GPIO connector driver

From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Biju Das <biju.das@bp.renesas.com>,
	Badhri Jagan Sridharan <badhri@google.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Min Guo <min.guo@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	linux-arm-kernel@lists.infradead.org, Li Jun <jun.li@nxp.com>
Subject: Re: [PATCH v4 2/6] dt-bindings: usb: add binding for Type-B GPIO connector driver
Date: Fri, 26 Apr 2019 15:45:37 -0500	[thread overview]
Message-ID: <20190426204537.GA15074@bogus> (raw)
In-Reply-To: <1556261237-13823-3-git-send-email-chunfeng.yun@mediatek.com>

On Fri, Apr 26, 2019 at 02:47:13PM +0800, Chunfeng Yun wrote:
> It's used to support dual role switch via GPIO when use Type-B
> receptacle, typically the USB ID pin is connected to an input
> GPIO pin
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v4 no changes
> 
> v3 changes:
>  1. treat type-B connector as a virtual device, but not child device of
>     USB controller's
> 
> v2 changes:
>   1. new patch to make binding clear suggested by Hans
> ---
>  .../bindings/usb/typeb-conn-gpio.txt          | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt
> new file mode 100644
> index 000000000000..d2e1c4e01b6d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/typeb-conn-gpio.txt
> @@ -0,0 +1,49 @@
> +USB Type-B GPIO Connector
> +
> +This is a virtual device used to switch dual role mode from the USB ID pin
> +connected to an input GPIO pin.
> +
> +Required properties:
> +- compatible : Should be "linux,typeb-conn-gpio"

There's no need for this virtual node. The USB host or device driver can 
instantiate a connector driver by walking the OF graph to the connector 
and creating a device.

> +
> +Sub-nodes:
> +- connector : should be present.
> +	- compatible : should be "usb-b-connector".
> +	- id-gpios, vbus-gpios : either one of them must be present,
> +		and both can be present as well.
> +	- vbus-supply : can be present if needed when supports dual role mode.
> +	see connector/usb-connector.txt
> +
> +- port : should be present.
> +	see graph.txt
> +
> +Example:
> +
> +rsw_iddig: role_sw_iddig {
> +	compatible = "linux,typeb-conn-gpio";
> +	status = "okay";
> +
> +	connector {
> +		compatible = "usb-b-connector";
> +		label = "micro-USB";
> +		type = "micro";
> +		id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>;
> +		vbus-supply = <&usb_p0_vbus>;
> +	};
> +
> +	port {

Humm, same mistake as Hikey patches...

This goes under the connector node as defined in the connector binding.

> +		bconn_ep: endpoint@0 {
> +			remote-endpoint = <&usb_role_sw>;
> +		};
> +	};
> +};
> +
> +&mtu3 {
> +	status = "okay";
> +
> +	port {
> +		usb_role_sw: endpoint@0 {
> +			remote-endpoint = <&bconn_ep>;
> +		};
> +	};
> +};
> -- 
> 2.21.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel