From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84158C43219 for ; Fri, 26 Apr 2019 20:49:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5503D20869 for ; Fri, 26 Apr 2019 20:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBZ98Hx1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5503D20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LOh65C+xskemMZUCYPteWqp/nstagDvabBgxELVWR7U=; b=PBZ98Hx1tU4Vn/ VOsqFuLgAecbP2RZ0jmh7LO5KL/sMnuGIR58gPw3uAbAxRVmUevj3Y+nM/gXLIbddE1uosuuMYHCU oMZERY2v6F6XKJ/itxI3xrbNzmqwFvYjuSWNDfXYgvBTTPwnf8MzaEQImh26DcKJ+CAKD8iwLfVBZ EJ7sYTOgB5cG6RnRerqEUWsYFY+I6zEUuEFeURNVruK7EG83l3icskNLUqzaQkzPGLEPNg+ftE7Rg SjGBrATwIYn795DvNEtapoJ8PUSXFBimUXhb+jHQ2PlyXjdhAypY3VXkVcVhVZB7fPAFlyW9to6nt Qbx+2Q1JfHmKbNUPllLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7mR-0005d3-TR; Fri, 26 Apr 2019 20:49:11 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hK7mO-0005cb-Rm; Fri, 26 Apr 2019 20:49:10 +0000 Received: by mail-ot1-f67.google.com with SMTP id m10so3822511otp.2; Fri, 26 Apr 2019 13:49:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yT/XON//WSgEMOVSZqw0Vzpd9+7PVH4HBAL475bgyVk=; b=JeQ0K5rrp87gin4e5ZsSW/eC5n9/UaDTMXqNC+BlEg87Gfno8JKeH1F+8ApH9eTc8g dUqVR+fhqhjQ/eo2xo3aeMM/PDthSmrOAq4suQlho2Mric/DvanvUSZD5f14uNHRI30c BzAc3A3K10NZOkT/q0tv80SSa9PvbFbElazRQcVa7M+dWV25TLfmZzX2nl2wTEaYqpr0 PbgrAubjwG+cesohbxT/yb1CqFWVgvZD/VJhLoozysxBbp/k6xO7fIWhG9+qZ0ZfFDnj ASQ35NBL73qtmjwPgemqxnnB8FjbyQekcBkvsbpVd+B/weYvQLtngOgyJqromwdv6R19 XIAA== X-Gm-Message-State: APjAAAW641SOoEIsZwENSBVawBpQtHSpJBv7wIDuFjYZWeUQB2u1X4iJ osRK5DItRk8TDKADWO9Ujw== X-Google-Smtp-Source: APXvYqzdJ/lqbNb65m2fPe6L55tRE2fIx1i7+lvYj2VUlr2QLQ5aXA5+va67yIwicppYidXubf3CLw== X-Received: by 2002:a9d:1b70:: with SMTP id l103mr4240966otl.165.1556311747844; Fri, 26 Apr 2019 13:49:07 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id l23sm2648517otr.81.2019.04.26.13.49.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Apr 2019 13:49:07 -0700 (PDT) Date: Fri, 26 Apr 2019 15:49:06 -0500 From: Rob Herring To: Chunfeng Yun Subject: Re: [PATCH v4 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Message-ID: <20190426204906.GB15074@bogus> References: <1556261237-13823-1-git-send-email-chunfeng.yun@mediatek.com> <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1556261237-13823-4-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_134908_895634_94CCFAB1 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heikki Krogerus , Hans de Goede , Greg Kroah-Hartman , Linus Walleij , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Badhri Jagan Sridharan , Andy Shevchenko , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 26, 2019 at 02:47:14PM +0800, Chunfeng Yun wrote: > Now the USB Role Switch is supported, so add properties about it > > Signed-off-by: Chunfeng Yun > --- > v4: no changes > v3: no changes > > v2 changes: > 1. fix typo > 2. refer new binding about connector property > --- > .../devicetree/bindings/usb/mediatek,mtu3.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > index 3382b5cb471d..6e004c4a89af 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt > @@ -27,7 +27,9 @@ Optional properties: > - ranges : allows valid 1:1 translation between child's address space and > parent's address space > - extcon : external connector for vbus and idpin changes detection, needed > - when supports dual-role mode. > + when supports dual-role mode; it's consiedered valid for compatibility > + reasons, and not allowed for new bindings, use the property > + usb-role-switch instead. > - vbus-supply : reference to the VBUS regulator, needed when supports > dual-role mode. > - pinctrl-names : a pinctrl state named "default" is optional, and need be > @@ -36,7 +38,8 @@ Optional properties: > is not set. > - pinctrl-0 : pin control group > See: Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > - > + - usb-role-switch : use USB Role Switch to support dual-role switch, but > + not extcon Coordinate with the Renesas and HiSilicon folks implementing the same thing and put this in a common spot. However, I think this should not even be needed as knowing the controller capabilities (based on the compatible) and knowing the type of connector should be enough information to tell you if dual role is supported or not. > - maximum-speed : valid arguments are "super-speed", "high-speed" and > "full-speed"; refer to usb/generic.txt > - enable-manual-drd : supports manual dual-role switch via debugfs; usually > @@ -61,6 +64,9 @@ The xhci should be added as subnode to mtu3 as shown in the following example > if host mode is enabled. The DT binding details of xhci can be found in: > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt > > +The port would be added as subnode if use usb-role-switch property > + see graph.txt > + > Example: > ssusb: usb@11271000 { > compatible = "mediatek,mt8173-mtu3"; > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel