From: Nishanth Menon <nm@ti.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Santosh Shilimkar <ssantosh@kernel.org>
Subject: Re: [PATCH] firmware: ti_sci: Always request response from firmware
Date: Mon, 29 Apr 2019 09:40:49 -0500 [thread overview]
Message-ID: <20190429144049.5dmudk63b3xftmr2@kahuna> (raw)
In-Reply-To: <20190429131533.25122-1-afd@ti.com>
On 09:15-20190429, Andrew F. Davis wrote:
> TI-SCI firmware will only respond to messages when the
> TI_SCI_FLAG_REQ_ACK_ON_PROCESSED flag is set. Most messages already do
> this, set this for the ones that do not.
>
> This will be enforced in future firmware that better match the TI-SCI
> specifications, this patch will not break users of existing firmware.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Acked-by: Nishanth Menon <nm@ti.com>
yep, the patch allows backward and forward compatibility with TISCI
compliant firmware.
Thanks for doing the patch.
> Tested-by: Alejandro Hernandez <ajhernandez@ti.com>
> ---
> drivers/firmware/ti_sci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 3fbbb61012c4..3f202c63b9a6 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -448,9 +448,9 @@ static int ti_sci_cmd_get_revision(struct ti_sci_info *info)
> struct ti_sci_xfer *xfer;
> int ret;
>
> - /* No need to setup flags since it is expected to respond */
> xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_VERSION,
> - 0x0, sizeof(struct ti_sci_msg_hdr),
> + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> + sizeof(struct ti_sci_msg_hdr),
> sizeof(*rev_info));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> @@ -578,9 +578,9 @@ static int ti_sci_get_device_state(const struct ti_sci_handle *handle,
> info = handle_to_ti_sci_info(handle);
> dev = info->dev;
>
> - /* Response is expected, so need of any flags */
> xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_GET_DEVICE_STATE,
> - 0, sizeof(*req), sizeof(*resp));
> + TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
> + sizeof(*req), sizeof(*resp));
> if (IS_ERR(xfer)) {
> ret = PTR_ERR(xfer);
> dev_err(dev, "Message alloc failed(%d)\n", ret);
> --
> 2.21.0
>
--
Regards,
Nishanth Menon
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
parent reply other threads:[~2019-04-29 14:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190429131533.25122-1-afd@ti.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429144049.5dmudk63b3xftmr2@kahuna \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox