From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1928DC43219 for ; Mon, 29 Apr 2019 17:44:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1A7C20652 for ; Mon, 29 Apr 2019 17:44:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oZBPsPNF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cKzT/jEC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1A7C20652 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7T08D9X4GXvuZ8xO2Tkduh0amEa2X9ceR3nds7HRezY=; b=oZBPsPNFDPx7nz zjt2W6vgLvY/CzZKCcMcQ7jJE27ZDWpUoS6xiPxCkLYbPHegQAyFaQhWiUBQbAiJonJs7kgGX/YHE bsQhzCoIaUYs6CiyBu7Ec0+sZtVznn3bSAkAslu+aoYG9RUju6LxuXKwAyVQ2gsgowsvoFxaf6j2f MlAwsyDHGurgwJyiqoDDSsc3YOAsNtViSWezAcC3yjl512oV/8Ib/Uzr3sMMiuGNxYEsNfWfeHgEf J07atUCaVRJxwmgzPxPuCiCXpPrWdyVfmDpahfcOt8i+x5WFfRnAzeKGePXPywkmIK2XtzUiwvhJM xN7/6z5LqY0l2rktDNOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLAKV-0000ZK-7k; Mon, 29 Apr 2019 17:44:39 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLAKS-0000Yq-HC for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2019 17:44:37 +0000 Received: by mail-pl1-x643.google.com with SMTP id bi2so621661plb.13 for ; Mon, 29 Apr 2019 10:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k1NomnPWMIfso5x9ImCRSbz25mvLyl8gFIQ8b/bFOKU=; b=cKzT/jECdjkEqqAqdqgiVNtmJx5QGXkHirh7YnqVt5rNVYMskoK+zKZQyuFzkPJxno 5AYGHxgllC2CbVNUdL+mNkm4B4eBeokIMKQHdluM17yqfP+8cg/DoL/6CfkLuBazikHf 4YpzBUCzq6MTjps7nW/JKehIzwO2k+csB39pgksxnQkbqkPPOLgIPu0h5TigJ8U657Y2 3ID46ruVukzp+FvgQZ9TeRXWJSKrVSB7dCob3me3OnLA7uFa2WI8OlQGPcxWrVOH8FZ2 xObdVCMqL9iuJ5+AQW0GvOVU91VwSOKLJ+Fa/ZAVjsma9rHjF1K24K3cb+9UHzAsj5kD MsxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k1NomnPWMIfso5x9ImCRSbz25mvLyl8gFIQ8b/bFOKU=; b=I6IS7LAlXHSmuyVegFIK8E2V5P03uxEgmOkEpKa0F6dWeRHu9j7DazQ6X3fV8LmIpw aYse8sJctO+Du7ZwNrT8tvGiuFbECGzpLcS3g3S7+DRuKKOYfprq9am1hoX3PbiaoCRv PbjOgyaZCbD5px3mG0CMEVSJR2JMWtP4a8ECzID+8aaxk8k6kt/atQc+S37EZxTzT2dw 05Izcvw7jpdfEScuMCd/R5PvH4g5bHRBtBNmLWcIV/bggd56BMzGbZoDTeuxKRR0RNDV GK73m1mnoV7SGh0vLQc6JIyZSDp8mwjU8UwHVBjq3urLJ1124ZCn8iWr8czPle8jtkp9 3fJw== X-Gm-Message-State: APjAAAXuaoAnMAy7y5E4rFUnyypx9LENk1XJoJEaTtKyJFB4jg51mrZP xGuvvE+9jd28do8FMbFvzaLsGQ== X-Google-Smtp-Source: APXvYqxfDdgpKbi7c5IJfSUSR96PBo3aTr9H2pdfHg77PXLqLz0S0cq3UFVcfj/69GieeS/am76LyA== X-Received: by 2002:a17:902:bd0c:: with SMTP id p12mr12365704pls.50.1556559875914; Mon, 29 Apr 2019 10:44:35 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id c22sm46860290pfn.136.2019.04.29.10.44.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Apr 2019 10:44:35 -0700 (PDT) Date: Mon, 29 Apr 2019 11:44:32 -0600 From: Mathieu Poirier To: Suzuki K Poulose Subject: Re: [PATCH v2 35/36] [RFC] coresight: add return value for fixup connections Message-ID: <20190429174432.GB18807@xps15> References: <1555344260-12375-1-git-send-email-suzuki.poulose@arm.com> <1555344260-12375-36-git-send-email-suzuki.poulose@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1555344260-12375-36-git-send-email-suzuki.poulose@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190429_104436_566111_EF77E3BF X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, robert.walker@arm.com, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 15, 2019 at 05:04:18PM +0100, Suzuki K Poulose wrote: > Handle failures in fixing up connections for a newly registered > device. This will be useful to handle cases where we fail to expose > the links via sysfs for the connections. > > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c > index 010bc86..4d63063 100644 > --- a/drivers/hwtracing/coresight/coresight.c > +++ b/drivers/hwtracing/coresight/coresight.c > @@ -1025,18 +1025,18 @@ static int coresight_orphan_match(struct device *dev, void *data) > return 0; > } > > -static void coresight_fixup_orphan_conns(struct coresight_device *csdev) > +static int coresight_fixup_orphan_conns(struct coresight_device *csdev) > { > /* > * No need to check for a return value as orphan connection(s) > * are hooked-up with each newly added component. > */ > - bus_for_each_dev(&coresight_bustype, NULL, > + return bus_for_each_dev(&coresight_bustype, NULL, > csdev, coresight_orphan_match); After this patch the comment is no longer true - please consider amending. With the above: Reviewed-by: Mathieu Poirier > } > > > -static void coresight_fixup_device_conns(struct coresight_device *csdev) > +static int coresight_fixup_device_conns(struct coresight_device *csdev) > { > int i; > > @@ -1056,6 +1056,8 @@ static void coresight_fixup_device_conns(struct coresight_device *csdev) > conn->child_dev = NULL; > } > } > + > + return 0; > } > > static int coresight_remove_match(struct device *dev, void *data) > @@ -1265,10 +1267,15 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > > mutex_lock(&coresight_mutex); > > - coresight_fixup_device_conns(csdev); > - coresight_fixup_orphan_conns(csdev); > + ret = coresight_fixup_device_conns(csdev); > + if (!ret) > + ret = coresight_fixup_orphan_conns(csdev); > > mutex_unlock(&coresight_mutex); > + if (ret) { > + coresight_unregister(csdev); > + return ERR_PTR(ret); > + } > > return csdev; > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel