From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 290DDC43219 for ; Tue, 30 Apr 2019 13:33:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE0C121707 for ; Tue, 30 Apr 2019 13:33:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yl7l4B/q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0C121707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uh4ak3WMezDCIqPlAcVK6rxmByPKgnH5o9uCfWBZeJQ=; b=Yl7l4B/qEBkgTt o5ZlP3+XsEiLixShNU+TTOSxJOF/ARTuZexKzIRE8dXHGCNbc1lVsCDkQQmtzQM8Gu5ZuDi67GiHx Fva9pBm9ngmXpHAej7jsjTQWNkii8ySFSb5jLuoN9NoklItvLDwIhdVG8tTY3PkPmLnU2FgfNlJSA SgwXEAxZTtKg8ALRiw5ZNkuKmNx+S624eA+eTfbbVBcZ8Xji0fFWbf5ip324s5BBbzTBwL85J/qNj pSfQMOKu41VYwYIzVluUCn26hydwEk032oJxvdlZysTraT2vHWmy2Ofnt8kxHaJx6FJCJZLfFQI8z 6aP+PivVGEPcokpnS2Nw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLSsR-0008T3-Hn; Tue, 30 Apr 2019 13:32:55 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLSsO-0008SV-AE for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2019 13:32:54 +0000 Received: by newverein.lst.de (Postfix, from userid 2005) id B0B1367358; Tue, 30 Apr 2019 15:32:32 +0200 (CEST) Date: Tue, 30 Apr 2019 15:32:32 +0200 From: Torsten Duwe To: Maxime Ripard Subject: Re: [PATCH RFC] arm64: dts: allwinner: a64: teres-i: Enable audio Message-ID: <20190430133232.GA18808@lst.de> References: <20190212100929.iqsxu443qrkl6myf@flea> <20190213094442.da2dy6d5bb527nft@flea> <20190213155311.ovkpim3lxwyvuhhj@flea> <20190215142029.GB32618@lst.de> <20190218102442.l3br2h3oqfe2atdv@flea> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190218102442.l3br2h3oqfe2atdv@flea> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190430_063252_516482_D5FD62C2 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, info@olimex.com, Mark Brown , Chen-Yu Tsai , Rob Herring , Harald Geyer , ibu@radempa.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 18, 2019 at 11:24:42AM +0100, Maxime Ripard wrote: > On Sat, Feb 16, 2019 at 09:47:13PM +0100, Harald Geyer wrote: > > > > > Would you care to submit a patch version without that GPIO handled? > > > I think it's very useful and has the potential to be agreed upon. > > > > That would enable audio from the internal speakers but select debug > > output on the HP jack by default. I would be okay with that, despite > > still thinking that audio on the head phones should be the default. > > > > Maxime and Wens are the maintainers, so it's their call in the end. > > At this point, I'm not really convinced by the solution in that patch, > but I don't have really good ideas either. I think it would be good to > discuss this with Mark and Linus Walleij, they will probably have way > better solutions than what I can come up with. Once more my plead to *please* apply the unchallenged parts of this patch! For reference: https://patchwork.kernel.org/patch/10792589/ Just leave out the line + hpvcc-supply = <®_eldo1>; /* TODO: Use only one of these */ (as clarified by ChenYu) and the @@ -131,6 +151,14 @@ status = "okay"; }; +&r_pio { + r_debug_select_pin: debug-select { [...] hunk, which the discussion was about. The patch is of good value even without it. IMHO it's a shame this didn't make it into 5.1 Acked-by: Torsten Duwe Torsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel