From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE096C43219 for ; Tue, 30 Apr 2019 15:21:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F9F520835 for ; Tue, 30 Apr 2019 15:21:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fGx4bYdg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F9F520835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4GYXtnNkHKuuI0pchzwxMoIvRZl/N5w+aik59y6aC4=; b=fGx4bYdg36H+SE aPtU5MmMNOhiFPbf+sFq7P88jfXJnl7t9xvO9j4m3J26hWcXdX32PSgWb3l4SuTQ2wJZ8QCmVQBS1 ijQyi7bRKKDKkyfJxj9yrw00ZPsYZJIyPSeLzpHOs+bhP97p5C94iOVsYPYWEkQd5EkK2/K2W7qxY YPhkvTRScThn+IUZGTpCoQPxybJutaYYDyipkmn5zvKuAylShdhFx0E6DTzxL3TImmwOA+U8lj4qW H30j8Rvl+HgkPBgKOnU7WqFcoHpyWdk8p2x3xH+M4j+LJg1tUgfIH9Zb6GGa1k6jKXKN5oM8+Df8W 5TxEnxNvFkd2qKdkttmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLUZL-0002kN-OT; Tue, 30 Apr 2019 15:21:19 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLUZJ-0002jz-J7 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2019 15:21:18 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id 18DE167358; Tue, 30 Apr 2019 17:20:59 +0200 (CEST) Date: Tue, 30 Apr 2019 17:20:58 +0200 From: Christoph Hellwig To: Robin Murphy Subject: Re: [RFC/RFT PATCH 1/2] dma-contiguous: Simplify dma_*_from_contiguous() function calls Message-ID: <20190430152058.GC25447@lst.de> References: <20190430015521.27734-1-nicoleotsuka@gmail.com> <20190430015521.27734-2-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190430_082117_782916_7F241C21 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tony@atomide.com, catalin.marinas@arm.com, will.deacon@arm.com, jcmvbkbc@gmail.com, hch@lst.de, m.szyprowski@samsung.com, sfr@canb.auug.org.au, joro@8bytes.org, linux@armlinux.org.uk, treding@nvidia.com, linux-xtensa@linux-xtensa.org, keescook@chromium.org, Nicolin Chen , akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, chris@zankel.net, wsa+renesas@sang-engineering.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, iamjoonsoo.kim@lge.com, dwmw2@infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2019 at 01:52:26PM +0100, Robin Murphy wrote: > As Catalin pointed out before, many of the users above may still have > implicit assumptions about the default CMA area, i.e. that this won't > return something above the limit they originally passed to > dma_contiguous_reserve(). I'm not sure how straightforward that is to > resolve - at the very least we may have to monkey around with GFP_DMA{32} > flags based on where dma_contiguous_default_area lies :( Or just convert the callers one by one. The two most interesting ones are dma-direct which always check addressability after the allocation, and dma-iommu, which doesn't care. dma-iommu.c and intel-iommu.c also don't care, but should use dma-iommu by next merge window anyway, which leaves arm which is so complicated that we better don't touch it for now, and xtensa, which I hope to switch to dma-direct in the next merge window or two. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel