From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6625CC04AA6 for ; Tue, 30 Apr 2019 17:00:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A43121670 for ; Tue, 30 Apr 2019 17:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V5OYIte1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zrsmprsf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A43121670 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3CN+2C/Wr4KT7n6JpXIwe2Jm9pZemrue/nctdiqrJuU=; b=V5OYIte1f4/ot3 hM+61EePMR414028C0fxd4ds3DNLt65zD8MOaegDZlOGCkbpCdWPT2Osss/bSrCJpIB54r75RW7ND kdpHT0intRh4VU6bkdWrl+v+oLq4nW80jPgqRUmw5LaGme/zlM831cOkcxqNVlfHVs3pO0uLnLZNE Xme+DVV/6AQ80uAYDX9fwTxA9P9OmSJPwT6YawuwzBriRLvo3tL8bFFmIOe5A0JoG9Ou1SNN9upJ5 egB2Ou5nDiG0qkRUpKWfJESXpDaB+M799lDBZxytZ+QU9R1p2RZS0iyhFNL3rD8U/LVlTZKExzmGA nuNde1J8d5g+2JbxNsxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLW6m-00018O-FD; Tue, 30 Apr 2019 16:59:56 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLW6j-00017p-FO for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2019 16:59:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DpyzH6C7CDzVv5rpAbyNDaHnn+kRSb3nqDne+G2smGk=; b=zrsmprsfOsmr3PVItgVW65jyC+ w94doDuf92Q955drappbRDqSk2RC3NVZHRX9L+6cSVatkujdMCpfQQGhEDZ0UvFeVH+l6moueXPEo wLZLCJrXhuP7Prm1kzSDUF9Q2JnRo71EXhS2iWB5L3FN4k64wUTdWgKP6XQl0vcxxxNg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hLW6O-0001v8-07; Tue, 30 Apr 2019 18:59:32 +0200 Date: Tue, 30 Apr 2019 18:59:31 +0200 From: Andrew Lunn To: Esben Haabendal Subject: Re: [PATCH v3 07/12] net: ll_temac: Support indirect_mutex share within TEMAC IP Message-ID: <20190430165931.GC30817@lunn.ch> References: <20190429083422.4356-1-esben@geanix.com> <20190430071759.2481-1-esben@geanix.com> <20190430071759.2481-8-esben@geanix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190430071759.2481-8-esben@geanix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190430_095953_664822_60D19A82 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, YueHaibing , Michal Simek , linux-kernel@vger.kernel.org, Yang Wei , Luis Chamberlain , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2019 at 09:17:54AM +0200, Esben Haabendal wrote: > Indirect register access goes through a DCR bus bridge, which > allows only one outstanding transaction. And to make matters > worse, each TEMAC IP block contains two Ethernet interfaces, and > although they seem to have separate registers for indirect access, > they actually share the registers. Or to be more specific, MSW, LSW > and CTL registers are physically shared between Ethernet interfaces > in same TEMAC IP, with RDY register being (almost) specificic to > the Ethernet interface. The 0x10000 bit in RDY reflects combined > bus ready state though. > > So we need to take care to synchronize not only within a single > device, but also between devices in same TEMAC IP. > > This commit allows to do that with legacy platform devices. > > For OF devices, the xlnx,compound parent of the temac node should be > used to find siblings, and setup a shared indirect_mutex between them. > I will leave this work to somebody else, as I don't have hardware to > test that. No regression is introduced by that, as before this commit > using two Ethernet interfaces in same TEMAC block is simply broken. > > Signed-off-by: Esben Haabendal Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel