From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] rtc: digicolor: set range
Date: Tue, 30 Apr 2019 21:10:21 +0200 [thread overview]
Message-ID: <20190430191021.GH11339@piout.net> (raw)
In-Reply-To: <87y33rsef3.fsf@tarshish>
On 30/04/2019 18:25:52+0300, Baruch Siach wrote:
> > Yes, this is ok to return a valid value that is higher than range_max.
> > However, at that time, you will not be able to set any alarms anymore as
> > the core doesn't allow to set alarms after range_max.
> >
> > I would think that this is fine because this will happen in 2106 and we
> > have a way to offset the time (the whole goal of setting the range)
> > using device tree.
>
> That's the sort of documentation that I'm missing. The 'start-year'
> property is mentioned in the DT binding documentation. But I don't see
> where range_max is documented as a facility for the time offset feature.
>
Sure, I'm planning to document better how a proper RTC driver should be
written. I needed to cleanup the digicolor driver because I4m removing
.set_mmss and .set_mmss64 this cycle.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-30 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 9:32 [PATCH 1/4] rtc: digicolor: fix possible race condition Alexandre Belloni
2019-04-30 9:32 ` [PATCH 2/4] rtc: digicolor: set range Alexandre Belloni
2019-04-30 11:36 ` Baruch Siach
2019-04-30 11:47 ` Alexandre Belloni
2019-04-30 12:20 ` Baruch Siach
2019-04-30 13:05 ` Alexandre Belloni
2019-04-30 15:25 ` Baruch Siach
2019-04-30 19:10 ` Alexandre Belloni [this message]
2019-04-30 9:32 ` [PATCH 3/4] rtc: digicolor: use .set_time Alexandre Belloni
2019-04-30 12:21 ` Baruch Siach
2019-04-30 9:32 ` [PATCH 4/4] rtc: digicolor: convert to SPDX identifier Alexandre Belloni
2019-04-30 12:22 ` Baruch Siach
2019-04-30 11:25 ` [PATCH 1/4] rtc: digicolor: fix possible race condition Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430191021.GH11339@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).