From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD25C43219 for ; Wed, 1 May 2019 10:40:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F04C020835 for ; Wed, 1 May 2019 10:40:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s/jtvT+y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F04C020835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DuqvU54YHQWSBmfiCOKJTMukNvbipkNWXp1zg9y9X5U=; b=s/jtvT+yAzSeJS XNHvHLNzLDO9YHZpURFM292/MsDFTiD/BzHi7drW5gDrOUOMUz5OiSUS2HHDL1ZkI1wpuGb+efzAa cMcEh2fN73kMoe01H7ppsEIFH8GVWYLnilrbVxwTZwYCTcKgshJ10c7nKqcZsqYw1ok+m/BtfBn6T CAXfLj94W1ZXHmDM7YnYKPaixoB3j2BolLq4OBugWM0vPszgRpW/jXqHqEFod7NPSpUWsxiRmHYDW j/++je2dh0rJCovuqt542xpeA4xZq//vZHYIeGcxc2Zu3q8tPvF9m26cBgT/Ds08/i3ooOQhpVigl csN2V6lhGk+rOZwmXXJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLmen-0006J1-Fj; Wed, 01 May 2019 10:40:09 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLmek-0005rq-3J for linux-arm-kernel@lists.infradead.org; Wed, 01 May 2019 10:40:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A01EE80D; Wed, 1 May 2019 03:40:04 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 76D6F3F719; Wed, 1 May 2019 03:40:02 -0700 (PDT) Date: Wed, 1 May 2019 11:39:56 +0100 From: Lorenzo Pieralisi To: Andrey Smirnov Subject: Re: [PATCH v4 00/11] i.MX6, DesignWare PCI improvements Message-ID: <20190501103956.GA3100@e121166-lin.cambridge.arm.com> References: <20190415004632.5907-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190415004632.5907-1-andrew.smirnov@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190501_034006_157310_E804CF09 X-CRM114-Status: GOOD ( 17.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , Richard Zhu , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Fabio Estevam , linux-imx@nxp.com, Bjorn Helgaas , Leonard Crestez , Chris Healy , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 14, 2019 at 05:46:21PM -0700, Andrey Smirnov wrote: > Everyone: > > This is the series containing various small improvements that I made > while reading the code and researching commit history of pci-imx6.c > and pcie-designware*.c files. All changes are optional, so commits > that don't seem like an improvement can be easily dropped. Hopefully > each patch is self-explanatory. > > I tested this series on i.MX6Q, i.MX7D and i.MX8MQ. Applied with Lucas' tags to pci/imx, hopefully we can squeeze this in for the v5.2 merge window. Lorenzo > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Chagnes since [v3]: > > - Collected Reviewed-by from Lucas for most of the patches > > - Converted "PCI: imx6: Replace calls to udelay() with > usleep_range()" to "PCI: imx6: Use usleep_range() in > imx6_pcie_enable_ref_clk()" > > - Converted "PCI: imx6: Remove redundant debug tracing" to "PCI: > imx6: Drop imx6_pcie_wait_for_link()" > > - Converted all of the callers of pcie_phy_poll_ack() to use > true/false in "PCI: imx6: Simplify pcie_phy_poll_ack()" > > Changes since [v2]: > > - All non i.MX6 patches dropped, since they were accepted as a > seprarte series > > - Series rebased on latest 'dwc-pci' branch of PCI tree > > - Patches "PCI: imx6: Use flags to indicate support for suspend" > and "PCI: imx6: Replace calls to udelay() with usleep_range()" > added to the series > > Changes since [v1]: > > - Dropped "PCI: imx6: Drop imx6_pcie_link_up()" due to the matter > already having been addressed by "PCI: imx6: Fix link training > status detection in link up check" from Trent Piepho > > - Changed "designware" -> "dwc" for all subject lines > > - Collected Acked-by's from Gustavo Pimentel > > [v3] lkml.kernel.org/r/20190401042547.14067-1-andrew.smirnov@gmail.com > [v2] lkml.kernel.org/r/20190104174925.17153-1-andrew.smirnov@gmail.com > [v1] lkml.kernel.org/r/20181221072716.29017-1-andrew.smirnov@gmail.com > > Andrey Smirnov (11): > PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() > PCI: imx6: Drop imx6_pcie_wait_for_link() > PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() > PCI: imx6: Remove PCIE_PL_PFLR_* constants > PCI: dwc: imx6: Share PHY debug register definitions > PCI: imx6: Make use of BIT() in constant definitions > PCI: imx6: Simplify bit operations in PHY functions > PCI: imx6: Simplify pcie_phy_poll_ack() > PCI: imx6: Restrict PHY register data to 16-bit > PCI: imx6: Use flags to indicate support for suspend > PCI: imx6: Use usleep_range() in imx6_pcie_enable_ref_clk() > > drivers/pci/controller/dwc/pci-imx6.c | 143 ++++++++----------- > drivers/pci/controller/dwc/pcie-designware.c | 12 +- > drivers/pci/controller/dwc/pcie-designware.h | 3 + > 3 files changed, 62 insertions(+), 96 deletions(-) > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel