From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "Nishad Kamdar" <nishadkamdar@gmail.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Joe Perches" <joe@perches.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: actions: Use the correct style for SPDX License Identifier
Date: Thu, 2 May 2019 09:07:46 +0200 [thread overview]
Message-ID: <20190502070746.GA16247@kroah.com> (raw)
In-Reply-To: <057d9b37-7475-1902-bce7-6d519c2e0fdf@suse.de>
On Wed, May 01, 2019 at 10:20:44PM +0200, Andreas Färber wrote:
> + linux-actions
>
> Am 01.05.19 um 09:07 schrieb Nishad Kamdar:
> > This patch corrects the SPDX License Identifier style
> > in header files related to Clock Drivers for Actions Semi Socs.
> > For C header files Documentation/process/license-rules.rst
> > mandates C-like comments (opposed to C source files where
> > C++ style should be used)
> [...]
> > drivers/clk/actions/owl-common.h | 2 +-
> > drivers/clk/actions/owl-composite.h | 2 +-
> > drivers/clk/actions/owl-divider.h | 2 +-
> > drivers/clk/actions/owl-factor.h | 2 +-
> > drivers/clk/actions/owl-fixed-factor.h | 2 +-
> > drivers/clk/actions/owl-gate.h | 2 +-
> > drivers/clk/actions/owl-mux.h | 2 +-
> > drivers/clk/actions/owl-pll.h | 2 +-
> > drivers/clk/actions/owl-reset.h | 2 +-
> > 9 files changed, 9 insertions(+), 9 deletions(-)
>
> Where's the practical benefit of this patch? These are all private
> headers used from C files, so they can handle C++ comments just fine,
> otherwise we would've seen build failures.
Please read Documentation/process/license-rules.rst, the section
entitled "Style", for what the documented formats are for SPDX lines,
depending on the file type.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-02 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 7:07 [PATCH] clk: actions: Use the correct style for SPDX License Identifier Nishad Kamdar
2019-05-01 20:02 ` Stephen Boyd
2019-05-01 20:20 ` Andreas Färber
2019-05-02 7:07 ` Greg Kroah-Hartman [this message]
2019-05-02 10:25 ` Andreas Färber
2019-05-02 10:38 ` Greg Kroah-Hartman
2019-05-02 10:45 ` Andreas Färber
2019-05-02 11:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502070746.GA16247@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=afaerber@suse.de \
--cc=joe@perches.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=nishadkamdar@gmail.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).