From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 762F2C43219 for ; Thu, 2 May 2019 08:03:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 468D22089E for ; Thu, 2 May 2019 08:03:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kJWeFPEm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 468D22089E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G8v0PlpzdhS5L6VzaS7PKaWtmW8yi4jpeAQ7C1T5BL8=; b=kJWeFPEmzbXDqH HFWfp6vX67xUuhA2l/htuySrWYX4dYEFplgqy88TA75ROurDZGWENP9zH5sHaLVtz8nxfb4vyFEW2 U7A4kpOgIQqSLea2CuPMie3MA8A+gCqeUPCsuvx4+4rKzab53JCsUk/uMOg3rPvYmvZBHF7uOGZu+ L+ivz4ggWB2nv/zqDx6nlI2rWcGf7vjT6Tu7sEE8ob+RsL5MGFuYIzxkoE2d56QEnHly7FECnsGV2 uBQ0laL9mh/N0/1nA+EkLijAKGhp0aMwejx4HVTj9vl4h5eme2/qXQRLy+nxQ6Y9ORTmH9OwxdEqs hg1fQSJNdYnKXPe5m/Kw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM6gM-0003lp-8X; Thu, 02 May 2019 08:03:06 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hM6gI-0003lK-PI for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2019 08:03:03 +0000 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 May 2019 01:03:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,421,1549958400"; d="scan'208";a="169840867" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 02 May 2019 01:02:55 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 02 May 2019 11:02:55 +0300 Date: Thu, 2 May 2019 11:02:55 +0300 From: Mika Westerberg To: Ard Biesheuvel Subject: Re: [PATCH v2 4/4] gpio: mb86s7x: enable ACPI support Message-ID: <20190502080255.GS26516@lahna.fi.intel.com> References: <20190429131208.3620-1-ard.biesheuvel@linaro.org> <20190429131208.3620-5-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190429131208.3620-5-ard.biesheuvel@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190502_010302_872309_1BEA0133 X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Graeme Gregory , linux-acpi@vger.kernel.org, Marc Zyngier , Linus Walleij , "Rafael J. Wysocki" , linux-gpio@vger.kernel.org, Masahisa Kojima , linux-arm-kernel@lists.infradead.org, Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 29, 2019 at 03:12:08PM +0200, Ard Biesheuvel wrote: > @@ -160,13 +177,15 @@ static int mb86s70_gpio_probe(struct platform_device *pdev) > if (IS_ERR(gchip->base)) > return PTR_ERR(gchip->base); > > - gchip->clk = devm_clk_get(&pdev->dev, NULL); > - if (IS_ERR(gchip->clk)) > - return PTR_ERR(gchip->clk); > + if (!ACPI_COMPANION(&pdev->dev)) { Since you don't use the returned ACPI object, you can also use has_acpi_companion(&pdev->dev) here and other similar places. Regardless of that, Reviewed-by: Mika Westerberg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel