From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71189C43219 for ; Thu, 2 May 2019 18:44:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 452DA2075E for ; Thu, 2 May 2019 18:44:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PBqatMZh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TAjDKfRe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 452DA2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sH2i880htoMKme40QsPW35PN9Vt1bXp7zR1WTCbmppU=; b=PBqatMZhbrjFRg 9tzw7fxs86E8MRujJ2y7uMavvTYvvmmdPXU0wEoaqSySTPcLZWgOm0SPCJ8oheGRhaFaibkyNrzn8 o/MJFubxW2l7bMZdMql6O8wXDI2pFnAG+EtgXH5YZMHKWKcbuM5j6WLB0xGvgxXWpY84XIEgTLiR2 3S5B2GkG/fxImkRXqU8sUJioarb0dpfwJUMKooPwezd/157Jp3M54y+7dLdbm1Q2fyvObIdHQxYAD 9+oNr/CX4V4wuKYKP9wAPRLstT9AvULeY/MAhLa3pP4DgXVfw2pEDIZl8UWgriX0cF457Wf/iuO8y IGBenii4atVDBUZLeg8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMGhN-0002fp-5q; Thu, 02 May 2019 18:44:49 +0000 Received: from mail-yw1-xc44.google.com ([2607:f8b0:4864:20::c44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMGhJ-0002fN-OG for linux-arm-kernel@lists.infradead.org; Thu, 02 May 2019 18:44:47 +0000 Received: by mail-yw1-xc44.google.com with SMTP id o65so576185ywd.8 for ; Thu, 02 May 2019 11:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0H6/1V6/5CIKh3CDtEYPw4qJMt0j8mXo9dQuEOmaJ2c=; b=TAjDKfRewk/UKamdlBYp4Z/f6fr9mzmhTBqPKn6Tso2lr/AkBQ1LMwAK9XIDmPfqWH 1X2g+ZiCkYEJEIfn+6n2PJc1Ev9G5K81J+GgEo5MfNluS5utNruV2aiJWOsWhO1L39V3 Z6C+J9uqiqXPYgQ6dcQSGANxw+xbHRVZAHWyN5hgFksgs/XhUgIKGl/0h+zrDIy2eofo aoMe+6WRmr7JILlqWxy3H4DaUeYvmUJdygIwom0nYWR8nN82LMnNt4srD1UZaJjPLcot OJpUgaV5+1lK6hPsIBFneSFAOj6A3kBGy7IE9y3T5wB9bI5Hesqt1uBVI3nJujocribj yDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0H6/1V6/5CIKh3CDtEYPw4qJMt0j8mXo9dQuEOmaJ2c=; b=ED6wMhcME27MeUCsD8UCZpxmn9ssbh/Mx3Z8P29c3MkLbO7mU8zmi7YJGgn22GTMd6 2OvOdSuLYH7BX9EOizPWoPaMVIJ6YCMouIJH+A2zvD6J6NBU3v7WDvorh3df9+83U1gW yGEIwnfH8XX4FVfPrFe7F56iphxkP6hSNQ9dUcGwq8FgBNHjKDQ/gXb7wcMCi68OkNX8 10hnlyBV/s8orPFPDvSXTXSuPlISok39S1kNRxxxwru6S6GahMhzSbheFxuw45Jmja/a 8n8smRuGY2pZWMttIcGEHTmxzfP4gbkt6uegSDL3iHU4YhRifmNx5wgYJ/SjKEiMOu2p n+zg== X-Gm-Message-State: APjAAAULHCPuBwkPMUhOfMHpNzw6R3jZLi9QQt/01PoUKH24Sajch+J5 m7X1trRU2Y8wE1L/2lKmuBu6+w== X-Google-Smtp-Source: APXvYqym/T/mBRrGXQQDSpwxLouliK+q+GpIj38u16aTEyLNBYQwSdaMmlgY9yKwhmdV2+JjJHDJNw== X-Received: by 2002:a25:5d0f:: with SMTP id r15mr4433647ybb.373.1556822683578; Thu, 02 May 2019 11:44:43 -0700 (PDT) Received: from ziepe.ca (adsl-173-228-226-134.prtc.net. [173.228.226.134]) by smtp.gmail.com with ESMTPSA id q204sm16965820ywq.44.2019.05.02.11.44.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 11:44:42 -0700 (PDT) Received: from jgg by jggl.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hMGhG-00026A-3l; Thu, 02 May 2019 15:44:42 -0300 Date: Thu, 2 May 2019 15:44:42 -0300 From: Jason Gunthorpe To: Catalin Marinas Subject: Re: [PATCH v13 16/20] IB/mlx4, arm64: untag user pointers in mlx4_get_umem_mr Message-ID: <20190502184442.GA31165@ziepe.ca> References: <1e2824fd77e8eeb351c6c6246f384d0d89fd2d58.1553093421.git.andreyknvl@google.com> <20190429180915.GZ6705@mtr-leonro.mtl.com> <20190430111625.GD29799@arrakis.emea.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190430111625.GD29799@arrakis.emea.arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190502_114446_199713_B572A70F X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Szabolcs Nagy , Will Deacon , Kostya Serebryany , Eric Dumazet , Vincenzo Frascino , linux-arch@vger.kernel.org, Leon Romanovsky , linux-rdma@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dave Martin , Evgeniy Stepanov , Kees Cook , Ruben Ayrapetyan , Andrey Konovalov , Kevin Brodsky , Dmitry Vyukov , linux-mm@kvack.org, netdev@vger.kernel.org, Yishai Hadas , linux-kernel@vger.kernel.org, Ramana Radhakrishnan , Andrew Morton , Robin Murphy , "David S. Miller" , Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2019 at 12:16:25PM +0100, Catalin Marinas wrote: > > Interesting, the followup question is why mlx4 is only one driver in IB which > > needs such code in umem_mr. I'll take a look on it. > > I don't know. Just using the light heuristics of find_vma() shows some > other places. For example, ib_umem_odp_get() gets the umem->address via > ib_umem_start(). This was previously set in ib_umem_get() as called from > mlx4_get_umem_mr(). Should the above patch have just untagged "start" on > entry? I have a feeling that there needs to be something for this in the odp code.. Presumably mmu notifiers and what not also use untagged pointers? Most likely then the umem should also be storing untagged pointers. This probably becomes problematic because we do want the tag in cases talking about the base VA of the MR.. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel