linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 04/25] iommu/dma: Remove the flush_page callback
Date: Fri, 3 May 2019 12:44:54 +0100	[thread overview]
Message-ID: <20190503114454.GD55449@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190503114335.GC55449@arrakis.emea.arm.com>

On Fri, May 03, 2019 at 12:43:35PM +0100, Catalin Marinas wrote:
> On Tue, Apr 30, 2019 at 06:51:53AM -0400, Christoph Hellwig wrote:
> > We now have a arch_dma_prep_coherent architecture hook that is used
> > for the generic DMA remap allocator, and we should use the same
> > interface for the dma-iommu code.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> > ---
> >  arch/arm64/mm/dma-mapping.c | 8 +-------
> >  drivers/iommu/dma-iommu.c   | 8 +++-----
> >  include/linux/dma-iommu.h   | 3 +--
> >  3 files changed, 5 insertions(+), 14 deletions(-)
> > 
> > diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
> > index 674860e3e478..10a8852c8b6a 100644
> > --- a/arch/arm64/mm/dma-mapping.c
> > +++ b/arch/arm64/mm/dma-mapping.c
> > @@ -104,12 +104,6 @@ arch_initcall(arm64_dma_init);
> >  #include <linux/platform_device.h>
> >  #include <linux/amba/bus.h>
> >  
> > -/* Thankfully, all cache ops are by VA so we can ignore phys here */
> > -static void flush_page(struct device *dev, const void *virt, phys_addr_t phys)
> > -{
> > -	__dma_flush_area(virt, PAGE_SIZE);
> > -}
> 
> Rather than removing, should this not become arch_dma_prep_coherent()?
> With patch 2 selecting the corresponding Kconfig option, I think with
> this patch you'd get a build error (haven't tried).

Ah, sorry, it was already there.

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-03 11:45 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 10:51 implement generic dma_map_ops for IOMMUs v4 Christoph Hellwig
2019-04-30 10:51 ` [PATCH 01/25] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Christoph Hellwig
2019-05-03 11:33   ` Catalin Marinas
2019-05-07  6:37     ` Christoph Hellwig
2019-05-07  9:05       ` Will Deacon
2019-04-30 10:51 ` [PATCH 02/25] dma-mapping: add a Kconfig symbol to indicated arch_dma_prep_coherent presence Christoph Hellwig
2019-05-03 11:36   ` Catalin Marinas
2019-04-30 10:51 ` [PATCH 03/25] iommu/dma: Cleanup dma-iommu.h Christoph Hellwig
2019-04-30 10:51 ` [PATCH 04/25] iommu/dma: Remove the flush_page callback Christoph Hellwig
2019-05-03 11:43   ` Catalin Marinas
2019-05-03 11:44     ` Catalin Marinas [this message]
2019-04-30 10:51 ` [PATCH 05/25] iommu/dma: Use for_each_sg in iommu_dma_alloc Christoph Hellwig
2019-04-30 10:51 ` [PATCH 06/25] iommu/dma: move the arm64 wrappers to common code Christoph Hellwig
2019-05-03 11:45   ` Catalin Marinas
2019-04-30 10:51 ` [PATCH 07/25] iommu/dma: Move __iommu_dma_map Christoph Hellwig
2019-04-30 10:51 ` [PATCH 08/25] iommu/dma: Move domain lookup into __iommu_dma_{map, unmap} Christoph Hellwig
2019-04-30 10:51 ` [PATCH 09/25] iommu/dma: Squash __iommu_dma_{map,unmap}_page helpers Christoph Hellwig
2019-04-30 10:51 ` [PATCH 10/25] iommu/dma: Factor out remapped pages lookup Christoph Hellwig
2019-04-30 10:52 ` [PATCH 11/25] iommu/dma: Refactor the page array remapping allocator Christoph Hellwig
2019-04-30 10:52 ` [PATCH 12/25] iommu/dma: Remove __iommu_dma_free Christoph Hellwig
2019-04-30 10:52 ` [PATCH 13/25] iommu/dma: Refactor iommu_dma_free Christoph Hellwig
2019-04-30 10:52 ` [PATCH 14/25] iommu/dma: Refactor iommu_dma_alloc Christoph Hellwig
2019-04-30 10:52 ` [PATCH 15/25] iommu/dma: Don't remap CMA unnecessarily Christoph Hellwig
2019-04-30 10:52 ` [PATCH 16/25] iommu/dma: Merge the CMA and alloc_pages allocation paths Christoph Hellwig
2019-04-30 10:52 ` [PATCH 17/25] iommu/dma: Split iommu_dma_free Christoph Hellwig
2019-04-30 10:52 ` [PATCH 18/25] iommu/dma: Cleanup variable naming in iommu_dma_alloc Christoph Hellwig
2019-04-30 10:52 ` [PATCH 19/25] iommu/dma: Refactor iommu_dma_alloc, part 2 Christoph Hellwig
2019-04-30 10:52 ` [PATCH 20/25] iommu/dma: Refactor iommu_dma_get_sgtable Christoph Hellwig
2019-04-30 10:52 ` [PATCH 21/25] iommu/dma: Refactor iommu_dma_mmap Christoph Hellwig
2019-04-30 10:52 ` [PATCH 22/25] iommu/dma: Don't depend on CONFIG_DMA_DIRECT_REMAP Christoph Hellwig
2019-04-30 10:52 ` [PATCH 23/25] iommu/dma: Switch copyright boilerplace to SPDX Christoph Hellwig
2019-04-30 10:52 ` [PATCH 24/25] arm64: switch copyright boilerplace to SPDX in dma-mapping.c Christoph Hellwig
2019-05-03 11:45   ` Catalin Marinas
2019-04-30 10:52 ` [PATCH 25/25] arm64: trim includes " Christoph Hellwig
2019-05-03 11:46   ` Catalin Marinas
2019-05-02 13:22 ` implement generic dma_map_ops for IOMMUs v4 Christoph Hellwig
2019-05-03 11:47   ` Catalin Marinas
2019-05-03 11:59     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190503114454.GD55449@arrakis.emea.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thomas.lendacky@amd.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).