From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB732C43219 for ; Fri, 3 May 2019 23:58:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF342070B for ; Fri, 3 May 2019 23:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pYciajmv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KeUBh5m7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CF342070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o60am1+lAMqHPZqq7A5LE6rFTSlymAba3KxVtM8mtYw=; b=pYciajmvwhuPV3 3eDwt8NBoDiDkQniP1k4h2dHMH86JkMDsOH2ZDmDWbYtB4+AV2ftfSW8lah4mwjrC+38X/oDx5TIJ vph6ZFVrf/z0gzrLit0aDxrdhCX9CQ/88XAYDsncX0ekWF89BDw8u0qsylM+ujI3NRFpkm2UIv2D4 /AP5U0DUiBO92GVQMmr6fHK4UsbeHw8jLdodqgm8Fv6xdjtCktuwr4K74sAf6u4KprIzaH1xtUyGa caz2NL80sRti4xHerwn91ySdcGUw5fq5jJFqTkjpkmoLZytIkPg1eGAQnVjSUb9oygMLj3OQxr1pj V7SpGzTBgHx5KI8U+GuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMi4E-0001IP-R5; Fri, 03 May 2019 23:58:14 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMi4B-0001Hb-Hi for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2019 23:58:12 +0000 Received: by mail-pl1-x643.google.com with SMTP id y3so3444854plp.0 for ; Fri, 03 May 2019 16:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v7+8a0jOi82vA98ZW8MLz4Zxp+tPvn5pEZ3hYsxU2i4=; b=KeUBh5m7XrqqJoGtrD6Ib6knt5i2ib8XP24NKJEJyGpAwUOaLX/x7UY2/uecLPiyDe 9yyqjXnlM7Sdn7qZVIKCfp4lijNioihmlVmSLfE2FTzxpqPXWb817IqTmUzMWrglz7sL SQh/iyPbwkDdI8Zm3zUAt91zibej3pbV7DGpc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v7+8a0jOi82vA98ZW8MLz4Zxp+tPvn5pEZ3hYsxU2i4=; b=reFmdrkE41K8S0SxfKdihyX7USJj+6VYOIlTWuo6SRX4eEtLPMsJ/vbpVMKXMgbc+n S5GNYA4ujhaZOjgoMiChwbl4DZDSMbAN09FCXbnjzJ3yvTsu+g5XhZ8yuWDXWenBD1fZ zDo4cGRNaKwzo/DobOHoOv8qk8Jo9+0OsJ371AptcW7UgSNG6ulcqhvjw+jlwwIiQwxp WLS7eIp4krrdiTwgWvQRBnclL42KAzSmDDvjUWsWQJGBWdmkh74QTVMLPHKUR7Holqh3 JNG/8csItE0KXXQXBqqM6CZns/qF5yAsSxwsv1H0YOYdQSbpHnOaNi6zgDGpAT6bn0gR bC3Q== X-Gm-Message-State: APjAAAUFgewqUlrSV79qCdR1Yx5/yCZc9AArmCWS9F7C3dFHlREItEwG L7AJkCP+LgKQXp+8tMWnpflsRw== X-Google-Smtp-Source: APXvYqwCj3vkQhdXIGJu9EpWV0sc4q41te3mEjK0JRvTex2+xk1qSEGE3uWqGCe5EwjRzmV9owoA+A== X-Received: by 2002:a17:902:7207:: with SMTP id ba7mr13779305plb.329.1556927890867; Fri, 03 May 2019 16:58:10 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id h127sm4092709pgc.31.2019.05.03.16.58.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 16:58:10 -0700 (PDT) Date: Fri, 3 May 2019 16:58:09 -0700 From: Matthias Kaehlcke To: Douglas Anderson Subject: Re: [PATCH] ARM: dts: rockchip: Remove bogus 'i2s_clk_out' from rk3288-veyron-mickey Message-ID: <20190503235809.GD40515@google.com> References: <20190503234814.230901-1-dianders@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190503234814.230901-1-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190503_165811_582822_1D821659 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , briannorris@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, amstan@chromium.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 03, 2019 at 04:48:14PM -0700, Douglas Anderson wrote: > The rk3288-veyron-mickey device tree overrides the default "i2s" clock > settings to add the clock for "i2s_clk_out". > > That clock is only present in the bindings downstream Chrome OS 3.14 > tree. Upstream the i2s port bindings doesn't specify that as a > possible clock. > > Let's remove it. > > NOTE: for other rk3288-veyron devices this clock is consumed by > 'maxim,max98090'. Presumably if this clock is needed for mickey it'll > need to be consumed by something similar. > > Signed-off-by: Douglas Anderson > --- > > arch/arm/boot/dts/rk3288-veyron-mickey.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron-mickey.dts b/arch/arm/boot/dts/rk3288-veyron-mickey.dts > index e852594417b5..f9c4ece3c0d3 100644 > --- a/arch/arm/boot/dts/rk3288-veyron-mickey.dts > +++ b/arch/arm/boot/dts/rk3288-veyron-mickey.dts > @@ -142,8 +142,6 @@ > > &i2s { > status = "okay"; > - clock-names = "i2s_hclk", "i2s_clk", "i2s_clk_out"; > - clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>, <&cru SCLK_I2S0_OUT>; > }; > > &rk808 { effectively, 'i2s_clk_out' is not use in the upstream kernel. Reviewed-by: Matthias Kaehlcke _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel