From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B77CC43219 for ; Sat, 4 May 2019 07:55:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F654206DF for ; Sat, 4 May 2019 07:55:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="I3qu94e4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y8g6vWAD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F654206DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XR4L494HshFohAUDnLfrDbs6yhKnwRjMixnuwekwk0Y=; b=I3qu94e4Pow/Q5 Mzbr2GuaARtppKRPy7F70NwkoewO5u87PT20cuukBsh/Av4McpYlMlVXQEm34ebc4+FdahlL4WHmM r57hhf57qGV9/axqGptRBzsedqsW6nxW4fj0+dLcj55/UGIX7cxxuR8uzHDAylzlr9mTkJ+rriB4P kgBiBf0sO5ZPM4dAY4pXTFifH1Wdbx8bHo+m+AIUzj19vnNO9oNisUQCuoj/fQPG3ctq6WWpI86yP k3FKAG5Hq/Lr2Z81S50xktEwna7CobomNG4i5UuWYlxpyYgHblZbKacf0SS1YlCRohlplvJ3062Qn cKMg6oZ7BacH6Nvv9lLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMpVq-0001y4-OH; Sat, 04 May 2019 07:55:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMpVl-0001Rk-00 for linux-arm-kernel@lists.infradead.org; Sat, 04 May 2019 07:55:10 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD94A206DF; Sat, 4 May 2019 07:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556956505; bh=rYPN3R+HI0gzJ3zG999qqQnoIuSpK9XHHiTCWGM41vE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y8g6vWADpPZNrwosyOhB4k2QUKfIiD2hX6aCDYfnFrXrnot4C5HkGTT+mN7IL9N1d P3EVHLgxD7l8Hk4kKaR0DHXaMqekVxvGkdOjv9yRJR3NuFYmETNCoXmGINZEfifezy 0wRMqWdU/sCwOeNyi2HgdwKAUt08vfWZPaT8SMEc= Date: Sat, 4 May 2019 09:55:02 +0200 From: Greg KH To: Dragan Cvetic Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver Message-ID: <20190504075502.GA11133@kroah.com> References: <1556402706-176271-1-git-send-email-dragan.cvetic@xilinx.com> <1556402706-176271-3-git-send-email-dragan.cvetic@xilinx.com> <20190502172007.GA1874@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190504_005509_061724_CEE33565 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 03, 2019 at 04:41:21PM +0000, Dragan Cvetic wrote: > Hi Greg, > > Please find my inline comments below, > > Regards > Dragan > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Thursday 2 May 2019 18:20 > > To: Dragan Cvetic > > Cc: arnd@arndb.de; Michal Simek ; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org; > > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > On Sat, Apr 27, 2019 at 11:04:56PM +0100, Dragan Cvetic wrote: > > > +#define DRIVER_NAME "xilinx_sdfec" > > > +#define DRIVER_VERSION "0.3" > > > > Version means nothing with the driver in the kernel tree, please remove > > it. > > Will be removed. Thank you. > > > > > > +#define DRIVER_MAX_DEV BIT(MINORBITS) > > > > Why this number? Why limit yourself to any number? > > > > There can be max 8 devices for this driver. I'll change to 8. > > > > + > > > +static struct class *xsdfec_class; > > > > Do you really need your own class? > > When writing a character device driver, my goal is to create and register an instance > of that structure associated with a struct file_operations, exposing a set of operations > to the user-space. One of the steps to make this goal is Create a class for a devices, > visible in /sys/class/. Why do you need a class? Again, why not just use the misc_device api, that seems much more relevant here and will make the code a lot simpler. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel