From: kbuild test robot <lkp@intel.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: kbuild-all@01.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: [clk:clk-parent-rewrite 18/78] drivers/clk/clk.c:371 clk_core_get() warn: always true condition '(index >= 0) => (0-255 >= 0)'
Date: Sat, 4 May 2019 13:42:39 +0800 [thread overview]
Message-ID: <201905041336.UcvSZvFD%lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-parent-rewrite
head: f5e93ab2421d0dd27acac9159d9c4834cd5705e7
commit: 9fd6fd58989e06bc5fe92f5aef85a64f63340ab1 [18/78] clk: Cache core in clk_fetch_parent_index() without names
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
New smatch warnings:
drivers/clk/clk.c:371 clk_core_get() warn: always true condition '(index >= 0) => (0-255 >= 0)'
Old smatch warnings:
drivers/clk/clk.c:135 clk_prepare_lock() warn: inconsistent returns 'mutex:&prepare_lock'.
Locked on: line 135
Unlocked on: line 128
drivers/clk/clk.c:383 clk_core_get() warn: passing zero to 'ERR_CAST'
drivers/clk/clk.c:432 clk_hw_get_parent_by_index() error: 'parent' dereferencing possible ERR_PTR()
drivers/clk/clk.c:561 clk_mux_determine_rate_flags() error: 'parent' dereferencing possible ERR_PTR()
drivers/clk/clk.c:3405 clk_hw_create_clk() warn: passing zero to 'ERR_CAST'
drivers/clk/clk.c:4321 __of_clk_get_hw_from_provider() warn: passing zero to 'ERR_CAST'
vim +371 drivers/clk/clk.c
bddca894 Prashant Gaikwad 2012-12-26 326
fc0c209c Stephen Boyd 2019-04-12 327 /**
dde4eff4 Stephen Boyd 2019-04-12 328 * clk_core_get - Find the clk_core parent of a clk
fc0c209c Stephen Boyd 2019-04-12 329 * @core: clk to find parent of
9fd6fd58 Stephen Boyd 2019-04-30 330 * @p_index: parent index to search for
fc0c209c Stephen Boyd 2019-04-12 331 *
fc0c209c Stephen Boyd 2019-04-12 332 * This is the preferred method for clk providers to find the parent of a
fc0c209c Stephen Boyd 2019-04-12 333 * clk when that parent is external to the clk controller. The parent_names
fc0c209c Stephen Boyd 2019-04-12 334 * array is indexed and treated as a local name matching a string in the device
dde4eff4 Stephen Boyd 2019-04-12 335 * node's 'clock-names' property or as the 'con_id' matching the device's
dde4eff4 Stephen Boyd 2019-04-12 336 * dev_name() in a clk_lookup. This allows clk providers to use their own
fc0c209c Stephen Boyd 2019-04-12 337 * namespace instead of looking for a globally unique parent string.
fc0c209c Stephen Boyd 2019-04-12 338 *
fc0c209c Stephen Boyd 2019-04-12 339 * For example the following DT snippet would allow a clock registered by the
fc0c209c Stephen Boyd 2019-04-12 340 * clock-controller@c001 that has a clk_init_data::parent_data array
fc0c209c Stephen Boyd 2019-04-12 341 * with 'xtal' in the 'name' member to find the clock provided by the
fc0c209c Stephen Boyd 2019-04-12 342 * clock-controller@f00abcd without needing to get the globally unique name of
fc0c209c Stephen Boyd 2019-04-12 343 * the xtal clk.
fc0c209c Stephen Boyd 2019-04-12 344 *
fc0c209c Stephen Boyd 2019-04-12 345 * parent: clock-controller@f00abcd {
fc0c209c Stephen Boyd 2019-04-12 346 * reg = <0xf00abcd 0xabcd>;
fc0c209c Stephen Boyd 2019-04-12 347 * #clock-cells = <0>;
fc0c209c Stephen Boyd 2019-04-12 348 * };
fc0c209c Stephen Boyd 2019-04-12 349 *
fc0c209c Stephen Boyd 2019-04-12 350 * clock-controller@c001 {
fc0c209c Stephen Boyd 2019-04-12 351 * reg = <0xc001 0xf00d>;
fc0c209c Stephen Boyd 2019-04-12 352 * clocks = <&parent>;
fc0c209c Stephen Boyd 2019-04-12 353 * clock-names = "xtal";
fc0c209c Stephen Boyd 2019-04-12 354 * #clock-cells = <1>;
fc0c209c Stephen Boyd 2019-04-12 355 * };
fc0c209c Stephen Boyd 2019-04-12 356 *
fc0c209c Stephen Boyd 2019-04-12 357 * Returns: -ENOENT when the provider can't be found or the clk doesn't
fc0c209c Stephen Boyd 2019-04-12 358 * exist in the provider. -EINVAL when the name can't be found. NULL when the
fc0c209c Stephen Boyd 2019-04-12 359 * provider knows about the clk but it isn't provided on this system.
fc0c209c Stephen Boyd 2019-04-12 360 * A valid clk_core pointer when the clk can be found in the provider.
fc0c209c Stephen Boyd 2019-04-12 361 */
9fd6fd58 Stephen Boyd 2019-04-30 362 static struct clk_core *clk_core_get(struct clk_core *core, u8 p_index)
fc0c209c Stephen Boyd 2019-04-12 363 {
9fd6fd58 Stephen Boyd 2019-04-30 364 const char *name = core->parents[p_index].fw_name;
9fd6fd58 Stephen Boyd 2019-04-30 365 u8 index = core->parents[p_index].index;
dde4eff4 Stephen Boyd 2019-04-12 366 struct clk_hw *hw = ERR_PTR(-ENOENT);
dde4eff4 Stephen Boyd 2019-04-12 367 struct device *dev = core->dev;
dde4eff4 Stephen Boyd 2019-04-12 368 const char *dev_id = dev ? dev_name(dev) : NULL;
fc0c209c Stephen Boyd 2019-04-12 369 struct device_node *np = core->of_node;
fc0c209c Stephen Boyd 2019-04-12 370
601b6e93 Stephen Boyd 2019-04-12 @371 if (np && index >= 0)
601b6e93 Stephen Boyd 2019-04-12 372 hw = of_clk_get_hw(np, index, name);
dde4eff4 Stephen Boyd 2019-04-12 373
dde4eff4 Stephen Boyd 2019-04-12 374 /*
dde4eff4 Stephen Boyd 2019-04-12 375 * If the DT search above couldn't find the provider or the provider
dde4eff4 Stephen Boyd 2019-04-12 376 * didn't know about this clk, fallback to looking up via clkdev based
dde4eff4 Stephen Boyd 2019-04-12 377 * clk_lookups
dde4eff4 Stephen Boyd 2019-04-12 378 */
601b6e93 Stephen Boyd 2019-04-12 379 if (PTR_ERR(hw) == -ENOENT && name)
dde4eff4 Stephen Boyd 2019-04-12 380 hw = clk_find_hw(dev_id, name);
dde4eff4 Stephen Boyd 2019-04-12 381
dde4eff4 Stephen Boyd 2019-04-12 382 if (IS_ERR(hw))
fc0c209c Stephen Boyd 2019-04-12 383 return ERR_CAST(hw);
fc0c209c Stephen Boyd 2019-04-12 384
fc0c209c Stephen Boyd 2019-04-12 385 return hw->core;
fc0c209c Stephen Boyd 2019-04-12 386 }
fc0c209c Stephen Boyd 2019-04-12 387
:::::: The code at line 371 was first introduced by commit
:::::: 601b6e93304a65f8f7c37168763ab9ba5b195ce5 clk: Allow parents to be specified via clkspec index
:::::: TO: Stephen Boyd <sboyd@kernel.org>
:::::: CC: Stephen Boyd <sboyd@kernel.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reply other threads:[~2019-05-04 5:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201905041336.UcvSZvFD%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).