From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E91BFC43219 for ; Sat, 4 May 2019 14:41:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B93E620859 for ; Sat, 4 May 2019 14:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pwFi8SB1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ThCm6UKr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B93E620859 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O8k7QOndYnJMVKgF7LDwMWAm2cDlwZxNtUcyBxAAqyI=; b=pwFi8SB1rgoJAs BnqpUBtcUAbXF9wz2XQrZE9snBggVtLxaO9Tk5nXQgWX1s5FdfNXROuFi9qcQ7suSHXjFn1zmTBLu GkiHUd3qq895O0h6mLhLgNs8O4CnQdSU4Z8LLgBR6/Wa9J3Awmpz6/ov4NVGi7uRIUSMp1PMRYXSj PQnOnPENzHfRAoeY7mtsaKFOtWONdOu6pjuP8OHt4+egNcT74pV7+OjvSkss7/wQpGlQqkoNFaBxo BaAR9gdcmzMGves2og3l5wxR2Px7TcmRkAsHIv0OUiQo937q7eLzDoQubr2JUojBjohqJw6twWy5e tBE2iurp4xVzHQoxg6Ng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMvr4-0002Sr-QN; Sat, 04 May 2019 14:41:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMvr1-0002SH-GW for linux-arm-kernel@lists.infradead.org; Sat, 04 May 2019 14:41:33 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0F9C720859; Sat, 4 May 2019 14:41:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556980890; bh=gSjzNXwzVADkhUG1J+XQmSWvUA18jz5VVOMIPF/+1Wo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ThCm6UKrH6zyS8oz0Qw5T0dAyoGWPWxAFtryrhciPkXkkctI/EgK8butFvzCy9Hyu RxqXKbYhZxGYfCNElmz9Q6ap8/AIANtSZHt7V2oAuWjLBRlgyXzVdYYLpGdJaRvbrO tpoVgZrage+I+yowLYnvLnctJR+7XYiJHtWMEhRg= Date: Sat, 4 May 2019 16:41:28 +0200 From: Greg KH To: Arnd Bergmann Subject: Re: [PATCH V3 04/12] misc: xilinx_sdfec: Add open, close and ioctl Message-ID: <20190504144128.GA13454@kroah.com> References: <1556402706-176271-1-git-send-email-dragan.cvetic@xilinx.com> <1556402706-176271-5-git-send-email-dragan.cvetic@xilinx.com> <20190502172345.GC1874@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190504_074131_914848_49052FE5 X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DTML , Dragan Cvetic , Michal Simek , Linux Kernel Mailing List , Rob Herring , Derek Kiernan , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 04, 2019 at 10:35:02AM -0400, Arnd Bergmann wrote: > On Thu, May 2, 2019 at 1:23 PM Greg KH wrote: > > > > On Sat, Apr 27, 2019 at 11:04:58PM +0100, Dragan Cvetic wrote: > > > Add char device interface per DT node present and support > > > file operations: > > > - open(), > > > - close(), > > > - unlocked_ioctl(), > > > - compat_ioctl(). > > > > Why do you need compat_ioctl() at all? Any "new" driver should never > > need it. Just create your structures properly. > > The function he added was the version that is needed when the structures > are compatible. I submitted a series to add a generic 'compat_ptr_ioctl' > implementation that would save a few lines here doing the same thing, > but it's not merged yet. > > Generally speaking, every driver that has a .ioctl() function should also > have a .compat_ioctl(), and ideally it should be exactly this trivial > version. Ok, for some reason I thought if there was no need for a compat ioctl (i.e. no pointer mess), then no need for a callback at all. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel