From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EE7C004C9 for ; Sun, 5 May 2019 15:39:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC143208C2 for ; Sun, 5 May 2019 15:39:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b+rHRD9t"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cbbgoCrc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC143208C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mVraxhmi97FIvZR9uJ6kqbOdjlzbXKEaU+jzSyxqP5Q=; b=b+rHRD9t4+M/8/ daiKxmmbyKB6ioWeM/zkjErs86FNf3hZHF/yLCJ2UIUy39UqMh5GyPSCeE7Q3dw55wKq+Om78t1YF 5hnAxq2acR6iCeqZ7+yc0Tx0LNShzra50k4bUwdmGhCCbAk51yYc5EspLE+SrryHLvSkgHcn93ARO kjpgkfRMglxe7Y5V5PjWK0MwqT3/LwFo3gHJb0w+zttX5W2XL4sJRTZLTLh6nDQ5XoxtaSgqy7iUe HTtpEDYBgSHhCCNq2eby/ebVc3a9vc+PuqsF3z52iV1uJuBDnO0jpXW4sg6QDBTbpKsBJf8LDXSFf eOFy9+H2SrBgrkabbS1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNJEO-0007Im-5O; Sun, 05 May 2019 15:39:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNJEK-0007IH-T3 for linux-arm-kernel@lists.infradead.org; Sun, 05 May 2019 15:39:10 +0000 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88997206DF; Sun, 5 May 2019 15:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557070748; bh=x5pvTT0YfjwpIeJljFGVaOyqST+4wd9cZ02Kih+mMgw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cbbgoCrc1p21k3S4ympnovRb9UwA9gY2sKrCeLJ6naLJ46AhAAb9UbespVun4u4PJ i9Q5TwAyWOZ3JjTn0uh6TmU//BuFLoKDtNweNjN7s6ghGW+IZceJJ8YLKGlEkgndBW k1fuib3ycTjNlO5AXIrNicND8WcvnkLAIChiCUsM= Date: Sun, 5 May 2019 16:39:01 +0100 From: Jonathan Cameron To: Philippe Schenker Subject: Re: [PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment Message-ID: <20190505163901.2cc9dec9@archlinux> In-Reply-To: <20190503135725.9959-1-dev@pschenker.ch> References: <20190503135725.9959-1-dev@pschenker.ch> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190505_083908_959942_E0828F7C X-CRM114-Status: GOOD ( 13.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Coquelin , Lars-Peter Clausen , Max Krummenacher , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Agner , Philippe Schenker , Peter Meerwald-Stadler , Hartmut Knaack , Lee Jones , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Alexandre Torgue Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 3 May 2019 15:57:23 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > Remove unnecessary assignment. This could potentially cause an issue, if > the wait function runs into a timeout. Furthermore is this assignment also > not there in stmpe_read_temp() > > Signed-off-by: Philippe Schenker This would probably have benefited from a statement that *val is set twice currently. Good find. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > > drivers/iio/adc/stmpe-adc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c > index 37f4b74a5d32..87141177fbda 100644 > --- a/drivers/iio/adc/stmpe-adc.c > +++ b/drivers/iio/adc/stmpe-adc.c > @@ -78,8 +78,6 @@ static int stmpe_read_voltage(struct stmpe_adc *info, > stmpe_reg_write(info->stmpe, STMPE_REG_ADC_CAPT, > STMPE_ADC_CH(info->channel)); > > - *val = info->value; > - > ret = wait_for_completion_interruptible_timeout > (&info->completion, STMPE_ADC_TIMEOUT); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel