From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CECAFC04A6B for ; Mon, 6 May 2019 12:34:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1985206A3 for ; Mon, 6 May 2019 12:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Moy71lAo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nKdDlF1j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1985206A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7GWzSkAK5OiQH+8tb5aOqdzfE+QUtzn0xlK8PdImYLE=; b=Moy71lAo4XyXBC IrZBEw8D4OEiwJGc4oOR1b1Oggc1Efp9UjhGNB4+7GCXhPaJUDcN46dwfOAfeTPmlRVIUpaAqFPC3 MwRi8Eg5Ujibwn1RZaZ61HqAakf0mgK+1rJll4uX8il2WqM4Ktfc/GKuo4j6D+RNJNAY7+jXB66nQ OzaTqugnNHSJOsh1PV/y6CnUi8HW80tsqxObQ1ZqlBARRi4CuECjy/+5826J4W68z6Y2kXed5zcHh s/8ts6tPcJ7yM4Z80bzlqmjVc3w+CrtkmVGmU0k7rXcyFxjraO/BDaiaS0iJNnnEEQDu56RFL5xfV jJOt5maoFpbsYbPEQ20Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNcpG-0005bo-1Q; Mon, 06 May 2019 12:34:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNcpD-0005an-2Z for linux-arm-kernel@lists.infradead.org; Mon, 06 May 2019 12:34:32 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B21D206A3; Mon, 6 May 2019 12:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557146068; bh=Q5fMKkiVbMug91PNamL4tmMt8uapZ0T4Sv2f/qxiycY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nKdDlF1jgWRs4Kfa2YhXCcLOjwm3zsi+ltisEgtFAsulfDfKDocSqj8Wwl1zroQcG sLhn41HptU6mriC06C7kYOL/MOczjcYdETIiWeumf4l8QWPNgKZ4LTdb4d14jTPyuB eQPblBCjlfOPPaOZ6IFD6ahsOJM2alEKKCP1fIDI= Date: Mon, 6 May 2019 14:34:25 +0200 From: Greg KH To: Dragan Cvetic Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver Message-ID: <20190506123425.GA26360@kroah.com> References: <1556402706-176271-1-git-send-email-dragan.cvetic@xilinx.com> <1556402706-176271-3-git-send-email-dragan.cvetic@xilinx.com> <20190502172007.GA1874@kroah.com> <20190504075502.GA11133@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190506_053431_156585_2485F79F X-CRM114-Status: GOOD ( 20.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , Derek Kiernan , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 06, 2019 at 12:23:56PM +0000, Dragan Cvetic wrote: > > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Saturday 4 May 2019 08:55 > > To: Dragan Cvetic > > Cc: arnd@arndb.de; Michal Simek ; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org; > > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > On Fri, May 03, 2019 at 04:41:21PM +0000, Dragan Cvetic wrote: > > > Hi Greg, > > > > > > Please find my inline comments below, > > > > > > Regards > > > Dragan > > > > > > > -----Original Message----- > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > Sent: Thursday 2 May 2019 18:20 > > > > To: Dragan Cvetic > > > > Cc: arnd@arndb.de; Michal Simek ; linux-arm-kernel@lists.infradead.org; robh+dt@kernel.org; > > > > mark.rutland@arm.com; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Derek Kiernan > > > > Subject: Re: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver > > > > > > > > On Sat, Apr 27, 2019 at 11:04:56PM +0100, Dragan Cvetic wrote: > > > > > +#define DRIVER_NAME "xilinx_sdfec" > > > > > +#define DRIVER_VERSION "0.3" > > > > > > > > Version means nothing with the driver in the kernel tree, please remove > > > > it. > > > > > > Will be removed. Thank you. > > > > > > > > > > > > +#define DRIVER_MAX_DEV BIT(MINORBITS) > > > > > > > > Why this number? Why limit yourself to any number? > > > > > > > > > > There can be max 8 devices for this driver. I'll change to 8. > > > > > > > > + > > > > > +static struct class *xsdfec_class; > > > > > > > > Do you really need your own class? > > > > > > When writing a character device driver, my goal is to create and register an instance > > > of that structure associated with a struct file_operations, exposing a set of operations > > > to the user-space. One of the steps to make this goal is Create a class for a devices, > > > visible in /sys/class/. > > > > Why do you need a class? Again, why not just use the misc_device api, > > that seems much more relevant here and will make the code a lot simpler. > > > > The driver can have 8 devices in SoC plus more in Programming Logic. > It looked logical to group them under the same MAJOR, although they > are independent of each other. Is this argument strong enough to use > class? Not really :) 8 devices is pretty small. What tool will be trying to talk to all of these devices and how was it going to find out what devices were in the system? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel