From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC90C04A6B for ; Mon, 6 May 2019 21:11:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EE7A206BF for ; Mon, 6 May 2019 21:11:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R53TMJGn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EE7A206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VZ9D5qLIrWwArT0NKib0TvUTcU1mRUWzDFehl9jgTMc=; b=R53TMJGn9D111s /PUInZUP3wCA26wdlKjdFk0URlW0CS2SyiwmF+65LuNPV/iSkIIvYehF6XYLXaznI5DoqvHcaeaeG Kj0SkW0HmUOJF+cx6etiL5GKFpriagHlFjmeNo7UTdxMo8fjGn8OzJgEPhpBBcp1oUC5AWJo3nbvm QgPm8usaRbUAExQ3xoGqxttTsEgB8DUCfkaRNOhWMGTNZyhVaNoYj00fKR3cwNn/EN/29w+tqSKMz xMwRbIvGuaPqQTAIut7EyO7MStn264qxWLpFR0IMp5aHjRIYY6KezMCMgpm9doa2Z5++WhNH3fiOX 2LPQlI/66j8RJ6yiDoyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNktZ-0006rD-0A; Mon, 06 May 2019 21:11:33 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNktV-0006qM-Dy for linux-arm-kernel@lists.infradead.org; Mon, 06 May 2019 21:11:30 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7E3B580DB; Mon, 6 May 2019 21:11:41 +0000 (UTC) Date: Mon, 6 May 2019 14:11:20 -0700 From: Tony Lindgren To: Daniel Lezcano Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro Message-ID: <20190506211120.GR8007@atomide.com> References: <1557163697-17882-1-git-send-email-yamada.masahiro@socionext.com> <6d8e2880-0cc0-a7d8-1d42-4401e15e3ac9@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d8e2880-0cc0-a7d8-1d42-4401e15e3ac9@linaro.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190506_141129_509775_0283A535 X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , linux-kbuild@vger.kernel.org, Alexey Gladkov , Aaro Koskinen , linux-kernel@vger.kernel.org, Russell King , Masahiro Yamada , Thomas Gleixner , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Daniel Lezcano [190506 17:40]: > On 06/05/2019 19:28, Masahiro Yamada wrote: > > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > > successfully compiled because they are never built as a module by > > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > > > A problem showed up when a patch "moduleparam: Save information about > > built-in modules in separate file" is applied. With this new feature, > > MODULE_*() are populated even if the callers are built-in. > > > > To avoid the build errors, the lines referencing to the undefined > > macro must be removed. > > > > The complete fix is to remove all MODULE_* and #include > > like many "make ... explicitly non-modular" commits did. > > > > For now, I am touching the offending lines. > > > > Reported-by: Stephen Rothwell > > Signed-off-by: Masahiro Yamada > > --- > > Acked-by: Daniel Lezcano Thanks, please feel free to merge together with your series: Acked-by: Tony Lindgren Or if you want me to queue it separately, please let me know. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel