From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Jacky Bai <ping.bai@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] cpufreq: imx6q: Fix the resource leak caused by incorrect error return
Date: Tue, 7 May 2019 08:07:02 +0200 [thread overview]
Message-ID: <20190507060702.ub4zjsurylldj2mm@pengutronix.de> (raw)
In-Reply-To: <20190507055327.sakuoy2j3g7dwv3f@vireshk-i7>
On Tue, May 07, 2019 at 11:23:27AM +0530, Viresh Kumar wrote:
> On 05-05-19, 08:02, Jacky Bai wrote:
> > Previous goto only handled the node reference, the opp table,
> > regulator & clk resource also need to be free before error return.
> >
> > Fixes: ddb64c5db3c (cpufreq: imx6q: fix possible object reference leak).
>
> This should have been.
>
> Fixes: ddb64c5db3cc ("cpufreq: imx6q: fix possible object reference leak")
>
> Auto configure it with following in .gitconfig
>
> [pretty]
> fixes = Fixes: %h (\"%s\")
> onelin = commit %h (\"%s\")
>
> and then:
>
> git log --pretty=fixes ddb64c5db3c
>
> will generate it by itself.
Just to add my color of the bikeshed, I have (among others):
[alias]
oneq = show -s --pretty='format:%h (\"%s\")'
in my ~/.gitconfig and can do:
$ git oneq ddb64c5db3c
ddb64c5db3cc ("cpufreq: imx6q: fix possible object reference leak")
which is a bit shorter than Viresh's suggestion.
(Originally I had "one" without the quotes which I learned (IIRC) from
the git mailing list. Instead of deviating from this I added 'q' for
"quotes" to match the usual convention in kernel land.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-07 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 8:02 [PATCH v2] cpufreq: imx6q: Fix the resource leak caused by incorrect error return Jacky Bai
2019-05-07 5:53 ` Viresh Kumar
2019-05-07 6:07 ` Uwe Kleine-König [this message]
2019-05-07 6:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190507060702.ub4zjsurylldj2mm@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).