From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F1AC004C9 for ; Tue, 7 May 2019 06:07:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 175D120675 for ; Tue, 7 May 2019 06:07:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZQvey+AX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 175D120675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AwZr9VRqEShQGEXdC5NuwKN/VV53nEkoU0MHXe7pHUs=; b=ZQvey+AXnd3DvC nF8s0KGxAP/1U3uajub6GWzqYZlMNRXOTfItN2milu4kNIUevy4HPgA9gJQYDtjUj9NgwK9bbJOix H19QmhP77cYmqQLKUro5WSeUYCL/riBxZIUm0vP7vzCuFT72W7V7D0Nnpr+RmEEv0sO3SmajGZjVp sfalprlks+upufI6jn9P/YxtjL7XkCKZ6VnC7PCm4WqbXoLtPmyJ0mf9tx1q2TvVFHbZ5wRIQTLsZ UabMdN6xRx4jdklvFQcUjGWFQPROx9SJzKcyPImfuXM1ndls9SgPg77fydzEkVkaRgrLgzCurg2cM KQip7qiJm+jmVcgFflhw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNtFz-0004LR-Aj; Tue, 07 May 2019 06:07:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNtFw-0004KY-5Q for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 06:07:13 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hNtFo-0005Pa-02; Tue, 07 May 2019 08:07:04 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1hNtFm-0001Aa-Re; Tue, 07 May 2019 08:07:02 +0200 Date: Tue, 7 May 2019 08:07:02 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Viresh Kumar Subject: Re: [PATCH v2] cpufreq: imx6q: Fix the resource leak caused by incorrect error return Message-ID: <20190507060702.ub4zjsurylldj2mm@pengutronix.de> References: <20190505080736.27970-1-ping.bai@nxp.com> <20190507055327.sakuoy2j3g7dwv3f@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507055327.sakuoy2j3g7dwv3f@vireshk-i7> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190506_230712_363861_ADAD7C80 X-CRM114-Status: GOOD ( 10.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jacky Bai , "linux-pm@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "rjw@rjwysocki.net" , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2019 at 11:23:27AM +0530, Viresh Kumar wrote: > On 05-05-19, 08:02, Jacky Bai wrote: > > Previous goto only handled the node reference, the opp table, > > regulator & clk resource also need to be free before error return. > > = > > Fixes: ddb64c5db3c (cpufreq: imx6q: fix possible object reference leak). > = > This should have been. > = > Fixes: ddb64c5db3cc ("cpufreq: imx6q: fix possible object reference leak") > = > Auto configure it with following in .gitconfig > = > [pretty] > fixes =3D Fixes: %h (\"%s\") > onelin =3D commit %h (\"%s\") > = > and then: > = > git log --pretty=3Dfixes ddb64c5db3c > = > will generate it by itself. Just to add my color of the bikeshed, I have (among others): [alias] oneq =3D show -s --pretty=3D'format:%h (\"%s\")' in my ~/.gitconfig and can do: $ git oneq ddb64c5db3c ddb64c5db3cc ("cpufreq: imx6q: fix possible object reference leak") which is a bit shorter than Viresh's suggestion. (Originally I had "one" without the quotes which I learned (IIRC) from the git mailing list. Instead of deviating from this I added 'q' for "quotes" to match the usual convention in kernel land.) Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel