From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE8BC04AAD for ; Tue, 7 May 2019 13:50:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0ED320B7C for ; Tue, 7 May 2019 13:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YIkbQyJf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oMQjJcPi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0ED320B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7NkGGxdw4bKTizsJeIg9ae74e/PU7Y25x8k1wUjfATM=; b=YIkbQyJf8BQtUh u4WdpHH4nrUP5pOr4Hzviw2S6TUN6xZ2ZxzYyzbqiUGawmBoQQU2rNsaBggci5iWbpYl/ZRxdNU+R ojyUPNOuZ2xGL1HLwRAw2xk6UW3/GTb7JNNIdIV0xPPP0YVVAGvO5Qaz4lXuoYnIblY9Ls49Y+ffq 8GrLbX+Bw3iKu+2F5u6h/jdwd9Uxy2nz+44YiBH5VgVsZa0PKvzUVyWVbX+ZY6YslebrUVwzh9OO9 OPJkZlfrdQWZKXL7LQP+1VfNr/zs/+2MindaLRVtt3mjE9mBSXXhvo8fiHfKnqEVSL56NpSL5zDTf Lpm7E83DSSC5EHGyRr+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0Tn-0000Mq-DC; Tue, 07 May 2019 13:49:59 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0Tk-0000MV-QO for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 13:49:58 +0000 Received: by mail-pg1-x542.google.com with SMTP id 85so8353446pgc.3 for ; Tue, 07 May 2019 06:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=S8BQEP1OV6vKoSe5VDyJlLX4UR1XhupCQW202rhq/sQ=; b=oMQjJcPiNX92IlwTDMAW4qr/DdkOFqHLv0mxlbPfOeLaWsnqFZadYEibjkDIgY2NoM /65COGgPxkzIo+amIzo6LPYgGDGhJxntl4IHC1R/RwjQFVpiP4UXGWuwbHOfyZ8euQcE ir9EJkZF9XcN0WR7nfl/JhEl0+MZHZx/FFJIdaszpfSQ9rsW7hA8LTHBLq1t+IWpekyS iyEd6m3PD3RorhuG5Xmkci0vdJw7KlYnHW5KDkeG+yBLz7q4YH3GU/dqJHBkQriNNSBe xEnRNdM5sxiM7Y2G+ogZwJCOOm3oWbLZc2p+U6WW1oVu9v/vdRNQ/7P9oOscBiCmAEP7 h3lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=S8BQEP1OV6vKoSe5VDyJlLX4UR1XhupCQW202rhq/sQ=; b=a1vKIFV9LTM85xmDczVt80il1bYf12nCpKP/RtBCSjAsJtLlWy7egnLG6Psvum2Bsj 6cLuO6LpXvrSSymah2Y6FOTmRWOUwgeojU5kU7/MOCbki3oi4BVx0QTLkVlp4clqKZoA gfcVbM3BBBCf4D2K3drcJOAYZhjGnVr5B3Jq1w3bHi+VvzMTWb+15hpg9gNkTGeiH+ip 1uYqob/kAuRe4PFKU63tdkKWvHRu07JREO+Wi2vVKLVNc+4VttOzojLs7Xcwlgq8rFK5 dr4GNSYRZwUcLtTCcsqVX1gfKpmiilMSOBHsi0uafBBy2n2weYU3QpfqdVJYnfpoPmMg ZpSw== X-Gm-Message-State: APjAAAVDFahYr2BkEbiC5y7kyHa8dca09cz/0mCJaLaPP0dh03o+au1v Lc0cEf1iFoVn1XU8Fw1quj+auKHO X-Google-Smtp-Source: APXvYqwNMrdvjlCOgIU9TBbSh3DwQp1FscE2sA0W7mHk+F+dufo6InfjIlXwfy6OIa5H5Al1dkWeIA== X-Received: by 2002:aa7:98c6:: with SMTP id e6mr2436297pfm.191.1557236995744; Tue, 07 May 2019 06:49:55 -0700 (PDT) Received: from localhost (c-73-222-71-142.hsd1.ca.comcast.net. [73.222.71.142]) by smtp.gmail.com with ESMTPSA id v6sm8275551pgk.77.2019.05.07.06.49.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 06:49:54 -0700 (PDT) Date: Tue, 7 May 2019 06:49:52 -0700 From: Richard Cochran To: Po Liu Subject: Re: [PATCH v1] timer:clock:ptp: add support the dynamic posix clock alarm set for ptp Message-ID: <20190507134952.uqqxmhinv75actbh@localhost> References: <1557032106-28041-1-git-send-email-Po.Liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1557032106-28041-1-git-send-email-Po.Liu@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_064956_859809_EC87DCF7 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roy Zang , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , Claudiu Manoil , Mingkai Hu , "Y.b. Lu" , "linuxppc-dev@lists.ozlabs.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" , "deepa.kernel@gmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 05, 2019 at 05:02:05AM +0000, Po Liu wrote: > Current kernel code do not support the dynamic posix clock alarm set. > This code would support it by the posix timer structure. > > 319 const struct k_clock clock_posix_dynamic = { > > 320 .clock_getres = pc_clock_getres, > 321 .clock_set = pc_clock_settime, > 322 .clock_get = pc_clock_gettime, > 323 .clock_adj = pc_clock_adjtime, > 324 + .timer_create = pc_timer_create, > 325 + .timer_del = pc_timer_delete, > 326 + .timer_set = pc_timer_set, > 327 + .timer_arm = pc_timer_arm, > } > Sorry, NAK, since we decided some time ago not to support timer_* operations on dynamic clocks. You get much better application level timer performance by synchronizing CLOCK_REALTIME to your PHC and using clock_nanosleep() with CLOCK_REALTIME or CLOCK_MONOTONIC. > This won't change the user space system call code. Normally the user > space set alarm by timer_create() and timer_settime(). Reference code > are tools/testing/selftests/ptp/testptp.c. That program still has misleading examples. Sorry about that. I'll submit a patch to remove them. > +static int pc_timer_create(struct k_itimer *new_timer) > +{ > + return 0; > +} > + This of course would never work. Consider what happens when two or more timers are created and armed. Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel