From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1172C004C9 for ; Tue, 7 May 2019 17:03:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74D8B205C9 for ; Tue, 7 May 2019 17:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lm9NIPQD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74D8B205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7YDXPqx5+XIxtjtnLa8lHiJ6+HLLpw1i48rkKFLEeR4=; b=lm9NIPQDQgW16P 3hcGHBGhQtuBzKucBnfgRhgLVFJqn6PID++dswgdJJSe8q2wubwSH5kYyGx7dQE+HAHh8VpLcDfwE 1mfDQ0zKk/i0GR4kFZBmwITvoScy11QKhNNGQKpSOMUv2GwK5Xr1mpocuGkHCQcvGpUkDTUTx7V5b xpjIKWVj7sUQDU5Eu+ZXF7BWKS+mANitf4k7KwJWA5YuLroYmrbk82jorJ56w9gMuEPRHplodo5fO unWr2bAZIpsTBcZNJX7Do0opCk30HtzVGgVf7+fjDoBffB95EuB7yWVlmSmcFv5fdppHhsCbPkvYr 3q4q7rZiZCziD6wI3xVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO3Uu-0001Qq-Pr; Tue, 07 May 2019 17:03:20 +0000 Received: from mail-pl1-f193.google.com ([209.85.214.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO3Ur-0001QV-Nq for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 17:03:18 +0000 Received: by mail-pl1-f193.google.com with SMTP id n8so8481193plp.10 for ; Tue, 07 May 2019 10:03:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZgOuuMrrhj8XAofs6xeZ/fsPkpFUrdc6Z7bFfUFRLkU=; b=ex5h05iFrfaGv+p7MK4D/LXjLsex8mAbp3RLo7/ZCwuLuHUSWqXBGjjtma/TuRfie3 UHdvTKAz64FoSGiBvdtu/3GIKKOhlSgw4tyeoRFsk9QXudd42qqny7s8a119ucBdjzrj MiUOMqhoQTcW2+RziA/v18D3R3WzuOaFDefnJfwNX7teCp2QHtN+B4ySstUQFy8oJ30b pswxRrEsfqfyNV+OPyNYq3hBd6xSn+0YIbNYvCu2ZRkgxV2NqcExC7HvlGyZ2/ttwoGw Hy7Adjbi3RXPlMBTxkx8j75II1THKx+85UF64LYCK4Rk2ERxZB2cglZkd+SEpD7XjpEQ nmPQ== X-Gm-Message-State: APjAAAWgMPgXTnWzvsEn4rRrVwarWI6ne5jAqC+8+bqud68YRCqigfm6 plAXot3XZIu0L0qn1Y79z12DQw== X-Google-Smtp-Source: APXvYqwNDn3NrBxsLCzzv0AbtjUL+SxTQfXa4VJ+Fy/gn2Z/CVWh+d8UM3NntMwIqWZ7Z/heKmrJ2Q== X-Received: by 2002:a17:902:8483:: with SMTP id c3mr39962344plo.19.1557248596403; Tue, 07 May 2019 10:03:16 -0700 (PDT) Received: from localhost ([2601:647:4700:2953:ec49:968:583:9f8]) by smtp.gmail.com with ESMTPSA id n15sm31360519pfb.111.2019.05.07.10.03.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 10:03:15 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Subject: [PATCH] fpga: zynqmp-fpga: Correctly handle error pointer Date: Tue, 7 May 2019 10:02:57 -0700 Message-Id: <20190507170257.25451-1-mdf@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_100317_776775_62E703ED X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: atull@kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, Moritz Fischer , linux-arm-kernel@lists.infradead.org, Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixes the following static checker error: drivers/fpga/zynqmp-fpga.c:50 zynqmp_fpga_ops_write() error: 'eemi_ops' dereferencing possible ERR_PTR() Note: This does not handle the EPROBE_DEFER value in a special manner. Fixes commit c09f7471127e ("fpga manager: Adding FPGA Manager support for Xilinx zynqmp") Reported-by: Dan Carpenter Signed-off-by: Moritz Fischer --- drivers/fpga/zynqmp-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c index f7cbaadf49ab..abcb0b2e75bf 100644 --- a/drivers/fpga/zynqmp-fpga.c +++ b/drivers/fpga/zynqmp-fpga.c @@ -47,7 +47,7 @@ static int zynqmp_fpga_ops_write(struct fpga_manager *mgr, char *kbuf; int ret; - if (!eemi_ops || !eemi_ops->fpga_load) + if (IS_ERR_OR_NULL(eemi_ops) || !eemi_ops->fpga_load) return -ENXIO; priv = mgr->priv; -- 2.21.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel