From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E07C004C9 for ; Tue, 7 May 2019 17:41:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1537205C9 for ; Tue, 7 May 2019 17:41:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uhogE2f7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1537205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R9EqYxk9RFSidwl5tagOUgafg4ynUP1uSh4cbJeckVE=; b=uhogE2f7rH1M8X OtKwfNWfG2afyzXjhTOONHi/RpDJVUXcz7/iLvua8IkzmQimpUYQRBRuaGR1zzzhr/8M9X6iwDbYk TNKXeFm7ppqLdzi8Z1yVIs4uK1wBOzNbt5XKKU8DY08HmZPrUJJr3JElLC8OMLvRDx1cnpIiULunx 83dR3n7t/VMTOAWz89rZgYeALVwkVxf1jJBgCCUOhfL68avnVNWJhScxRRMcO2VCQv0R4v7BNn5t5 hibL6qKbsoxLVckgyq4sMjCN80480K4lPYVzHjjdWgkSeWOBTky1ZesPzjEfETmBr2ATX4p0NUKXN nEwIu89vMt2tRklCk/5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO45b-0002G3-9d; Tue, 07 May 2019 17:41:15 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO45Z-0002Ff-7k; Tue, 07 May 2019 17:41:14 +0000 Received: by mail-ot1-f68.google.com with SMTP id i8so6032568oth.10; Tue, 07 May 2019 10:41:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9rNLy/ZQaK42lTMWdGC3VYdIL1Q3ruxBaNI2KenFfZA=; b=OkOif2d/kYjHtIwD+3TqX/C4Q/cvW5yjqfytYLN22KPaipW1d7DTYQnnP+xmCXHkjS m2cwGZkTrggC0X1WNnEkIYRzkU8+PClVfYMf+h1b5mpkwwWs8fblhUpWXgbmsatHgKZ6 U44XeoEhI7oCvqnHMSrGZs7eM8zETH/pdeLJ+xd8GmrD+su/x/e8c6s1FG7CSt7iQfvZ 20YgS1/mspBTsLIBS3YbqZGrWMMsBjJ20/ARgJHOZy2Wo2f2RXGw+ELQ2ZFNF5bsFqYl GQMdATezkgnxDUiFYSmjkeZUf7Ybw+sSgUej6kjYmRJQoS6viYHrUvDOzPok8Yx7yhk3 hACw== X-Gm-Message-State: APjAAAX2G+U6srXElqTav7HuLt20FC3Sg4L0YUjJ/J3ODl4sR6ExC0cU na81pcu6z1UNAY1IkCV20g== X-Google-Smtp-Source: APXvYqxVT+rgS9ARF8x0VFy/ggxBe7eDGWK8eU6UPVfhX/GM8vt4GowdhjtHpTbE2QIioJsCsu6roQ== X-Received: by 2002:a9d:6b93:: with SMTP id b19mr24293889otq.313.1557250872208; Tue, 07 May 2019 10:41:12 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 24sm2059963oiz.14.2019.05.07.10.41.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 10:41:11 -0700 (PDT) Date: Tue, 7 May 2019 12:41:10 -0500 From: Rob Herring To: Bibby Hsieh Subject: Re: [PATCH v5 03/12] dt-binding: gce: add binding for gce subsys property Message-ID: <20190507174110.GA6767@bogus> References: <20190507081355.52630-1-bibby.hsieh@mediatek.com> <20190507081355.52630-4-bibby.hsieh@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507081355.52630-4-bibby.hsieh@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_104113_282864_5E6E8884 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, kendrick.hsu@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , YT Shen , CK HU , Dennis-YC Hsieh , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , Frederic Chen , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2019 at 04:13:46PM +0800, Bibby Hsieh wrote: > tcmdq driver provide a function that get the relationship > of sub system number from device node for client. > add specification for #subsys-cells, mediatek,gce-subsys. > > Signed-off-by: Bibby Hsieh > --- > .../devicetree/bindings/mailbox/mtk-gce.txt | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > index 1f7f8f2a3f49..8fd9479bc9f6 100644 > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > @@ -21,11 +21,19 @@ Required properties: > priority: Priority of GCE thread. > atomic_exec: GCE processing continuous packets of commands in atomic > way. > +- #subsys-cells: Should be 3. > + <&phandle subsys_number start_offset size> > + phandle: Label name of a gce node. > + subsys_number: specify the sub-system id which is corresponding > + to the register address. > + start_offset: the start offset of register address that GCE can access. > + size: the total size of register address that GCE can access. Like the #event-cells, do you need this if it isn't variable? > > Required properties for a client device: > - mboxes: Client use mailbox to communicate with GCE, it should have this > property and list of phandle, mailbox specifiers. > -- mediatek,gce-subsys: u32, specify the sub-system id which is corresponding > +Optional propertier for a client device: > +- mediatek,gce-client-reg: u32, specify the sub-system id which is corresponding > to the register address. This isn't a u32, but a phandle + 3 cells (or a list of those). How many entries can there be? > > Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h' > @@ -40,6 +48,7 @@ Example: > clocks = <&infracfg CLK_INFRA_GCE>; > clock-names = "gce"; > #mbox-cells = <3>; > + #subsys-cells = <3>; > }; > > Example for a client device: > @@ -48,9 +57,9 @@ Example for a client device: > compatible = "mediatek,mt8173-mmsys"; > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > - mediatek,gce-subsys = ; > mutex-event-eof = CMDQ_EVENT_MUTEX1_STREAM_EOF>; > - > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>, > + <&gce SUBSYS_1401XXXX 0x2000 0x100>; > ... > }; > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel