From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EDEC04AB1 for ; Thu, 9 May 2019 08:09:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E88E6216C4 for ; Thu, 9 May 2019 08:09:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qABus/qE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E88E6216C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+PFu0coy9He2vdPzdtIz99J2q9oOLd2FQYIcBxUvoFk=; b=qABus/qEkpEfWSYWetReYKaaz I6phkdE/qk6kh/CoJxk6w5M6zuQu+ojkjBWZ1E97o5wXC9bOF52F26k1g6KvXtvzGuG8G+zW1Yddo WM7P0zldATIAFikjw//GAhrIMrWmYnGNI6zg180NFsngE2cnrb9HWEnpxpvft193AREuD08+sgz0Z NZ7rcXbXi8CyyJae7NYLihC9POvqfz8zIjQm8mKLgD9nblsc8BryWqcvOT3UGuj/m2a37RdmthwUv N59xabhGiah4SuX0G9/Sv816CXiQmH1yz/xujEgEuH4bGE1Fr8Iy9N8RycrnK+LyNEYqSEB6wZUqw vocS7S3gQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOe6q-0005kZ-8I; Thu, 09 May 2019 08:08:56 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOe6l-0005k8-CU for linux-arm-kernel@lists.infradead.org; Thu, 09 May 2019 08:08:53 +0000 Received: from localhost (p54B33113.dip0.t-ipconnect.de [84.179.49.19]) by pokefinder.org (Postfix) with ESMTPSA id E8C702E3571; Thu, 9 May 2019 09:55:31 +0200 (CEST) Date: Thu, 9 May 2019 09:55:28 +0200 From: Wolfram Sang To: Sascha Hauer Subject: Re: [EXT] Re: [PATCH 1/2] i2c: imx: I2C Driver doesn't consider I2C_IPGCLK_SEL RCW bit when using ls1046a SoC Message-ID: <20190509075528.obzchc3midbjpvzs@katana> References: <20190430044719.30720-1-chuanhua.han@nxp.com> <20190430125043.weqwzim4gpsvtkfe@pengutronix.de> <20190506073735.ctzybytamu44pbvv@pengutronix.de> <20190509074851.czcjlpfm2iooqjv4@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20190509074851.czcjlpfm2iooqjv4@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190509_010851_773017_DEEEC2FD X-CRM114-Status: GOOD ( 13.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Sumit Batra , "eha@deif.com" , "festevam@gmail.com" , "u.kleine-koenig@pengutronix.de" , "linux-kernel@vger.kernel.org" , Leo Li , "wsa+renesas@sang-engineering.com" , "robh+dt@kernel.org" , "l.stach@pengutronix.de" , "linux-i2c@vger.kernel.org" , Chuanhua Han , "linux@rempel-privat.de" , "shawnguo@kernel.org" , "peda@axentia.se" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx Content-Type: multipart/mixed; boundary="===============2899227572111656454==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2899227572111656454== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gv6qjm3xh6s2jhl3" Content-Disposition: inline --gv6qjm3xh6s2jhl3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > There are 2 places where clock division takes place - > >=20 > > 1) There is a clock divider outside of I2C block, which makes the clock= reaching > > I2C module as - Platform Clock/2 > > 2) There is another clock divider which specifically divides the clock = to the I2C block, > > based on RCW bit 424 (if 424th bit is 0 then the baud clock source i= s Platform Clock/4, > > if 424th bit is 1 then it remains Platform Clock/2) >=20 > So there is a clock divider which based on RCW bit 424 divides the clock > *to* the i2c module. This suggests the divider is outside of the i2c > module itself and thus part of the clock module. >=20 > We could argue that this divider sits between the clock module and the > i2c module, but for sure it's not in the i2c module. I really suggest to > put this SoC specific into the SoC specific clock driver rather than > littering the i2c driver with it. I am with Sascha here. The fact that you need to of_ioremap some registers is a really strong indication that the code should go somewhere else. I can't tell the best place (clock driver or seperate GUTS driver or syscon driver), but the I2C bus driver seems not suitable. --gv6qjm3xh6s2jhl3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlzT3OsACgkQFA3kzBSg KbbgNQ/8CGasqnfiTpZ11DFig8JEAVVpHiW7URbOcwfSNliiGRcajU0Z15c9dQrB FXq50Xgz1DAf+yhNgfWk28gZ9DdbGEdEvRUyZsW1oq/Vf2vJEx5wBQUB04Rw12KS 6OjdgBK1mWDHsbRcI7/Ug9nL2gWPTz/u0bzL9btM/AT7CDnKi+CiLlcjqrLGWT0b KasALzS/AfnrtXTqyNL2wdqkTZC6wrdjgiUswYQ1Yr065NZnHxrH/zR6RgOIA1ya p5A//ME3DiCQRLToYXM8KU8Rb/PW29n1GtefaiFyrrhXAg7ZPfR4y8n+AQTkgPUq 2Mcpz2nRod1e79YpgYm5+XpcTD7bgV7XZD8RH9uPKfpAW0W33QP0OFKG92RigTTW 6mJRvtus8S3VfaHatBupH/kQsnoyZXktZXRAdgWEa713zybXoGUzwvQICnJAUp5T sB2LxykMYyb8T862XbNzQtC+0cCDotY4ZZ2plIOlUrNomf37ZunQu5/uEecPf6s6 2MlVlzgTYTwG6lz5WxkZ6A2RTnx8rXvcr7jwo7wwVcjf9W2erTR18+tqU7bmtrol qh1V0XeufPewhKfCmSR+9yyP029AP4cwdRHNQNsg9oDQGzqYZxhHSKH1IMBt2PI1 Ozxlx/gjom3K5yCe1tWBIG0yzxnFvXJBHgGKimBFmYt4I8Eh2Uo= =q/1n -----END PGP SIGNATURE----- --gv6qjm3xh6s2jhl3-- --===============2899227572111656454== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2899227572111656454==--