From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
devel@driverdev.osuosl.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] staging: vchiq: stop explicitly comparing with zero to catch errors
Date: Thu, 9 May 2019 17:41:33 +0300 [thread overview]
Message-ID: <20190509144132.GF21059@kadam> (raw)
In-Reply-To: <20190509143137.31254-5-nsaenzjulienne@suse.de>
On Thu, May 09, 2019 at 04:31:36PM +0200, Nicolas Saenz Julienne wrote:
> The vchiq code tends to follow a coding pattern that's not accepted as
> per the Linux kernel coding style
>
> We have this:
> if (expression != 0)
>
> We want this:
> if (expression)
>
> We make an exception if the expression refers to a size, in which case
> it's accepted for the sake of clarity.
It's not really Linux kernel style, it's just my style... I wouldn't
have complained if the original code were consistent one way or the
other. But since I was encouraging you to pick a style and use it
consistently, then I'm always going to advocate my style... :P
Anyway, thanks! Looks good to me.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-09 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 14:31 [PATCH v3 0/4] staging: vchiq: use interruptible waits Nicolas Saenz Julienne
2019-05-09 14:31 ` [PATCH v3 1/4] staging: vchiq_2835_arm: revert "quit using custom down_interruptible()" Nicolas Saenz Julienne
2019-05-15 9:52 ` Stefan Wahren
2019-05-09 14:31 ` [PATCH v3 2/4] staging: vchiq: revert "switch to wait_for_completion_killable" Nicolas Saenz Julienne
2019-05-09 14:31 ` [PATCH v3 3/4] staging: vchiq: make wait events interruptible Nicolas Saenz Julienne
2019-05-09 14:31 ` [PATCH v3 4/4] staging: vchiq: stop explicitly comparing with zero to catch errors Nicolas Saenz Julienne
2019-05-09 14:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509144132.GF21059@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).