From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Yangtao Li <tiny.windzz@gmail.com>,
rui.zhang@intel.com, edubezval@gmail.com,
daniel.lezcano@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, wens@csie.org, catalin.marinas@arm.com,
will.deacon@arm.com, davem@davemloft.net,
mchehab+samsung@kernel.org, gregkh@linuxfoundation.org,
Jonathan.Cameron@huawei.com, nicolas.ferre@microchip.com,
paulmck@linux.ibm.com, andy.gross@linaro.org, olof@lixom.net,
bjorn.andersson@linaro.org, jagan@amarulasolutions.com,
marc.w.gonzalez@free.fr, stefan.wahren@i2se.com,
enric.balletbo@collabora.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] thermal: sun50i: add thermal driver for h6
Date: Mon, 13 May 2019 12:01:49 +0200 [thread overview]
Message-ID: <20190513100149.w3uvpnuqql4eqwid@flea> (raw)
In-Reply-To: <20190512223955.6lhclj6jr2akmsdx@core.my.home>
On Mon, May 13, 2019 at 12:39:55AM +0200, Ondřej Jirman wrote:
> > + /*
> > + * clkin = 24MHz
> > + * T acquire = clkin / (SUN50I_THS_CTRL0_T_ACQ + 1)
> > + * = 20us
> > + */
> > + regmap_write(tmdev->regmap, SUN50I_THS_CTRL0,
> > + SUN50I_THS_CTRL0_T_ACQ(479));
> > + /* average over 4 samples */
> > + regmap_write(tmdev->regmap, SUN50I_H6_THS_MFC,
> > + SUN50I_THS_FILTER_EN |
> > + SUN50I_THS_FILTER_TYPE(1));
> > + /* period = (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; ~10ms */
> > + regmap_write(tmdev->regmap, SUN50I_H6_THS_PC,
> > + SUN50I_H6_THS_PC_TEMP_PERIOD(58));
>
> Also this math is not all that clear:
>
> period = (SUN50I_H6_THS_PC_TEMP_PERIOD + 1) * 4096 / clkin; ~10ms
>
> SUN50I_H6_THS_PC_TEMP_PERIOD is a macro with an argument. So how does
> this work?
>
> Also, related to this, I've noticed that you removed the interrupt
> processing from the original driver. Without that you have to make sure
> that OF contains non-zero polling-delay and polling-delay-passive.
>
> Nonzero values are necessary for enabling polling mode of the tz core,
> otherwise tz core will not read values periodically from your driver.
>
> You should documment it in the DT bindings, too. Or keep the interrupt
> handling for THS.
If there's interrupts for this in the H6, yeah we should use them over
polling.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-13 10:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 8:26 [PATCH 0/3] add thermal driver for h6 Yangtao Li
2019-05-12 8:26 ` [PATCH 1/3] arm64: defconfig: add allwinner sid support Yangtao Li
2019-05-12 13:25 ` Maxime Ripard
2019-05-12 8:26 ` [PATCH 2/3] thermal: sun50i: add thermal driver for h6 Yangtao Li
2019-05-12 13:39 ` Maxime Ripard
2019-05-12 21:41 ` Ondřej Jirman
2019-05-16 15:02 ` Maxime Ripard
2019-05-16 17:36 ` Ondřej Jirman
2019-05-16 18:10 ` Frank Lee
2019-05-17 7:31 ` Maxime Ripard
2019-05-17 17:19 ` Frank Lee
2019-05-21 7:41 ` Maxime Ripard
2019-05-16 17:51 ` Frank Lee
2019-05-16 21:11 ` Ondřej Jirman
2019-05-17 7:36 ` Maxime Ripard
2019-05-17 17:27 ` Frank Lee
2019-05-21 8:05 ` Maxime Ripard
2019-05-21 10:27 ` Ondřej Jirman
2019-05-21 14:27 ` Maxime Ripard
2019-05-21 17:33 ` Ondřej Jirman
2019-05-17 19:21 ` Vasily Khoruzhick
2019-05-21 7:47 ` Maxime Ripard
2019-05-12 22:16 ` Ondřej Jirman
2019-05-16 18:06 ` Frank Lee
2019-05-16 18:29 ` Ondřej Jirman
2019-05-17 16:34 ` Frank Lee
2019-05-19 14:22 ` Ondřej Jirman
2019-05-20 10:59 ` Maxime Ripard
2019-05-25 18:48 ` Frank Lee
2019-05-25 18:51 ` Frank Lee
2019-05-25 19:53 ` Vasily Khoruzhick
2019-05-26 1:24 ` Ondřej Jirman
2019-05-12 22:39 ` Ondřej Jirman
2019-05-13 10:01 ` Maxime Ripard [this message]
2019-05-16 18:08 ` Frank Lee
2019-05-12 8:26 ` [PATCH 3/3] dt-bindings: thermal: add binding document for h6 thermal controller Yangtao Li
2019-05-12 13:41 ` Maxime Ripard
2019-05-16 18:13 ` Frank Lee
2019-05-17 7:38 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513100149.w3uvpnuqql4eqwid@flea \
--to=maxime.ripard@bootlin.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=stefan.wahren@i2se.com \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).