From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A5DC04AB1 for ; Mon, 13 May 2019 11:23:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B09721019 for ; Mon, 13 May 2019 11:23:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CPontiSn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lYx5uX8G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B09721019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0cdmOH8iWCCciUg9Y4xOi5+YmebUZm2sj2tvAbUw0UU=; b=CPontiSnPMjnfy ZqyHNSuLX/j5v0NA6M/RMyNr1wMlNDPjUhECEs87PcLUdpSGgdNrR/WdB1b1gtQ2ZpYXK0+/1dsGF AJJ10oeDZ7SZDq5ki/ewVGwD2rdhPh7GFiYsToVn3YbH0EEYgRI11wO+U8W02k8aqpz1PZmCf/dDP e1JguzjTBm+imsI88mt+yhc4tgiogvw9hnyBgew/cqH8wiSELJevsJmc56NF72ubjjliXdz/OG+oI rIVyaEWh9MCt9m9fcgDm0uPpsCQPqkorjcVT8wAc09BU+P8Pt9uBXb3cmMnvqDO61XEdHd0QHb7to 5rhwtKl4Ve6j6N4cdcXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQ93B-0006V5-NR; Mon, 13 May 2019 11:23:21 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQ8wS-0002he-RB for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2019 11:16:28 +0000 Received: by mail-pf1-x444.google.com with SMTP id s11so7022289pfm.12 for ; Mon, 13 May 2019 04:16:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oFByEbvx0K0vUEmpridgEL3WB0Mqr95aZWBmFa6AoEc=; b=lYx5uX8GQz613TmhuSeygH/Ql/n+2mxhb8yT5PSbJ5MZPA1zY6vdI5MnerYDnlfWAT 2xDf6oeTYFVoyUBjF4iuqmkSfMMixFRd8St2kQcriwufSOC1Lg0uUiTxPCUu67vewBaG z1xaDs0HvdtlWMjt9aYXOfblgMYGoJSavVXdaw4vWs6NZdf4UYsLxt7DCHebWbQThBdz 9NtZFRAIlJmXmInswA9yks9uCOFzCuHKZY2U7uJQiS2dKTBOWGjxitnEIJ2wAJkr6NdO a4OyImHegJNSbuYvNBSBmn2MHk6YxITl2n2+MFssnOrwLsb6rCEWm8WEZJQJJjwiVm4U v2ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oFByEbvx0K0vUEmpridgEL3WB0Mqr95aZWBmFa6AoEc=; b=QtX5v8TCAV8jv4QqPiZ4kPMol2aIBy4v4P1zXm/k2HEMe8Tl+3/aBS16C572bNFgYq MBKPKcbqQ4wCC2/+G+nQcaLtVZI56sEVsfaZ09bw+tYNRhu0+gY0jNsIAgPvQw9CecZI aBH4Rgum+ndAdBL3q/KWZ8c6h2Xy/rIFmHYTvHVClQApvd8yuKZKLq1YuOYuIwfNYLeW NFacMd4HLgidtiWUx0522IZ7Se4R10Ko139JIQ225RASJURk5Iw/QHCBUB7hex6nzYT+ SNk8tWkqFbq/3FDzltc/LMuRPgWbLzSDzZ5FfwmAEKv8YMEF+F7AEVY7VcM5hc8cyE8u fHqQ== X-Gm-Message-State: APjAAAWxNJsCkN1ZYIetnVc0y9lzAiRseqYxH/KxrkgcECw02yi23agi oBPhmU3J6CNjNpdbQ1HFMZnNjg== X-Google-Smtp-Source: APXvYqybV7ctvoQrhOaqarWeLgyyYWhXVjugny4Y3niXs9XiAKI7OA65GEFEPn6hg6KWKgQXRW3GXA== X-Received: by 2002:a62:2805:: with SMTP id o5mr32148800pfo.256.1557746183430; Mon, 13 May 2019 04:16:23 -0700 (PDT) Received: from leoy-ThinkPad-X240s (li253-4.members.linode.com. [173.255.243.4]) by smtp.gmail.com with ESMTPSA id e24sm1409636pgl.94.2019.05.13.04.16.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 04:16:22 -0700 (PDT) Date: Mon, 13 May 2019 19:16:15 +0800 From: Leo Yan To: Suzuki K Poulose Subject: Re: [PATCH 5/5] docs: coresight: Document snapshot mode Message-ID: <20190513111615.GA32010@leoy-ThinkPad-X240s> References: <20190501175052.29667-1-mathieu.poirier@linaro.org> <20190501175052.29667-6-mathieu.poirier@linaro.org> <20190511073229.GA18064@leoy-ThinkPad-X240s> <77e437ed-99b2-670e-7e29-33be584f2bd0@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <77e437ed-99b2-670e-7e29-33be584f2bd0@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_041627_350769_C035F4EC X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mathieu.poirier@linaro.org, corbet@lwn.net, alexander.shishkin@linux.intel.com, coresight@lists.linaro.org, acme@kernel.org, peterz@infradead.org, mingo@redhat.com, Mike.leach@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suzuki, On Mon, May 13, 2019 at 09:37:01AM +0100, Suzuki K Poulose wrote: > Hi, > > On 11/05/2019 08:32, Leo Yan wrote: > > On Wed, May 01, 2019 at 11:50:52AM -0600, Mathieu Poirier wrote: > > > > [...] > > > > > +2.2) Snapshot mode: > > > + > > > +Using perf's built-in snapshot mode with CoreSight tracers is supported - to > > > +do so the '-S' command line option needs to be specified. Since current sink > > > +devices are used in double-buffer mode when operated from the perf interface, > > > +the size of the perf ring buffer needs to be adjusted to match the size of the > > > +buffer used by the CoreSight sinks. From the perf command line it is possible > > > +to specify the number of pages to use for a session using the '-m,X' option, > > > +where X is the amount of pages. > > > + > > > +The system memory buffer used by ETR devices is automatically adjusted > > > +to match the size of the perf ring buffer and as such does not need to be > > > +modified on the perf command line. For ETB and ETF devices the perf ring > > > +buffer size need to be adjusted to match the size of the internal buffer. > > > + > > > +The following examples assume a system page size of 4096 byte: > > > + > > > + # cat /sys/bus/coresight/devices/20010000.etb/mgmt/rdp > > > + 0x2000 > > > + # perf record -e cs_etm/@20010000.etf/ -S -m,8 --per-thread $APP > > > > In this case it shows the usage for etb, thus should: > > s/20010000.etf/20010000.etb/ > > > > BTW, the user needs to convert the rdp to byte size with multiplying 4, > > it's good to explain for this in the doc or give related info in the > > driver warning log. > > If at all we want to match the aux space size with that of the device buffer, > I recommend exposing this via a new "buf_pages" attribute under the sysfs to > help the user. Agree, I also saw you suggested in another email. Using "buf_pages" is directive and consistent for different sink devices. Thanks, Leo Yan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel