From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A84AC04AB4 for ; Tue, 14 May 2019 14:20:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CFD0D208CA for ; Tue, 14 May 2019 14:20:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EwmHKxV1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFD0D208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5V4lqsg6FTrBIbMxsQFGhqcHeU2N8Y47T2xrHmfEYS4=; b=EwmHKxV1+ScecO xblufylEOtG+i2lobkmzRfNkDfevG3sIcLVbOR0kf+fNDFjjbgR5dKhrb+uMB2G61itiHmB8E9AsF SDhsU59Z13tH4NhuLS4A5AderY4JRqE8IzL3+hmN8VK4GOst8MlgLHzsZb7Qs9iMOWM0DYpGWYgRB WO2jNrU5wp1752iBQU5AJoyIp45RkgyHtfqj8yeCKTvrkJCHU/zN6LR4wh/YH+zXNi3q37UrbTifG 3qTFx7HhT046S22y3Wp/EWzoJGy5wRr+BGZzSvKUO9dGbW5jbGaXekVNQrlIaJy0xg/hchXFhJ+Jt 7N3/dAzzrxeaU6L7VwIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQYHf-0001cw-Ja; Tue, 14 May 2019 14:19:59 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQYHc-0001cU-PJ for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2019 14:19:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE7A7374; Tue, 14 May 2019 07:19:55 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2E98B3F703; Tue, 14 May 2019 07:19:53 -0700 (PDT) Date: Tue, 14 May 2019 15:19:51 +0100 From: Quentin Perret To: Eduardo Valentin Subject: Re: [PATCH v3 3/3] thermal: cpu_cooling: Migrate to using the EM framework Message-ID: <20190514141949.352gjengdyg67w7s@queper01-lin> References: <20190503094409.3499-1-quentin.perret@arm.com> <20190503094409.3499-4-quentin.perret@arm.com> <20190514034056.GA5621@localhost.localdomain> <20190514071506.ykjg67elsydaehlz@queper01-ThinkPad-T460s> <20190514141736.GB16968@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190514141736.GB16968@localhost.localdomain> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190514_071956_828442_5B440C72 X-CRM114-Status: GOOD ( 23.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org, amit.kachhap@gmail.com, daniel.lezcano@linaro.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, will.deacon@arm.com, mka@chromium.org, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tuesday 14 May 2019 at 07:17:37 (-0700), Eduardo Valentin wrote: > Hey Quentin, > > On Tue, May 14, 2019 at 08:15:08AM +0100, Quentin Perret wrote: > > Hi Eduardo, > > > > On Monday 13 May 2019 at 20:40:59 (-0700), Eduardo Valentin wrote: > > > On Fri, May 03, 2019 at 10:44:09AM +0100, Quentin Perret wrote: > > > > The newly introduced Energy Model framework manages power cost tables in > > > > a generic way. Moreover, it supports a several types of models since the > > > > tables can come from DT or firmware (through SCMI) for example. On the > > > > other hand, the cpu_cooling subsystem manages its own power cost tables > > > > using only DT data. > > > > > > > > In order to avoid the duplication of data in the kernel, and in order to > > > > enable IPA with EMs coming from more than just DT, remove the private > > > > tables from cpu_cooling.c and migrate it to using the centralized EM > > > > framework. > > > > > > > > The case where the thermal subsystem is used without an Energy Model > > > > (cpufreq_cooling_ops) is handled by looking directly at CPUFreq's > > > > frequency table which is already a dependency for cpu_cooling.c anyway. > > > > Since the thermal framework expects the cooling states in a particular > > > > order, bail out whenever the CPUFreq table is unsorted, since that is > > > > fairly uncommon in general, and there are currently no users of > > > > cpu_cooling for this use-case. > > > > > > Will this break DT in any way? After this change, are the existing DTs > > > still compatible with this cpu cooling? > > > > Yes, all existing DTs stay compatible with this CPU cooling. The EM can > > still be built using the 'dynamic-power-coefficient' DT property thanks > > to the recently introduced dev_pm_opp_of_register_em() helper, see > > a4f342b9607d ("PM / OPP: Introduce a power estimation helper"). And all > > relevant cpufreq drivers have already been updated to use that function. > > I see.. > > > > > So, this patch should cause no functional change for all existing users. > > It's really just plumbing. I can probably explain that better in this > > commit message rather than the cover letter if you feel it is necessary. > > > > Yes I would prefer if this info goes into the commit message. No problem, will do in v4. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel