From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57A5C04AB7 for ; Tue, 14 May 2019 20:20:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EF9820879 for ; Tue, 14 May 2019 20:20:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NT5QupM/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EF9820879 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=37BdzeTcGnjNL5haCX3ZmqIKzGBhhmD8GdiLwyeSSLs=; b=NT5QupM/cbSyzD 0afIHIdjwL/WoYQGetyfisYGKKa966DnqbimpuLQMJdjr2DhaC+uwRfNCTImfGaH7JekKBeyfn1/r 5ZBcTUMmy6LuC0B9b1l2Z1N+Ftrwc3gwpLb5iu7yd7TdnIZL0pVGTvRM+LkJ37DiIMDHOGxNtvVF7 XQEI3OzvnoOB55RAqLYkp26j2vLIHmzvyjc93So5asg7Att7HJiOzKljxJDJhUSMNYhKpeSldPclT Fz4kc793G7deBBVvOetPZvRopXaXvSUKht+w/eyrDgPzwhcbz3/ggb/Fvc/iiwHEbt6G95Ao1/Fw+ HrGqePH0Yzczk8KvGA8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQduB-0004Tw-RG; Tue, 14 May 2019 20:20:07 +0000 Received: from mail-it1-f196.google.com ([209.85.166.196]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQdu6-0003qL-0H for linux-arm-kernel@lists.infradead.org; Tue, 14 May 2019 20:20:03 +0000 Received: by mail-it1-f196.google.com with SMTP id 9so907192itf.4 for ; Tue, 14 May 2019 13:19:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lK8c734xh5U5PM3ABKp/9nxVkeJ2kE5gY87Z6hnyLjY=; b=FT3WofKqcUXIiQtDsUk4hUyFU86VdKhIoUTQ633lmV6H1WTGrgZv2RWR2L+vqVgzni 8yaxMP2s7qDa0Xzc1OB4S3luoaY7OxvxZFJn4Z4+iC9LHFKcwsFgjrR8P7t4A/kTkBNu X5o9d4uKw5fSt88TCGD+Qh23mzgO4R0Yd07mgCEgN0iWxtJLlZc86w6wcsjxpmsr/1Xa MgWDASVlRF8b0FdQqspRV+KA9VEZTrJWaeSVFp+jIBFzxmOKrLTpscOhh+KvnMFOIDQl /sqypWqOI3ZzLr9/yNalCNqBtq/FSG9ZPOvBBGp7EVIwlrpGR1HMnF482rs++wzc8jG+ lqQQ== X-Gm-Message-State: APjAAAWuDEIaGaDJ6SvLdTy9dRH3vzKpVFzY4Epd2iJBxU6MMHdxyier qpsTCDDqBo/lhMB0oOu6+NjfPQ== X-Google-Smtp-Source: APXvYqw5Ieb4O+HXGg5FGMOQuh00DKqk4E7AnX5MHmnns5jJT4DhWDpnXg9aD82Klnzt0ms9U6gjAw== X-Received: by 2002:a02:c4c6:: with SMTP id h6mr25419071jaj.33.1557865198005; Tue, 14 May 2019 13:19:58 -0700 (PDT) Received: from chromium.org ([2620:15c:183:0:92f:a80a:519d:f777]) by smtp.gmail.com with ESMTPSA id m189sm25150itm.21.2019.05.14.13.19.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 14 May 2019 13:19:57 -0700 (PDT) Date: Tue, 14 May 2019 14:19:52 -0600 From: Drew Davenport To: Louis Kuo Subject: Re: [RFC PATCH V2 0/4] media: support Mediatek sensor interface driver Message-ID: <20190514201952.GA107202@chromium.org> References: <20190512060005.5444-1-louis.kuo@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190512060005.5444-1-louis.kuo@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190514_132002_123796_62CD93AD X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, keiichiw@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Louis, On Sun, May 12, 2019 at 02:00:01PM +0800, Louis Kuo wrote: > Hello, > > This is the RFC patch adding Sensor Inferface(seninf) driver on > Mediatek mt8183 SoC, which will be used in camera features on CrOS application. > It belongs to the first Mediatek's camera driver series based on V4L2 and media controller framework. > I posted the main part of the seninf driver as RFC to discuss first and would like some review comments > on the overall structure of the driver. > > The driver is implemented with V4L2 framework. > 1. Register as a V4L2 sub-device. > 2. Only one entity with sink pads linked to camera sensors for choosing desired camera sensor by setup link > and with source pads linked to cam-io for routing different types of decoded packet datas to PASS1 driver > to generate sensor image frame and meta-data. > > The overall file structure of the seninf driver is as following: > > * mtk_seninf.c: Implement software and HW control flow of seninf driver. > * mtk_seninf_def.h: Define data structure and enumeration. > * mtk_seninf_reg.h: Define HW register R/W macros and HW register names. > > [ v2: use recommended coding style, fix v4l2-compliance issue, add v4l2 async notifier operations, remove redundant code] Thanks for the style fixes. I made a number of review comments on V1 of the driver patch. Please take a look at those if you haven't already. > > media: platform: mtk-isp: Add Mediatek sensor interface driver > media: platform: Add Mediatek sensor interface driver KConfig > dt-bindings: mt8183: Add sensor interface dt-bindings > dts: arm64: mt8183: Add sensor interface nodes > > .../bindings/media/mediatek-seninf.txt | 52 + > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 34 + > drivers/media/platform/Makefile | 2 + > drivers/media/platform/mtk-isp/Kconfig | 16 + > drivers/media/platform/mtk-isp/Makefile | 14 + > .../media/platform/mtk-isp/isp_50/Makefile | 17 + > .../platform/mtk-isp/isp_50/seninf/Makefile | 4 + > .../mtk-isp/isp_50/seninf/mtk_seninf.c | 1366 +++++++++++++++++ > .../mtk-isp/isp_50/seninf/mtk_seninf_def.h | 170 ++ > .../mtk-isp/isp_50/seninf/mtk_seninf_reg.h | 992 ++++++++++++ > 10 files changed, 2667 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek-seninf.txt > create mode 100644 drivers/media/platform/mtk-isp/Kconfig > create mode 100644 drivers/media/platform/mtk-isp/Makefile > create mode 100644 drivers/media/platform/mtk-isp/isp_50/Makefile > create mode 100644 drivers/media/platform/mtk-isp/isp_50/seninf/Makefile > create mode 100644 drivers/media/platform/mtk-isp/isp_50/seninf/mtk_seninf.c > create mode 100644 drivers/media/platform/mtk-isp/isp_50/seninf/mtk_seninf_def.h > create mode 100644 drivers/media/platform/mtk-isp/isp_50/seninf/mtk_seninf_reg.h > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel