From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC45C04E53 for ; Wed, 15 May 2019 09:17:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D42692084A for ; Wed, 15 May 2019 09:17:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kNuyivBu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D42692084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R4YcU8KJPJ4xQh0G4aBr35Ut/9a76JGjc4rDrNqlQWE=; b=kNuyivBu8GURGO NbnlALKGKEdeVIm55IixnTG3GMlJ76VucQRIsCHfBcMkoDGhbdPNjr2p7b9lfKEdjYEMPXmXcoxXZ R1Zg8i0VKUprCtIAxt/7bw0rMePfTtjcyTkbJqCrX7BjeabuwfrkZJIRvSmypPgISDmmg54DWqnJ9 WLFuQANFVdlmUEFQqtKKti6Q2AFM3lxnzSIwXQ6RkuVfFIJNpRjhje5gCeYp8q0G0W5ypqGDR/4W3 GYpssoRTM5sRCpID39TW79rRzbxadTHSBUAEBuCl/Ty414L/hPhkh4OvFQu3NBy6/gBdBNXrV96US 9309Ya7D1Z/CbNzHQzCQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQq2B-0006WK-SD; Wed, 15 May 2019 09:17:11 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQq26-0006VG-Da for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2019 09:17:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B06D341; Wed, 15 May 2019 02:17:05 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BA3A53F703; Wed, 15 May 2019 02:17:02 -0700 (PDT) Date: Wed, 15 May 2019 10:17:01 +0100 From: Quentin Perret To: Daniel Lezcano Subject: Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct Message-ID: <20190515091658.sbpg6qiovhtblqyr@queper01-lin> References: <20190515082318.7993-1-quentin.perret@arm.com> <20190515082318.7993-3-quentin.perret@arm.com> <0ced18eb-e424-fe6b-b11e-165a3c108170@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0ced18eb-e424-fe6b-b11e-165a3c108170@linaro.org> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190515_021706_462250_63E9F22A X-CRM114-Status: GOOD ( 19.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, viresh.kumar@linaro.org, amit.kachhap@gmail.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, will.deacon@arm.com, edubezval@gmail.com, mka@chromium.org, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Wednesday 15 May 2019 at 11:06:18 (+0200), Daniel Lezcano wrote: > On 15/05/2019 10:23, Quentin Perret wrote: > > In the current state, the perf_domain struct is fully defined only when > > CONFIG_ENERGY_MODEL=y. Since we need to write code that compiles both > > with or without that option in the thermal framework, make sure to > > actually define the struct regardless of the config option. That allows > > to avoid using stubbed accessor functions all the time in code paths > > that use the EM. > > > > Acked-by: Viresh Kumar > > Signed-off-by: Quentin Perret > > This patch implies the cpu cooling device can be set without the energy > model. > > Isn't it possible to make a strong dependency for the cpu cooling device > on the energy model option, add the energy model as default on arm arch > and drop this patch? Right, that should work too. > After all, the cpu cooling is using the em framework. The reason I did it that way is simply to keep things flexible. If you don't compile in THERMAL_GOV_POWER_ALLOCATOR, you will never use the EM for CPU thermal. So I thought it would be good to not mandate compiling in ENERGY_MODEL in this case -- that should save a bit of space. But TBH I don't have a strong opinion on this one, so if everybody agrees it's fine to just make CPU_THERMAL depend on ENERGY_MODEL, I'm happy to drop this patch and fix patch 3/3. That would indeed simplify things a bit. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel