From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A759C04E53 for ; Wed, 15 May 2019 10:57:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B65E20843 for ; Wed, 15 May 2019 10:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VdcKGVvn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B65E20843 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LK+q1ha2OS5JGMJwokL7qgKDGLiEvGV+EP6AF9Roy8I=; b=VdcKGVvnaDqBxu skZ8TbE2o1PdmG1Ik0D/Anh7JsOeZgbB3nzvQkudM0pNcqB7Ht7TsH0v27+P450poJn3xJlTlKudJ R6OBc9gKnNZll0mtTh6lxNe5OalbgLnC3yqf8xtKrhpBwRN8VgxVPClGVCkTnddgFpIx1eu3l3Uer nskX6/GSF34xyR590WHblaV0wZOMRoXvfzpOg5zOSOdUR2tBUBC4QQoiMez/XFXccRzq4Rsde1PIV pYnlPHge5BEOWyNI/0+P+Jt68mi3ptIrYmJI+clhg8N4MRe6qEplqfOcIhFiNFLKRxAlbrZH3uB8A 7vukhs8BC8PE2TB1WotQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQrbJ-0007ni-H2; Wed, 15 May 2019 10:57:33 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQrbG-0007ms-3l for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2019 10:57:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 543A580D; Wed, 15 May 2019 03:57:28 -0700 (PDT) Received: from queper01-lin (queper01-lin.cambridge.arm.com [10.1.195.48]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C83613F703; Wed, 15 May 2019 03:57:25 -0700 (PDT) Date: Wed, 15 May 2019 11:57:24 +0100 From: Quentin Perret To: Daniel Lezcano Subject: Re: [PATCH v4 2/3] PM / EM: Expose perf domain struct Message-ID: <20190515105723.3ltui3l75hbuskmk@queper01-lin> References: <20190515082318.7993-1-quentin.perret@arm.com> <20190515082318.7993-3-quentin.perret@arm.com> <0ced18eb-e424-fe6b-b11e-165a3c108170@linaro.org> <20190515091658.sbpg6qiovhtblqyr@queper01-lin> <698400c0-e0a4-4a86-b9df-cdb9bd683c0f@linaro.org> <20190515100748.q3t4kt72h2akdpcs@queper01-lin> <20190515102200.s6uq63qnwea6xtpl@vireshk-i7> <20190515104043.vogspxgkapp6qsny@queper01-lin> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190515_035730_161103_59013366 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Viresh Kumar , amit.kachhap@gmail.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, will.deacon@arm.com, edubezval@gmail.com, mka@chromium.org, catalin.marinas@arm.com, rui.zhang@intel.com, javi.merino@kernel.org, ionela.voinescu@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wednesday 15 May 2019 at 12:54:10 (+0200), Daniel Lezcano wrote: > On 15/05/2019 12:40, Quentin Perret wrote: > > On Wednesday 15 May 2019 at 15:52:00 (+0530), Viresh Kumar wrote: > >> On 15-05-19, 12:16, Daniel Lezcano wrote: > >>> Viresh what do you think ? > >> > >> I agree with your last suggestions. They do make sense. > > > > Good :-) > > > > So, FWIW, the below compiles w/ or w/o THERMAL_GOV_POWER_ALLOCATOR. I'll > > test it and clean it up some more and put it as patch 1 in the series if > > that's OK. > > > > Thanks, > > Quentin > > > > > > diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c > > index f7c1f49ec87f..ee431848ef71 100644 > > --- a/drivers/thermal/cpu_cooling.c > > +++ b/drivers/thermal/cpu_cooling.c > > @@ -58,7 +58,9 @@ > > */ > > struct freq_table { > > u32 frequency; > > I suspect we will have a problem here as cpufreq_set_cur_state uses the > frequency and when switching to EM, we will still need a freq table. Indeed, I'll need a bit of ifdefery in the get_state_freq() function introduced in patch 3, but nothing too horrible I hope. Thanks, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel