From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DBBC04E53 for ; Wed, 15 May 2019 21:37:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40EFA2084F for ; Wed, 15 May 2019 21:37:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VMleRb8H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="EvIBHM9M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40EFA2084F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jQ7m9MvxletpqkzzhN5fKf1uOFzV2y8Da2qPEkyw7Fk=; b=VMleRb8HKQbug0 AEJjR3Cq8vidd/XFZ9av3EPIme+/waa9gUFOBlwK2VMz/dO2ZH36/A+WRe5u+QmJ0qBXQLYmOjgB8 i0Fat2t+uYw0VLq3eNIoA2fQVhoRYl00rmgljTWyP6WLtiO+weKPmr32Im0AfZ1XB9hE0VCcgRCPP oarnys9p5Ah+HGCvc16MBOrGTjneKw9G8TNjfdN/qr0Sh1qqDIXZcakiGg0f5APq6psvZeytBrT+w GHl1NHNQxO4gRZBrMOqTIlSkrxsU/mGcKBy+j1zQvpWpM89TfwZMAlGVG4qL0uRfR8z5vVOvfxzTl tIKy2W2QIJR079ekIYKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hR1aH-0007W8-0P; Wed, 15 May 2019 21:37:09 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hR1aD-0007V6-OQ for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2019 21:37:07 +0000 Received: by mail-pl1-x642.google.com with SMTP id w7so503161plz.1 for ; Wed, 15 May 2019 14:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sAyYd7Pec4gg4Zl5/b6GbJ3Lhmz83i6aehOb2aZw1ro=; b=EvIBHM9Mo9vFpQUMxFf658yZkkY5dVan5FwYFk7XQjrefRysWBk3ZQvleVivTl8WEg yGsgkIci+3QXrOpBs7AluJ54pjlX/BMGjRs+gz/YpHjrgdJbHhmsF1dmVSNbGhtgchVi U/adQE+kIwDBIDEQnhjnkHhI0yBiCEF8Y+GLQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sAyYd7Pec4gg4Zl5/b6GbJ3Lhmz83i6aehOb2aZw1ro=; b=o2ZlerYGaWF0sSMPIDA0JHZEwsLWX648ZuUp7xubIDH91L+ixKuyrad57GBVELsyUZ ygGT4pbkLjmtg13lSxbQn3jr4xtHJsb9G5VWEJZ3vOqqwglqbrtnsU+yD/0W0jNHjJbC BbYADmOWJ76qofkXsFGlKrnPq/SpFjdHqJbjAEd9pOa71dHrAofL35qTO1D72x4EKGsx bu8au2CzCYhkY0qiYnvPt4r1/lWTMaPjy0W/OCouwfdRL5r7YDh9fA84Wx/J0CLV7x8k Qq4FwZYjJoHQTwXpQzQjPQRzf8cLm/k6KW1KVd+CriqYXZknUPkCVKNNL6pGwNocRhy4 6S8g== X-Gm-Message-State: APjAAAVbQZ2HwgO4BHArNYrSmrJfF4/Ds+qC0uZRjiVmymlO1iPFMBNN g7lZsTgqjHNKiW6KdvjNqxGGSQ== X-Google-Smtp-Source: APXvYqxyhkmCbMue4Dl52l51XVW4EiT6xf/ZY+zI2fdisxugkpbOQnjZfg8mMjHbUnr9gGPnm0w9QQ== X-Received: by 2002:a17:902:b58f:: with SMTP id a15mr2363024pls.201.1557956224865; Wed, 15 May 2019 14:37:04 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id f29sm8844632pfq.11.2019.05.15.14.37.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 May 2019 14:37:03 -0700 (PDT) Date: Wed, 15 May 2019 14:37:03 -0700 From: Matthias Kaehlcke To: Doug Anderson Subject: Re: [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Message-ID: <20190515213703.GE40515@google.com> References: <20190515153127.24626-1-mka@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190515_143705_823947_1588C11C X-CRM114-Status: GOOD ( 21.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , LKML , "open list:ARM/Rockchip SoC..." , Rob Herring , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Doug, thanks for the review! On Wed, May 15, 2019 at 11:30:24AM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke wrote: > > > This value matches what is used by the downstream Chrome OS 3.14 > > kernel, the 'official' kernel for veyron devices. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > > index 1252522392c7..169da06e1c09 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > > @@ -446,6 +446,14 @@ > > status = "okay"; > > }; > > > > +&gpu_thermal { > > + trips { > > + gpu_alert0: gpu_alert0 { > > + temperature = <72500>; /* millicelsius */ > > + }; > > + }; > > +}; > > + > > This should be sorted alphabetically. Thus this should sort right > after this in rk3288-veyron.dtsi > > &gpu { > mali-supply = <&vdd_gpu>; > status = "okay"; > }; will do in the next revision. > Also you don't need to replicate the whole structure? I think the > above should just be: > > &gpu_alert0 { > temperature = <72500>; /* millicelsius */ > }; ack > NOTE also that that gpu and cpu critical is 100 C downstream. Should > we do that too? I missed this delta, yes let's do this too in this series. > Ah, but before we do that I guess we'd need to also override the > "rockchip,hw-tshut-temp" to 125000 to match downstream. I guess that > could be a separate series? Yes, the value should at least be higher than the critical trip point, matching downstream seems to make sense. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel