From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11B0C04AAF for ; Fri, 17 May 2019 01:33:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 80CDB2082E for ; Fri, 17 May 2019 01:33:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ndJg/v2M"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bjgfPT1O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80CDB2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uZnibrzduvofWNFW9N0ATyDiFObWY6MjgLIDObsXpA=; b=ndJg/v2MyfpCKS f1tYasS1atO4zEDvmoSjqh26mttPFpMTOya/k5l+v5pa3Q2rIMuqal9gfhXhVvmswR57hqCq4WeAN 4FaNvFTeCjAriIvLId//8jIVWZBVUpqHmyUiOZCeh8orBPszZ+y3fkXc8pHgsQZopiGlX0EBEPMHU kgMhc2pRAVF3qJtu9vF/niCUWJN/wXFiwZ/mDICLxnu14tiyiz2/nk409Avh+J96YPPVPh4cytvRa BNzIpnweRiawPdcxLTAk5KdDzbiasIOMaG6s3TaTK569IpxT0JRxSXneOJPSUTGcFEgrTsFSASquf g9Q5nKzi8RfOfULyfCXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRRke-0004aY-MU; Fri, 17 May 2019 01:33:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRRkb-0004a6-QO for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2019 01:33:35 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4C852082E; Fri, 17 May 2019 01:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558056813; bh=O9wozGMr07+YQDGYWozdnjJCI45Cd9hl7O38n5vxJAg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bjgfPT1OPC6BXdfEPnRA/CwehJ3luuGfQMgu+pGQWUhR/qzb7vj0LRY0VPg+SBS32 RgQBgEJfnoaukkB0dQYeHZanp16JKUynTyPqRFboQM9ND+X11fyBKZ0UOw7JbEfiER hs1tDcMS+pPF+EhbCRc4/Bn+EbRA968XpswC3AZg= Date: Fri, 17 May 2019 09:32:53 +0800 From: Shawn Guo To: Ran Wang Subject: Re: [PATCH] arm64: dts: ls1028a: Fix CPU idle fail. Message-ID: <20190517013252.GV15856@dragon> References: <20190507074454.41589-1-ran.wang_1@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507074454.41589-1-ran.wang_1@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190516_183333_866848_F14F3358 X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Leo Li , Rob Herring , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2019 at 07:43:37AM +0000, Ran Wang wrote: > PSCI spec define 1st parameter's bit 16 of function CPU_SUSPEND to > indicate CPU State Type: 0 for standby, 1 for power down. In this > case, we want to select standby for CPU idle feature. But current > setting wrongly select power down and cause CPU SUSPEND fail every > time. Need this fix. > > Signed-off-by: Ran Wang Do we need a Fixes tag for this? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index b045812..bf7f845 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -28,7 +28,7 @@ > enable-method = "psci"; > clocks = <&clockgen 1 0>; > next-level-cache = <&l2>; > - cpu-idle-states = <&CPU_PH20>; > + cpu-idle-states = <&CPU_PW20>; > }; > > cpu1: cpu@1 { > @@ -38,7 +38,7 @@ > enable-method = "psci"; > clocks = <&clockgen 1 0>; > next-level-cache = <&l2>; > - cpu-idle-states = <&CPU_PH20>; > + cpu-idle-states = <&CPU_PW20>; > }; > > l2: l2-cache { > @@ -53,13 +53,13 @@ > */ > entry-method = "arm,psci"; > > - CPU_PH20: cpu-ph20 { > - compatible = "arm,idle-state"; > - idle-state-name = "PH20"; > - arm,psci-suspend-param = <0x00010000>; > - entry-latency-us = <1000>; > - exit-latency-us = <1000>; > - min-residency-us = <3000>; > + CPU_PW20: cpu-pw20 { > + compatible = "arm,idle-state"; > + idle-state-name = "PW20"; > + arm,psci-suspend-param = <0x0>; > + entry-latency-us = <2000>; > + exit-latency-us = <2000>; > + min-residency-us = <6000>; > }; > }; > > -- > 1.7.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel