From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5428DC04AAF for ; Fri, 17 May 2019 02:11:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 189192082E for ; Fri, 17 May 2019 02:11:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IPxcwUUp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fAz0fNHe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 189192082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VtXwC3s/50QFALyMNM7wdt7AUGLCqrqvyfkpkjhdv84=; b=IPxcwUUpejEqFc ZZzt06UFTutgvbFRvL0EOXfj6zjlhaWy+IsVtFJ1LJxv5Huqlm3jInePeAz7i3C0/A0wYkTSzc8iz qLskfXxT+Q+XqnueVoGTdsKxU69cmjlyDOpUtImN8I8T4m/IEAFeOAHJVEAku+EFpeSdbu1Zd+0nK 13J/tv01TZrm4ptwGjMvCgfOQfWNL7rUYzLB1sCo9SzdevJ65UNu8S5fFqmkzI0SauM1J5rAd9Hgk C2qLmO3oAx/7bga3AGQ9Dzou/UHWT6OKVWnOEakwdh7axgS4AjdznnTtDdaVsyLmoe1ozsZRbM+Mf IGaoWGEODY8WfBnI65gQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRSLP-0001PX-Tc; Fri, 17 May 2019 02:11:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRSLM-0001PB-NG for linux-arm-kernel@lists.infradead.org; Fri, 17 May 2019 02:11:33 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 068752082E; Fri, 17 May 2019 02:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558059092; bh=L9gJDk5SmlO1Bjp81hnl855ONnNEMGWCYhhypjgHXmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fAz0fNHe5dnd4aoxP7ra/g7ObfoBZi3UgnTGjMsqpI0M0LkM+Xvra0hBSlbhPnmT1 FcWJ/7iih/uZiogrwPeZOE2V0cr1ZYDgC1igYQ99sgmeG6hTJtmMb1rMjN7cts0lmm FE/4qhHUBZO/XJoqg4UfiOIaTb5BI+Vdmlc/1DQc= Date: Fri, 17 May 2019 10:10:51 +0800 From: Shawn Guo To: Ran Wang Subject: Re: [PATCH v3] arm64: dts: ls1028a: Add USB dt nodes Message-ID: <20190517021050.GW15856@dragon> References: <20190508064814.14223-1-ran.wang_1@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190508064814.14223-1-ran.wang_1@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190516_191132_781722_B623164F X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Rob Herring , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Leo Li Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 08, 2019 at 06:46:37AM +0000, Ran Wang wrote: > This patch adds USB dt nodes for LS1028A. > > Signed-off-by: Ran Wang > --- > Changes in v3: > - Add space between label and node name. > - Add spcae with properties and '='. > - Add SoC specific compatible. > > Changes in v2: > - Rename node from usb3@... to usb@... to meet DTSpec > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 8dd3501..19519df 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -144,6 +144,26 @@ > clocks = <&sysclk>; > }; > > + usb0: usb@3100000 { Please sort the nodes with unit-address in the address. That said, it should go after watchdog@23c0000. > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3100000 0x0 0x10000>; > + interrupts = <0 80 0x4>; interrupts = ; Shawn > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > + usb1: usb@3110000 { > + compatible = "fsl,ls1028a-dwc3", "snps,dwc3"; > + reg = <0x0 0x3110000 0x0 0x10000>; > + interrupts = <0 81 0x4>; > + dr_mode = "host"; > + snps,dis_rxdet_inp3_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; > + }; > + > i2c0: i2c@2000000 { > compatible = "fsl,vf610-i2c"; > #address-cells = <1>; > -- > 1.7.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel