From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D62C04AAF for ; Mon, 20 May 2019 09:25:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACF3520675 for ; Mon, 20 May 2019 09:25:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ki/lyAOn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACF3520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dzCsTIq4taZEzQ5ST2fvQSAVzS8GulxH8Mwn0tnKf2A=; b=ki/lyAOnpax61rd81/WtNJW4v KMlSm1cKpODJo3R3JgFH5rMdQqjgsxEBlAd5LIatWEfyN7biMhePnoMVBzTelTfAjR7nj790osmcS nMv1z3O8+6tf9FGPbB8+N7CHjTMts/HAh30Yfm+Au17FahqRmlV2DONDdmMDCtZtct2VG4YK1pKLF nsKlJrYyKXLV17dCwvFiHOtF60L0DHZmLZm0LLxYzDyIH8E98r6/hfY2GyE2xU9g2BMw+fXm2y+Qi 81shAyF6CN00G8EabHMAo0aJ+PfGVQV0Illo+Ma2BB3gg6v0Fx6kgpzM76xV37eS9aGgMmg7Ott9t IA1PuaXvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSeXZ-0003aN-Ft; Mon, 20 May 2019 09:25:05 +0000 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSeXV-00037b-Bs for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2019 09:25:03 +0000 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id C27EA80450; Mon, 20 May 2019 11:24:49 +0200 (CEST) Date: Mon, 20 May 2019 11:24:59 +0200 From: Pavel Machek To: Ran Wang Subject: Re: [PATCH V2 3/3] soc: fsl: add RCPM driver Message-ID: <20190520092459.GC9748@amd> References: <20190517033946.30763-1-ran.wang_1@nxp.com> <20190517033946.30763-3-ran.wang_1@nxp.com> <20190519213844.GH31403@amd> <20190520085647.GA9748@amd> <20190520090748.GB9748@amd> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_022501_848617_1692FE6E X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Len Brown , "devicetree@vger.kernel.org" , Pavel Machek , "linux-pm@vger.kernel.org" , "Rafael J . Wysocki" , "linux-kernel@vger.kernel.org" , Leo Li , Rob Herring , Greg Kroah-Hartman , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============7063214081918781581==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7063214081918781581== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0lnxQi9hkpPO77W3" Content-Disposition: inline --0lnxQi9hkpPO77W3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > > You are right, but the current code is "interesting". What about > > > > > > > > ws =3D NULL; > > > > while (ws =3D wakeup_source_get_next(NULL)) ... > > > > > > > > then? > > > > > > Did you mean: > > > ws =3D NULL; > > > while (ws =3D wakeup_source_get_next(ws)) ... > > > > > > Yes, that will be the same to my original logic, do you recommend > > > to change to this? :) > >=20 > > Yes please. It will be less confusing to the reader. >=20 > OK, if no other comment, I will work out v4, fix this and extra ',' > =20 > > Thanks (and sorry for cross-talk), >=20 > That's OK, thanks for your time. You can add Acked-by: Pavel Machek to that version. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --0lnxQi9hkpPO77W3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlzicmsACgkQMOfwapXb+vI/kACfXfr5zSF0QsKLaIDUnn6ldYdL 9rUAn1IvhOf/+HglBb9Ro5uZKDJsTOI+ =fAL6 -----END PGP SIGNATURE----- --0lnxQi9hkpPO77W3-- --===============7063214081918781581== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7063214081918781581==--