From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B1DDC04AAF for ; Tue, 21 May 2019 04:38:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F21EC216B7 for ; Tue, 21 May 2019 04:38:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cm1HJDza"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XUh+oiXp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F21EC216B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BurMr2Ilqmd4hkCBXA1FgUARUsDnTlugHphJ94PwaqU=; b=cm1HJDzauYRvkU h/HDNg1MNPiq/vhKMEPZqPf6zJabdMTgYAWeJ8oe8YzCFcRiiulB1liJHj5Jbj8eVh6jhcgqozjHu sD/UPTzx5ZssyY7bmHM8/kUYAVZroweeRv/+vT7bWcrojGT5QIBfmrgErzSeZ8KJ3xg74x4wp7a+Z Hyd/jV453126ldMRw/NNEyf965QlRHwaIizOBp4nQ/MLzYVUTRSUOGbM24K6XeorwegzgiXGGoszX bNCiMr0fNiHdGuqdy886quiQ+JO/03lR9JBqNbs0QoB5v+PmALVm89fjKkRLoQ0P4R2XAUsGWC+Q2 dAPWiYJFdq2QgvdZEb3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSwXW-00087B-Iu; Tue, 21 May 2019 04:38:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSwXT-00086l-Jp for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 04:38:12 +0000 Received: from localhost (unknown [106.201.107.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81ADB216B7; Tue, 21 May 2019 04:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558413491; bh=4XX4rftcytXAmMV6UJKvOiyXZ94mgRgAhcGdMVSOYYE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XUh+oiXpbm38TqLjIBnHnx97cGR+QEtHqrbEvcNlVtydTwJ8TmXVMG6VoRF5UMmL0 cytkPrj9S83s3Gz4AiqjY9HGxxgGyGORnMNQCJnrw+uqvgJiL2Kggl1vuwL7p6zfcT wMJzOQ36Rt41lGzEWPIxULTVMbZR6eKOdJwopdDg= Date: Tue, 21 May 2019 10:08:07 +0530 From: Vinod Koul To: Peng Ma Subject: Re: [PATCH 3/4] dmaengine: fsl-edma: support little endian for edma driver Message-ID: <20190521043807.GN15118@vkoul-mobl> References: <20190506090344.37784-1-peng.ma@nxp.com> <20190506090344.37784-3-peng.ma@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190506090344.37784-3-peng.ma@nxp.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_213811_669979_A3A547F5 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06-05-19, 09:03, Peng Ma wrote: > improve edma driver to support little endian. Can you explain a bit more how adding the below lines adds little endian support... > > Signed-off-by: Peng Ma > --- > drivers/dma/fsl-edma-common.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c > index 680b2a0..6bf238e 100644 > --- a/drivers/dma/fsl-edma-common.c > +++ b/drivers/dma/fsl-edma-common.c > @@ -83,9 +83,14 @@ void fsl_edma_chan_mux(struct fsl_edma_chan *fsl_chan, > u32 ch = fsl_chan->vchan.chan.chan_id; > void __iomem *muxaddr; > unsigned int chans_per_mux, ch_off; > + int endian_diff[4] = {3, 1, -1, -3}; > > chans_per_mux = fsl_chan->edma->n_chans / DMAMUX_NR; > ch_off = fsl_chan->vchan.chan.chan_id % chans_per_mux; > + > + if (!fsl_chan->edma->big_endian) > + ch_off += endian_diff[ch_off % 4]; > + > muxaddr = fsl_chan->edma->muxbase[ch / chans_per_mux]; > slot = EDMAMUX_CHCFG_SOURCE(slot); > > -- > 1.7.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel