From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56DBC04AAF for ; Tue, 21 May 2019 07:21:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A5D52173C for ; Tue, 21 May 2019 07:21:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dGAvW/HV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jtfJgFsn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A5D52173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8uOaEw+d3gTJgUxjqez4pV8fodgD8ZD3fQiC4mxDw5o=; b=dGAvW/HVGgQVku j6ZX82DbE6yECfdvAr0j25NM2Of8Z/nDIjSC+3Yl8rg6gKWBiNRQuD/sBDSSAG/k55tWPPs91AhwH aAOPdh9GOSosulzdNfyS3xGZr+IlAmLy0nJcZ9r6bWecsN3p9XRk625G6m3kW/+ADkIETBkUtSI88 v6sEb1d95b76HWRWfdgjcpgeMNuoDACDAQDFtYJxkFt7I5s8znnwOMRXOWEyz1SNOQDpn/OG0YuWk cNk+RTb4IL/B0llXulz+Kn+KodpLx+YdTNSSTMxiydkA26xr/HwIHO0A/kdvS3AChcqjAWx69xFZj gpugjd2AqC2SknOzQdHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSz5f-0003LT-DR; Tue, 21 May 2019 07:21:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSz5c-0003L9-N3 for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 07:21:37 +0000 Received: from localhost (unknown [106.201.107.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EECE2173C; Tue, 21 May 2019 07:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558423296; bh=Ag74ndH2WI93u1W3o4FuC7Tdt8eh+FlOGnYZ8HXxSqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jtfJgFsnCfrk08DHKSZaSoF8nvpXV6gOR3UMEHGjadaKpA5+aL9BL9ttSPdmq+ISd cBa25RUENQH7JR53M9V2yPmuxQIpv800uA8khRiYOo9JOhykuwy04XmlGH84QI6v32 VtiICNIRb5ptnpk7YJZI++SYntOLaq22uQGkziEw= Date: Tue, 21 May 2019 12:51:31 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH] dmaengine: ti: edma: Enable support for polled (memcpy) completion Message-ID: <20190521072131.GB15118@vkoul-mobl> References: <20190514080909.10306-1-peter.ujfalusi@ti.com> <20190521050430.GS15118@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_002136_770982_F7440316 X-CRM114-Status: GOOD ( 11.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-05-19, 09:16, Peter Ujfalusi wrote: > On 21/05/2019 8.04, Vinod Koul wrote: > > On 14-05-19, 11:09, Peter Ujfalusi wrote: > >> return vchan_tx_prep(&echan->vchan, &edesc->vdesc, tx_flags); > >> @@ -1801,6 +1804,20 @@ static enum dma_status edma_tx_status(struct dma_chan *chan, > >> unsigned long flags; > >> > >> ret = dma_cookie_status(chan, cookie, txstate); > >> + > >> + if (ret != DMA_COMPLETE && echan->edesc && !echan->edesc->cyclic) { > >> + struct edma_cc *ecc = echan->ecc; > >> + int channel = EDMA_CHAN_SLOT(echan->ch_num); > >> + int j = (channel >> 5); > >> + unsigned int mask = BIT(channel & 0x1f); > > > > GENMASK or define a macro instead of a magic number? > > So it is better to change the other places first from where I have just > copied this. That would be nice as well :) -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel