From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_DISCARD,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D6FC04AAF for ; Tue, 21 May 2019 09:56:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C52F62173E for ; Tue, 21 May 2019 09:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UdisrIk/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="aQxlmz+L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C52F62173E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rC0/X78q/q6G8+5KTS8OCClm71P93A91kEpDbcTUNc0=; b=UdisrIk/CDsG9N htdIIKEkOq4cRkUlt/X69djH9b5zks5xedQjwCWpZ5jgsbNNhbzdcF2zj9gvddqZJkI6oPWtmyg1o fqOvu21D2f/NXUP3k01RTCjYCW7NgBoa5EUs1e8IE1qA/LFJ/AnAWMi9aH/cat//8vyOXPdBDPlgc YqtaU1D1w6HlypYP4YdGedY+g1E221066+hvCXh7WSmqJK9PVTUvSCVslmz/Z0j8N67JSg4giDg5u 042jSvB8FZWeMcP6t7BIX2aMLJVe/Ot6UVYf5Rv0dm1g7rIR5bef5Dnz0IX2h3SEr0YQJf9Px4qp1 OlZebAaCIi/1vEtbxojw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT1Vg-0008A2-4V; Tue, 21 May 2019 09:56:40 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hT1Vb-000893-EA for linux-arm-kernel@lists.infradead.org; Tue, 21 May 2019 09:56:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1558432591; bh=1nbvGwWgSb1jI/P1ZT27Mo4T3fhSGGa/u2NrHc/bhEY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aQxlmz+L5OjzAbaGr0IgpRjnbM2RyEQ9ga6eu6t3E1wgEuRsrhjeZ3D6nbtxshUqQ EFtz03J7GkN8M0jpVIqGGEF95yxB7bHBJWFoHkXR0AupOG3A5VI/5BhgWHf71ZAzVl J10mK1Th7bIsLg6pDXlJsqz4NYBtfHlHzsAteH3k= Date: Tue, 21 May 2019 11:56:31 +0200 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Sergei Shtylyov Subject: Re: [PATCH v5 2/6] net: stmmac: sun8i: force select external PHY when no internal one Message-ID: <20190521095631.v5n3qml5ujofufk4@core.my.home> Mail-Followup-To: Sergei Shtylyov , linux-sunxi@googlegroups.com, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Icenowy Zheng , David Airlie , Daniel Vetter , Mark Rutland , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Maxime Coquelin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: <20190520235009.16734-1-megous@megous.com> <20190520235009.16734-3-megous@megous.com> <4e031eeb-2819-a97f-73bf-af84b04aa7b2@cogentembedded.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4e031eeb-2819-a97f-73bf-af84b04aa7b2@cogentembedded.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190521_025636_602021_36AEF49A X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Jose Abreu , Alexandre Torgue , devicetree@vger.kernel.org, Maxime Ripard , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, Rob Herring , linux-arm-kernel@lists.infradead.org, Daniel Vetter , Giuseppe Cavallaro , "David S. Miller" , Maxime Coquelin , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Sergei, On Tue, May 21, 2019 at 12:27:24PM +0300, Sergei Shtylyov wrote: > Hello! > > On 21.05.2019 2:50, megous@megous.com wrote: > > > From: Icenowy Zheng > > > > The PHY selection bit also exists on SoCs without an internal PHY; if it's > > set to 1 (internal PHY, default value) then the MAC will not make use of > > any PHY such SoCs. > ^ "on" or "with" missing? It's missing 'on'. thank you, Ondrej > > This problem appears when adapting for H6, which has no real internal PHY > > (the "internal PHY" on H6 is not on-die, but on a co-packaged AC200 chip, > > connected via RMII interface at GPIO bank A). > > > > Force the PHY selection bit to 0 when the SOC doesn't have an internal PHY, > > to address the problem of a wrong default value. > > > > Signed-off-by: Icenowy Zheng > > Signed-off-by: Ondrej Jirman > [...] > > MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel