Re: [PATCH v2] PCI: aardvark: Use LTSSM state to build link training flag

Remi Pommarel
2019-04-30T08:31:38Z

On Mon, Apr 29, 2019 at 02:45:32PM -0500, Bjorn Helgaas wrote:
> On Fri, Apr 26, 2019 at 12:27:57AM +0200, Remi Pommarel wrote:
> > On Thu, Apr 25, 2019 at 04:04:39PM -0500, Bjorn Helgaas wrote:
> > > On Sat, Mar 16, 2019 at 05:12:43PM +0100, Remi Pommarel wrote:
>
> > > It sounds like reading and/or writing some registers during a retrain
> > > causes some sort of EL1 error? Is this a separate erratum? Is there
> > > a list of the registers and operations (read/write) that are affected?
> > > The backtrace below suggests that it's actually a read of LNKCAP or
> > > LNKCTL (not LNKSTA) that caused the error.
> >
> > IIUC, the backtrace below produces an EL1 error when doing a PIO
> > transfer while the link is still retraining. See my comment below for
> > more about that. But accessing any root complex's register seems fine.
> > >
> > > It sounds like there are really two problems:
> > >
> > > 1) Reading PCI_EXP_LNKSTA (or the Aardvark equivalent) doesn't give
> > > valid data for PCI_EXP_LNKSTA_LT.
> >
> > The 1) is correct.
> >
> > > 2) Sometimes config reads cause EL1 errors.
> >
> > Actually EL1 error happens when we try to access device's register with
> > a PIO transfer, which is when we try to use the link while it is being
> > retrained.
> >
> > IMHO, 1) and 2) are linked. ASPM core tries to use the link too early
> > because it has read invalid data for PCI_EXP_LNKSTA_LT.
>
> From the software point of view, there is no such thing as "using the
> link too early". The pattern of:
>
> - Verify that link is up
> - Access device on other end of link
>
> is always racy because the link can go down at any time due to hotplug
> or other issues. In particular, the link can go down after we verify
> that the link is up, but before we access the device.
>
> Software must be able to deal with that gracefully. I don't know
> whether that means catching and recovering from that EL1 error, or
> masking it, or what. This is architecture-specific stuff that's
> outside the scope of PCIe itself.
>
> But a link going down should never directly cause a kernel panic.

Ah, yes, you are right. There is "worse" than the EL1 error though, boot
can also hang while accessing those registers when link is not in a
ready state.

So, yes, I do agree that there are two issues here. The
PCI_EXP_LNKSTA_LT register one and the EL1 error or hang one. On the
other hand I don't think I can split it in two because this patch only
fixes the former which happens to not trigger the latter (ASPM core is
kind enough to wait for the link to be ready after retraining).

Thus the second issue remains and hot plugging for example would
likely trigger it. I'll try to see with Thomas if we could reach the
vendor about that.

By the way, I have replied to Lorenzo with, what I think, is a more
legible patch. I could send a v3 with it if you prefer this one.

--
Remi